Github user fpompermaier commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/288#discussion_r160888052
  
    --- Diff: 
phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java
 ---
    @@ -2543,16 +2543,15 @@ public Void call() throws Exception {
             }
         }
     
    -    void createSysMutexTable(HBaseAdmin admin, ReadOnlyProps props) throws 
IOException, SQLException {
    +    void createSysMutexTableIfNotExists(HBaseAdmin admin, ReadOnlyProps 
props) throws IOException, SQLException {
             try {
    -            final TableName mutexTableName = 
SchemaUtil.getPhysicalTableName(
    -                PhoenixDatabaseMetaData.SYSTEM_MUTEX_NAME, props);
    -            List<TableName> systemTables = getSystemTableNames(admin);
    -            if (systemTables.contains(mutexTableName) || 
admin.tableExists( TableName.valueOf(
    -                
PhoenixDatabaseMetaData.SYSTEM_SCHEMA_NAME,PhoenixDatabaseMetaData.SYSTEM_MUTEX_TABLE_NAME)))
 {
    +            
if(admin.tableExists(PhoenixDatabaseMetaData.SYSTEM_MUTEX_NAME) || 
admin.tableExists(TableName.valueOf(
    --- End diff --
    
    why not just leave if (admin.tableExists(mutexTableName)) ?


---

Reply via email to