[GitHub] phoenix issue #308: Client-side hash aggregation

Github user geraldss commented on the issue: https://github.com/apache/phoenix/pull/308 Thanks @JamesRTaylor for the reviews and suggestions. ---

[GitHub] phoenix issue #308: Client-side hash aggregation

Github user geraldss commented on the issue: https://github.com/apache/phoenix/pull/308 @JamesRTaylor - Handled reverse sort; added explanatory comments about sorting; added tests for sorting and non-sorting, including EXPLAIN. Pushed changes; uploaded new .patch file

[GitHub] phoenix issue #308: Client-side hash aggregation

Github user geraldss commented on the issue: https://github.com/apache/phoenix/pull/308 @JamesRTaylor - Done. I switched the PR to 4.x-HBase-1.4, attached the .patch file, and issued "Submit Patch". ---

[GitHub] phoenix issue #308: Client-side hash aggregation

Github user geraldss commented on the issue: https://github.com/apache/phoenix/pull/308 @JamesRTaylor -- ok, I will submit a new PR. Can you comment on my last push and comments? ---

[GitHub] phoenix issue #308: Client-side hash aggregation

Github user geraldss commented on the issue: https://github.com/apache/phoenix/pull/308 Hi @JamesRTaylor, I pushed another change and replied with some comments. Please review, thanks. ---

[GitHub] phoenix pull request #308: Client-side hash aggregation

Github user geraldss commented on a diff in the pull request: https://github.com/apache/phoenix/pull/308#discussion_r205297065 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/execute/ClientAggregatePlan.java --- @@ -135,17 +142,25 @@ public ResultIterator iterator

[GitHub] phoenix pull request #308: Client-side hash aggregation

Github user geraldss commented on a diff in the pull request: https://github.com/apache/phoenix/pull/308#discussion_r205296815 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/execute/ClientAggregatePlan.java --- @@ -135,17 +142,25 @@ public ResultIterator iterator

[GitHub] phoenix pull request #308: Client-side hash aggregation

Github user geraldss commented on a diff in the pull request: https://github.com/apache/phoenix/pull/308#discussion_r205296403 --- Diff: phoenix-core/src/it/java/org/apache/phoenix/end2end/ClientHashAggregateIT.java --- @@ -0,0 +1,191 @@ +/* + * Licensed to the Apache

[GitHub] phoenix pull request #308: Client-side hash aggregation

Github user geraldss commented on a diff in the pull request: https://github.com/apache/phoenix/pull/308#discussion_r205296128 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/execute/ClientAggregatePlan.java --- @@ -183,13 +198,15 @@ public ExplainPlan getExplainPlan

[GitHub] phoenix pull request #308: Client-side hash aggregation

Github user geraldss commented on a diff in the pull request: https://github.com/apache/phoenix/pull/308#discussion_r205206944 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/execute/ClientAggregatePlan.java --- @@ -135,17 +142,24 @@ public ResultIterator iterator

[GitHub] phoenix pull request #308: Client-side hash aggregation

Github user geraldss commented on a diff in the pull request: https://github.com/apache/phoenix/pull/308#discussion_r204495020 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/execute/ClientAggregatePlan.java --- @@ -135,17 +142,24 @@ public ResultIterator iterator

[GitHub] phoenix pull request #308: Client-side hash aggregation

Github user geraldss commented on a diff in the pull request: https://github.com/apache/phoenix/pull/308#discussion_r204197232 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/iterate/ClientHashAggregatingResultIterator.java --- @@ -0,0 +1,189 @@ +/* + * Licensed

[GitHub] phoenix issue #308: Client-side hash aggregation

Github user geraldss commented on the issue: https://github.com/apache/phoenix/pull/308 @JamesRTaylor - pushed another change per your feedback. Fingers crossed :) Thanks. ---

[GitHub] phoenix pull request #308: Client-side hash aggregation

Github user geraldss commented on a diff in the pull request: https://github.com/apache/phoenix/pull/308#discussion_r20419 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/iterate/ClientHashAggregatingResultIterator.java --- @@ -0,0 +1,189 @@ +/* + * Licensed

[GitHub] phoenix pull request #308: Client-side hash aggregation

Github user geraldss commented on a diff in the pull request: https://github.com/apache/phoenix/pull/308#discussion_r204192760 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/iterate/ClientHashAggregatingResultIterator.java --- @@ -0,0 +1,189 @@ +/* + * Licensed

[GitHub] phoenix pull request #308: Client-side hash aggregation

Github user geraldss commented on a diff in the pull request: https://github.com/apache/phoenix/pull/308#discussion_r204192752 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/iterate/ClientHashAggregatingResultIterator.java --- @@ -0,0 +1,189 @@ +/* + * Licensed

[GitHub] phoenix pull request #308: Client-side hash aggregation

Github user geraldss commented on a diff in the pull request: https://github.com/apache/phoenix/pull/308#discussion_r204192739 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/iterate/ClientHashAggregatingResultIterator.java --- @@ -0,0 +1,189 @@ +/* + * Licensed

[GitHub] phoenix issue #308: Client-side hash aggregation

Github user geraldss commented on the issue: https://github.com/apache/phoenix/pull/308 @JamesRTaylor - I made the changes and they are ready for review. Thanks. ---

[GitHub] phoenix pull request #308: Client-side hash aggregation

Github user geraldss commented on a diff in the pull request: https://github.com/apache/phoenix/pull/308#discussion_r203926206 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/iterate/ClientHashAggregatingResultIterator.java --- @@ -0,0 +1,173 @@ +/* + * Licensed

[GitHub] phoenix pull request #308: Client-side hash aggregation

Github user geraldss commented on a diff in the pull request: https://github.com/apache/phoenix/pull/308#discussion_r203926179 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/iterate/ClientHashAggregatingResultIterator.java --- @@ -0,0 +1,173 @@ +/* + * Licensed

[GitHub] phoenix pull request #308: Client-side hash aggregation

Github user geraldss commented on a diff in the pull request: https://github.com/apache/phoenix/pull/308#discussion_r203926229 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/execute/ClientAggregatePlan.java --- @@ -135,17 +142,24 @@ public ResultIterator iterator

[GitHub] phoenix pull request #308: Client-side hash aggregation

Github user geraldss commented on a diff in the pull request: https://github.com/apache/phoenix/pull/308#discussion_r203467413 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/iterate/ClientHashAggregatingResultIterator.java --- @@ -0,0 +1,155 @@ +/* + * Licensed

[GitHub] phoenix pull request #308: Client-side hash aggregation

Github user geraldss commented on a diff in the pull request: https://github.com/apache/phoenix/pull/308#discussion_r203099292 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/iterate/ClientHashAggregatingResultIterator.java --- @@ -0,0 +1,155 @@ +/* + * Licensed

[GitHub] phoenix pull request #308: Client-side hash aggregation

Github user geraldss commented on a diff in the pull request: https://github.com/apache/phoenix/pull/308#discussion_r202112790 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/iterate/ClientHashAggregatingResultIterator.java --- @@ -0,0 +1,155 @@ +/* + * Licensed

[GitHub] phoenix pull request #308: Client-side hash aggregation

Github user geraldss commented on a diff in the pull request: https://github.com/apache/phoenix/pull/308#discussion_r201562225 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/iterate/ClientHashAggregatingResultIterator.java --- @@ -0,0 +1,155 @@ +/* + * Licensed

[GitHub] phoenix pull request #308: Client-side hash aggregation

Github user geraldss commented on a diff in the pull request: https://github.com/apache/phoenix/pull/308#discussion_r201562154 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/iterate/ClientHashAggregatingResultIterator.java --- @@ -0,0 +1,155 @@ +/* + * Licensed

[GitHub] phoenix issue #308: Client-side hash aggregation

Github user geraldss commented on the issue: https://github.com/apache/phoenix/pull/308 @joshelser Thanks for the review. I can make these changes now and push them. Or should I wait for any other reviewer? ---

[GitHub] phoenix pull request #308: Client-side hash aggregation

GitHub user geraldss opened a pull request: https://github.com/apache/phoenix/pull/308 Client-side hash aggregation Client-side hash aggregation for use with sort-merge join. Implements https://issues.apache.org/jira/browse/PHOENIX-4751 You can merge this pull request