[GitHub] phoenix pull request: Upgrade ANTLR version to correct generation ...

2016-05-06 Thread gliptak
Github user gliptak closed the pull request at: https://github.com/apache/phoenix/pull/136 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] phoenix pull request: PHOENIX-2466 Correct warning on maven-depend...

2016-05-06 Thread gliptak
Github user gliptak closed the pull request at: https://github.com/apache/phoenix/pull/138 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] phoenix pull request: PHOENIX-2464 Convert phoenix-spark module to...

2016-05-06 Thread gliptak
Github user gliptak closed the pull request at: https://github.com/apache/phoenix/pull/137 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] phoenix pull request: PHOENIX-2023 Build tar.gz only on release pr...

2016-05-06 Thread gliptak
Github user gliptak closed the pull request at: https://github.com/apache/phoenix/pull/134 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] phoenix pull request: PHOENIX-2165 Make zip file name and director...

2016-04-21 Thread gliptak
Github user gliptak closed the pull request at: https://github.com/apache/phoenix/pull/106 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] phoenix pull request: PHOENIX-2165 Make zip file name and director...

2016-03-11 Thread gliptak
Github user gliptak commented on the pull request: https://github.com/apache/phoenix/pull/106#issuecomment-195519766 Any other changes you would like to see here? Thanks --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] phoenix pull request: Upgrade ANTLR version to correct generation ...

2016-03-05 Thread gliptak
Github user gliptak commented on the pull request: https://github.com/apache/phoenix/pull/136#issuecomment-192650502 @JamesRTaylor Please review. Thanks --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] phoenix pull request: PHOENIX-2464 Convert phoenix-spark module to...

2015-12-02 Thread gliptak
Github user gliptak commented on the pull request: https://github.com/apache/phoenix/pull/137#issuecomment-161358663 Another possibility is to duplicate ```BaseHBaseManagedTimeIT```/```BaseTest``` functionality in ```Scala```/```FunSuite``` ... --- If your project is set up for it

[GitHub] phoenix pull request: PHOENIX-2464 Convert phoenix-spark module to...

2015-12-01 Thread gliptak
Github user gliptak commented on the pull request: https://github.com/apache/phoenix/pull/137#issuecomment-161151768 Scala "static" methods on the companion object are not recognized as such by the ```@BeforeClass``` and ```@AfterClass``` annotations. --- If your project

[GitHub] phoenix pull request: PHOENIX-2464 Convert phoenix-spark module to...

2015-12-01 Thread gliptak
Github user gliptak commented on the pull request: https://github.com/apache/phoenix/pull/137#issuecomment-161137156 I measured 2x longer (with the Scalatest throwing warnings/errors during tear down ...). I will try to add the companion object. --- If your project is set up for it

[GitHub] phoenix pull request: PHOENIX-2464 Convert phoenix-spark module to...

2015-11-30 Thread gliptak
Github user gliptak commented on the pull request: https://github.com/apache/phoenix/pull/137#issuecomment-160817033 Now it runs locally. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] phoenix pull request: PHOENIX-2464 Convert phoenix-spark module to...

2015-11-30 Thread gliptak
Github user gliptak commented on the pull request: https://github.com/apache/phoenix/pull/137#issuecomment-160784699 @jmahonin Could you run the tests locally (my local setup is not quite working ...)? Thanks --- If your project is set up for it, you can reply to this email and have

[GitHub] phoenix pull request: PHOENIX-2466 Correct warning on maven-depend...

2015-11-30 Thread gliptak
GitHub user gliptak opened a pull request: https://github.com/apache/phoenix/pull/138 PHOENIX-2466 Correct warning on maven-dependency-plugin in phoenix-core You can merge this pull request into a Git repository by running: $ git pull https://github.com/gliptak/phoenix

[GitHub] phoenix pull request: PHOENIX-2464 Convert phoenix-spark module to...

2015-11-30 Thread gliptak
GitHub user gliptak opened a pull request: https://github.com/apache/phoenix/pull/137 PHOENIX-2464 Convert phoenix-spark module to 'JUnitSuite' instead of … …'FunSuite' You can merge this pull request into a Git repository by running: $ git pull https:

[GitHub] phoenix pull request: Upgrade ANTLR version to correct generation ...

2015-11-30 Thread gliptak
Github user gliptak commented on the pull request: https://github.com/apache/phoenix/pull/136#issuecomment-160742249 @JamesRTaylor I updated the commit message --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] phoenix pull request: Upgrade ANTLR version to correct generation ...

2015-11-30 Thread gliptak
GitHub user gliptak opened a pull request: https://github.com/apache/phoenix/pull/136 Upgrade ANTLR version to correct generation error with Java 8 You can merge this pull request into a Git repository by running: $ git pull https://github.com/gliptak/phoenix PHOENIX-2465

[GitHub] phoenix pull request: PHOENIX-2023 Build tar.gz only on release pr...

2015-11-23 Thread gliptak
Github user gliptak commented on the pull request: https://github.com/apache/phoenix/pull/134#issuecomment-159116060 https://github.com/apache/phoenix/pull/110 @ndimiduk @JamesRTaylor and @chrajeshbabu Please review. Thanks --- If your project is set up for it, you can reply to

[GitHub] phoenix pull request: PHOENIX-2023 Build tar.gz only on release pr...

2015-11-23 Thread gliptak
Github user gliptak closed the pull request at: https://github.com/apache/phoenix/pull/110 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] phoenix pull request: PHOENIX-2023 Build tar.gz only on release pr...

2015-11-23 Thread gliptak
GitHub user gliptak opened a pull request: https://github.com/apache/phoenix/pull/134 PHOENIX-2023 Build tar.gz only on release profile You can merge this pull request into a Git repository by running: $ git pull https://github.com/gliptak/phoenix PHOENIX-2023 Alternatively

[GitHub] phoenix pull request: PHOENIX-2023 Build tar.gz only on release pr...

2015-08-18 Thread gliptak
Github user gliptak commented on the pull request: https://github.com/apache/phoenix/pull/110#issuecomment-132392617 @ndimiduk Would you like to see additional changes? Thanks --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] phoenix pull request: PHOENIX-2023 Build tar.gz only on release pr...

2015-08-14 Thread gliptak
GitHub user gliptak opened a pull request: https://github.com/apache/phoenix/pull/110 PHOENIX-2023 Build tar.gz only on release profile The release build breaks without the license headers included. You can merge this pull request into a Git repository by running: $ git pull

[GitHub] phoenix pull request: PHOENIX-2165 Make zip file name and director...

2015-08-06 Thread gliptak
GitHub user gliptak opened a pull request: https://github.com/apache/phoenix/pull/106 PHOENIX-2165 Make zip file name and directory consistent for phoenix-*-cluster.zip You can merge this pull request into a Git repository by running: $ git pull https://github.com/gliptak