[GitHub] phoenix issue #238: PHOENIX-3690 Support declaring default values in Phoenix...

2017-04-02 Thread kliewkliew
Github user kliewkliew commented on the issue: https://github.com/apache/phoenix/pull/238 @chrajeshbabu please review --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] phoenix pull request #238: PHOENIX-3690 Support declaring default values in ...

2017-04-02 Thread kliewkliew
GitHub user kliewkliew opened a pull request: https://github.com/apache/phoenix/pull/238 PHOENIX-3690 Support declaring default values in Phoenix-Calcite: add… …endum to support new interface after CALCITE-1702 You can merge this pull request into a Git repository by running

[GitHub] phoenix pull request #208: PHOENIX-3046 `NOT LIKE '%'` unexpectedly returns ...

2016-11-26 Thread kliewkliew
Github user kliewkliew closed the pull request at: https://github.com/apache/phoenix/pull/208 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] phoenix pull request #208: PHOENIX-3046 `NOT LIKE '%'` unexpectedly returns ...

2016-09-11 Thread kliewkliew
Github user kliewkliew commented on a diff in the pull request: https://github.com/apache/phoenix/pull/208#discussion_r78300203 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/compile/ExpressionCompiler.java --- @@ -523,7 +523,12 @@ public Expression visitLeave

[GitHub] phoenix pull request #208: PHOENIX-3046 `NOT LIKE '%'` unexpectedly returns ...

2016-09-09 Thread kliewkliew
Github user kliewkliew commented on a diff in the pull request: https://github.com/apache/phoenix/pull/208#discussion_r78270028 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/compile/ExpressionCompiler.java --- @@ -523,7 +523,12 @@ public Expression visitLeave

[GitHub] phoenix pull request #208: PHOENIX-3046 `NOT LIKE '%'` unexpectedly returns ...

2016-09-09 Thread kliewkliew
Github user kliewkliew commented on a diff in the pull request: https://github.com/apache/phoenix/pull/208#discussion_r78269568 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/compile/ExpressionCompiler.java --- @@ -523,7 +523,12 @@ public Expression visitLeave

[GitHub] phoenix pull request #208: PHOENIX-3046 `NOT LIKE '%'` unexpectedly returns ...

2016-09-09 Thread kliewkliew
GitHub user kliewkliew opened a pull request: https://github.com/apache/phoenix/pull/208 PHOENIX-3046 `NOT LIKE '%'` unexpectedly returns results You can merge this pull request into a Git repository by running: $ git pull https://github.com/kliewkliew/phoenix PH

[GitHub] phoenix pull request #206: PHOENIX-2946 Projected comparison between date an...

2016-09-07 Thread kliewkliew
Github user kliewkliew closed the pull request at: https://github.com/apache/phoenix/pull/206 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] phoenix issue #207: Phoenix-476 Support declaration of DEFAULT in CREATE sta...

2016-09-07 Thread kliewkliew
Github user kliewkliew commented on the issue: https://github.com/apache/phoenix/pull/207 Based on the wrong branch --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] phoenix pull request #207: Phoenix-476 Support declaration of DEFAULT in CRE...

2016-09-07 Thread kliewkliew
Github user kliewkliew closed the pull request at: https://github.com/apache/phoenix/pull/207 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] phoenix pull request #207: Phoenix-476 Support declaration of DEFAULT in CRE...

2016-09-07 Thread kliewkliew
GitHub user kliewkliew opened a pull request: https://github.com/apache/phoenix/pull/207 Phoenix-476 Support declaration of DEFAULT in CREATE statement You can merge this pull request into a Git repository by running: $ git pull https://github.com/kliewkliew/phoenix PHOENIX

[GitHub] phoenix issue #200: PHOENIX-2641 Implicit wildcard in LIKE predicate search ...

2016-09-06 Thread kliewkliew
Github user kliewkliew commented on the issue: https://github.com/apache/phoenix/pull/200 @twdsilva Thanks for committing --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] phoenix issue #200: PHOENIX-2641 Implicit wildcard in LIKE predicate search ...

2016-09-02 Thread kliewkliew
Github user kliewkliew commented on the issue: https://github.com/apache/phoenix/pull/200 @twdsilva Changes were made and rebased, --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] phoenix pull request #200: PHOENIX-2641 Implicit wildcard in LIKE predicate ...

2016-09-02 Thread kliewkliew
Github user kliewkliew commented on a diff in the pull request: https://github.com/apache/phoenix/pull/200#discussion_r77374014 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/compile/ExpressionCompiler.java --- @@ -517,8 +518,13 @@ public Expression visitLeave

[GitHub] phoenix pull request #198: PHOENIX-2474 Cannot round to a negative precision...

2016-09-01 Thread kliewkliew
Github user kliewkliew closed the pull request at: https://github.com/apache/phoenix/pull/198 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] phoenix issue #198: PHOENIX-2474 Cannot round to a negative precision (to th...

2016-09-01 Thread kliewkliew
Github user kliewkliew commented on the issue: https://github.com/apache/phoenix/pull/198 https://github.com/apache/phoenix/commit/b7d45ca66729ae57c0896449e36b80f4fdcafb46 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] phoenix issue #201: PHOENIX-2793 Date-time functions on null dates return no...

2016-09-01 Thread kliewkliew
Github user kliewkliew commented on the issue: https://github.com/apache/phoenix/pull/201 https://github.com/apache/phoenix/commit/06d37e534d1e07e8206eaefb82dd7bf3f50455b0 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] phoenix pull request #201: PHOENIX-2793 Date-time functions on null dates re...

2016-09-01 Thread kliewkliew
Github user kliewkliew closed the pull request at: https://github.com/apache/phoenix/pull/201 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] phoenix pull request #:

2016-09-01 Thread kliewkliew
Github user kliewkliew commented on the pull request: https://github.com/apache/phoenix/commit/06d37e534d1e07e8206eaefb82dd7bf3f50455b0#commitcomment-18870326 fixes #201 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] phoenix issue #206: PHOENIX-2946 Projected comparison between date and times...

2016-09-01 Thread kliewkliew
Github user kliewkliew commented on the issue: https://github.com/apache/phoenix/pull/206 Are some casting operations more expensive than coercion? Should the `isCastableTo` checks be moved to their own `else-if` branches below the `isCoercibleTo` checks? --- If your project is set

[GitHub] phoenix pull request #206: PHOENIX-2946 Projected comparison between date an...

2016-09-01 Thread kliewkliew
GitHub user kliewkliew opened a pull request: https://github.com/apache/phoenix/pull/206 PHOENIX-2946 Projected comparison between date and timestamp columns … …always returns true You can merge this pull request into a Git repository by running: $ git pull https

[GitHub] phoenix pull request #199: PHOENIX-2645 Wildcard characters do not match new...

2016-08-31 Thread kliewkliew
Github user kliewkliew closed the pull request at: https://github.com/apache/phoenix/pull/199 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] phoenix pull request #204: PHOENIX-1647 Fully qualified tablename query supp...

2016-08-29 Thread kliewkliew
Github user kliewkliew closed the pull request at: https://github.com/apache/phoenix/pull/204 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] phoenix issue #204: PHOENIX-1647 Fully qualified tablename query support in ...

2016-08-29 Thread kliewkliew
Github user kliewkliew commented on the issue: https://github.com/apache/phoenix/pull/204 https://github.com/apache/phoenix/commit/d873c2ffd1e539ecd56858c82f0ba2d23e877cf9 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] phoenix issue #199: PHOENIX-2645 Wildcard characters do not match newline ch...

2016-08-29 Thread kliewkliew
Github user kliewkliew commented on the issue: https://github.com/apache/phoenix/pull/199 Sure, I'll pick up that JIRA. The unit tests evaluate both byte and string based regex (and compares the two results) but the integration tests only evaluate string based regex. --- If

[GitHub] phoenix pull request #204: PHOENIX-1647 Fully qualified tablename query supp...

2016-08-29 Thread kliewkliew
GitHub user kliewkliew opened a pull request: https://github.com/apache/phoenix/pull/204 PHOENIX-1647 Fully qualified tablename query support in Phoenix You can merge this pull request into a Git repository by running: $ git pull https://github.com/kliewkliew/phoenix PHOENIX

[GitHub] phoenix pull request #201: PHOENIX-2793 Date-time functions on null dates re...

2016-08-26 Thread kliewkliew
GitHub user kliewkliew opened a pull request: https://github.com/apache/phoenix/pull/201 PHOENIX-2793 Date-time functions on null dates return no data I cannot reproduce the issue but I added a test case. You can merge this pull request into a Git repository by running: $ git

[GitHub] phoenix pull request #200: PHOENIX-2641 Implicit wildcard in LIKE predicate ...

2016-08-26 Thread kliewkliew
GitHub user kliewkliew reopened a pull request: https://github.com/apache/phoenix/pull/200 PHOENIX-2641 Implicit wildcard in LIKE predicate search pattern You can merge this pull request into a Git repository by running: $ git pull https://github.com/kliewkliew/phoenix

[GitHub] phoenix pull request #200: PHOENIX-2641 Implicit wildcard in LIKE predicate ...

2016-08-26 Thread kliewkliew
Github user kliewkliew closed the pull request at: https://github.com/apache/phoenix/pull/200 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] phoenix issue #200: PHOENIX-2641 Implicit wildcard in LIKE predicate search ...

2016-08-26 Thread kliewkliew
Github user kliewkliew commented on the issue: https://github.com/apache/phoenix/pull/200 Needs more testing --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] phoenix pull request #200: PHOENIX-2641 Implicit wildcard in LIKE predicate ...

2016-08-26 Thread kliewkliew
GitHub user kliewkliew opened a pull request: https://github.com/apache/phoenix/pull/200 PHOENIX-2641 Implicit wildcard in LIKE predicate search pattern You can merge this pull request into a Git repository by running: $ git pull https://github.com/kliewkliew/phoenix PHOENIX

[GitHub] phoenix pull request #199: PHOENIX-2645 Wildcard characters do not match new...

2016-08-26 Thread kliewkliew
GitHub user kliewkliew opened a pull request: https://github.com/apache/phoenix/pull/199 PHOENIX-2645 Wildcard characters do not match newline characters You can merge this pull request into a Git repository by running: $ git pull https://github.com/kliewkliew/phoenix PHOENIX

[GitHub] phoenix pull request #198: PHOENIX-2474 Cannot round to a negative precision...

2016-08-25 Thread kliewkliew
GitHub user kliewkliew opened a pull request: https://github.com/apache/phoenix/pull/198 PHOENIX-2474 Cannot round to a negative precision (to the left of the… … decimal) You can merge this pull request into a Git repository by running: $ git pull https://github.com