[GitHub] phoenix issue #195: Zipkin

2016-08-24 Thread mujtabachohan
Github user mujtabachohan commented on the issue: https://github.com/apache/phoenix/pull/195 Please merge with phoenix-tracing-webapp and name it phoenix-tracing. Use default properties for zipkin configuration in case they are not configurable. --- If your project is set up for it

[GitHub] phoenix pull request #195: Zipkin

2016-08-24 Thread mujtabachohan
Github user mujtabachohan commented on a diff in the pull request: https://github.com/apache/phoenix/pull/195#discussion_r76099712 --- Diff: phoenix-zipkin/pom.xml --- @@ -0,0 +1,102 @@ + + + + http://maven.apache.org/POM/4.0.0"; xmlns:xsi="http://

[GitHub] phoenix pull request #195: Zipkin

2016-08-24 Thread mujtabachohan
Github user mujtabachohan commented on a diff in the pull request: https://github.com/apache/phoenix/pull/195#discussion_r76099515 --- Diff: phoenix-zipkin/pom.xml --- @@ -0,0 +1,102 @@ + + + + http://maven.apache.org/POM/4.0.0"; xmlns:xsi="http://

[GitHub] phoenix pull request #195: Zipkin

2016-08-24 Thread mujtabachohan
Github user mujtabachohan commented on a diff in the pull request: https://github.com/apache/phoenix/pull/195#discussion_r76099342 --- Diff: phoenix-zipkin/pom.xml --- @@ -0,0 +1,102 @@ + + + + http://maven.apache.org/POM/4.0.0"; xmlns:xsi="http://

[GitHub] phoenix pull request #183: PHOENIX-3084 source release licensing issues.

2016-07-19 Thread mujtabachohan
Github user mujtabachohan commented on a diff in the pull request: https://github.com/apache/phoenix/pull/183#discussion_r71390004 --- Diff: examples/STOCK_SYMBOL.sql --- @@ -1,3 +1,19 @@ +-- Licensed to the Apache Software Foundation (ASF) under one +-- or more contributor

[GitHub] phoenix pull request: PHOENIX-2182

2015-09-01 Thread mujtabachohan
GitHub user mujtabachohan opened a pull request: https://github.com/apache/phoenix/pull/115 PHOENIX-2182 You can merge this pull request into a Git repository by running: $ git pull https://github.com/mujtabachohan/phoenix-1 master Alternatively you can review and apply

[GitHub] phoenix pull request: working additions of pherf to phoenix as a p...

2015-03-11 Thread mujtabachohan
Github user mujtabachohan commented on a diff in the pull request: https://github.com/apache/phoenix/pull/41#discussion_r26239493 --- Diff: phoenix-pherf/src/main/java/org/apache/phoenix/pherf/workload/MultithreadedRunner.java --- @@ -0,0 +1,171 @@ +/* + * Licensed to the

[GitHub] phoenix pull request: working additions of pherf to phoenix as a p...

2015-03-11 Thread mujtabachohan
Github user mujtabachohan commented on a diff in the pull request: https://github.com/apache/phoenix/pull/41#discussion_r26238686 --- Diff: phoenix-pherf/pom.xml --- @@ -0,0 +1,291 @@ + + +http://maven.apache.org/POM/4.0.0"; xmlns:xsi="http://www.w3.org/2001

[GitHub] phoenix pull request: working additions of pherf to phoenix as a p...

2015-03-11 Thread mujtabachohan
Github user mujtabachohan commented on a diff in the pull request: https://github.com/apache/phoenix/pull/41#discussion_r26238510 --- Diff: phoenix-pherf/config/pherf.properties --- @@ -0,0 +1,61 @@ +# --- End diff -- Minor nit: multiple license headers --- If