Re: [DISCUSS] dropping 0.98 support?

2017-10-11 Thread Josh Elser
+1 to the "getting lighter" sentiment. Selectively bringing back stuff to 0.98 is a nice way to keep the burden low. On 10/10/17 1:32 PM, James Taylor wrote: I'm -1 on a shim layer for 0.98. It would needlessly complicate the code when all we need for the 0.98 branch are critical bug fixes. I

Re: [DISCUSS] dropping 0.98 support?

2017-10-10 Thread James Taylor
I'm -1 on a shim layer for 0.98. It would needlessly complicate the code when all we need for the 0.98 branch are critical bug fixes. It's not just the effort of putting it in place, but the complication of understanding it going forward (not to mention the testing efforts - we've spent a huge effo

Re: [DISCUSS] dropping 0.98 support?

2017-10-10 Thread Andrew Purtell
I volunteer to develop and maintain a shim for 0.98 if nobody else will. If Phoenix is going to shim anyway for 1.2 vs 1.3 vs 1.4 vs ... then we need one for 0.98 for as long as we have 0.98 in production where I work, and I'm pessimistically estimating another year at least in some places. I think

Re: [DISCUSS] dropping 0.98 support?

2017-10-10 Thread James Taylor
We won't need features ported over to the 0.98 branch, so I think it's better all around if we just let the branches diverge rather than implementing some kind of shim layer. We'll likely just need to do one or two point releases on 0.98. We can do that from the 4.12-HBase-0.98 branch. Here are so

Re: [DISCUSS] dropping 0.98 support?

2017-10-09 Thread Sergey Soldatov
Heh. I just remember that last time in August you said that you already migrating to more recent version of HBase and have no problems to maintain 0.98 internally during for short time. As an alternative can we add shims, so most of the difference in API can be grouped there and will be easy to mai

Re: [DISCUSS] dropping 0.98 support?

2017-10-09 Thread Andrew Purtell
Until we migrate our production at Salesforce off of 0.98 we will still have to support 0.98 internally, and a number of our staff are committers, so I suspect there will be adequate support for the 0.98 branch for another couple of releases. On Mon, Oct 9, 2017 at 12:36 PM, Sergey Soldatov wrote

[DISCUSS] dropping 0.98 support?

2017-10-09 Thread Sergey Soldatov
I remember that we discussed that a couple times already without any final decision, so let me raise this question again. HBase 2.0 is getting close to the release and to support it we will need to do a lot of refactoring in the code even just to get Phoenix compiled. And already we may start to re