Github user akshita-malhotra commented on the issue:
https://github.com/apache/phoenix/pull/239
- Snapshot scanner for non-aggregate queries.
- Added integration tests (simple select query, conditional and limit)
- Abstracted out ScanRegionObserver code to fetch the processed re
Github user JamesRTaylor commented on the issue:
https://github.com/apache/phoenix/pull/239
I don't think it's necessary to fully understand the functionality to do
the refactoring I've mentioned, @akshita-malhotra. Here's how I'd recommend
approaching it:
* create a new inte
Github user JamesRTaylor commented on the issue:
https://github.com/apache/phoenix/pull/239
Please amend your commit message to be prefixed with PHOENIX-3744 (instead
of Phoenix-3744) so that review comments show up as comments on the JIRA,
@akshita-malhotra. Also, let's get a patch a
Github user akshita-malhotra commented on the issue:
https://github.com/apache/phoenix/pull/239
Sure, I will do that. Thanks @JamesRTaylor
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have thi
Github user JamesRTaylor commented on the issue:
https://github.com/apache/phoenix/pull/239
Thanks for the updates, @akshita-malhotra - I made a few comments/questions.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If y
Github user akshita-malhotra commented on the issue:
https://github.com/apache/phoenix/pull/239
Thanks @JamesRTaylor . I squashed the commits and changed the prefix of the
commit message. I will answer/make appropriate changes and upload the patch
onto the jira.
---
If your project
