[GitHub] phoenix issue #304: PHOENIX-3955: Ensure KEEP_DELETED_CELLS, REPLICATION_SCO...

2018-06-11 Thread twdsilva
Github user twdsilva commented on the issue: https://github.com/apache/phoenix/pull/304 I think you is better If you add code to UpgradeUtil that runs at the next major upgrade that checks all the tables and ensures these three property values are in sync (see addParentToChildLinks

[GitHub] phoenix issue #304: PHOENIX-3955: Ensure KEEP_DELETED_CELLS, REPLICATION_SCO...

2018-06-01 Thread ChinmaySKulkarni
Github user ChinmaySKulkarni commented on the issue: https://github.com/apache/phoenix/pull/304 Ran into [PHOENIX-3167](https://issues.apache.org/jira/browse/PHOENIX-3167) when doing some testing for this JIRA.  This can be a bigger problem now that we force an upgrade in

[GitHub] phoenix issue #304: PHOENIX-3955: Ensure KEEP_DELETED_CELLS, REPLICATION_SCO...

2018-06-01 Thread ChinmaySKulkarni
Github user ChinmaySKulkarni commented on the issue: https://github.com/apache/phoenix/pull/304 @twdsilva @vincentpoon please review. I will be adding stuff mentioned in "TODO", but just wanted your feedback on this initial patch. ---