GitHub user chrajeshbabu opened a pull request:
https://github.com/apache/phoenix/pull/168
PHOENIX-1734 Local index improvements(Rajeshbabu)
This is the patch for new implementation of local index where we store
local index data in the separate column families in the same table than
Github user JamesRTaylor commented on the pull request:
https://github.com/apache/phoenix/pull/168#issuecomment-218194916
How about a version that doesn't depend on HBASE-15600 so that we can
continue to support older versions of HBase (and can do a 4.8 release)? What
we've typically
Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/168#discussion_r62696240
--- Diff:
phoenix-core/src/it/java/org/apache/phoenix/end2end/SortMergeJoinIT.java ---
@@ -187,13 +186,13 @@ public void initTable() throws Exception {
Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/168#discussion_r62697744
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/coprocessor/UngroupedAggregateRegionObserver.java
---
@@ -165,6 +165,9 @@ public RegionScanner
Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/168#discussion_r62698009
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/coprocessor/UngroupedAggregateRegionObserver.java
---
@@ -202,7 +207,10 @@ protected RegionScan
Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/168#discussion_r62698174
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/execute/DelegateHTable.java ---
@@ -297,4 +297,28 @@ public boolean checkAndDelete(byte[] row, b
Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/168#discussion_r62699243
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/index/IndexMaintainer.java ---
@@ -861,7 +871,12 @@ public Put buildUpdateMutation(KeyValueBuild
Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/168#discussion_r62699657
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/iterate/ExplainTable.java ---
@@ -198,8 +198,14 @@ private void appendPKColumnValue(StringBuilde
Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/168#discussion_r62700523
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/schema/MetaDataClient.java ---
@@ -1016,7 +1016,7 @@ private MutationState buildIndexAtTimeStamp
Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/168#discussion_r62710902
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/index/PhoenixTransactionalIndexer.java
---
@@ -160,6 +163,9 @@ public void
preBatchMutate(Obse
Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/168#discussion_r62710798
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/hbase/index/write/ParallelWriterIndexCommitter.java
---
@@ -116,7 +117,10 @@ public void write(
Github user chrajeshbabu commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/168#discussion_r63463302
--- Diff:
phoenix-core/src/it/java/org/apache/phoenix/end2end/SortMergeJoinIT.java ---
@@ -187,13 +186,13 @@ public void initTable() throws Exception {
Github user chrajeshbabu commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/168#discussion_r63463350
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/coprocessor/UngroupedAggregateRegionObserver.java
---
@@ -202,7 +207,10 @@ protected RegionScan
Github user chrajeshbabu commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/168#discussion_r63463482
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/index/IndexMaintainer.java ---
@@ -861,7 +871,12 @@ public Put buildUpdateMutation(KeyValueBuild
Github user chrajeshbabu commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/168#discussion_r63463462
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/execute/DelegateHTable.java ---
@@ -297,4 +297,28 @@ public boolean checkAndDelete(byte[] row, b
Github user chrajeshbabu commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/168#discussion_r63463584
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/schema/MetaDataClient.java ---
@@ -1016,7 +1016,7 @@ private MutationState buildIndexAtTimeStamp
Github user chrajeshbabu commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/168#discussion_r63463618
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/hbase/index/write/ParallelWriterIndexCommitter.java
---
@@ -116,7 +117,10 @@ public void write(
Github user chrajeshbabu commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/168#discussion_r63463623
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/index/PhoenixTransactionalIndexer.java
---
@@ -160,6 +163,9 @@ public void
preBatchMutate(Obse
Github user chrajeshbabu commented on the pull request:
https://github.com/apache/phoenix/pull/168#issuecomment-219617896
James as we discussed I have made a patch working with older versions of
HBase first and handled review comments here. Will create new pull request with
that patch
Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/168#discussion_r63468900
--- Diff:
phoenix-core/src/it/java/org/apache/phoenix/end2end/SortMergeJoinIT.java ---
@@ -187,13 +186,13 @@ public void initTable() throws Exception {
Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/168#discussion_r63469161
--- Diff:
phoenix-core/src/it/java/org/apache/phoenix/end2end/index/MutableIndexIT.java
---
@@ -707,16 +702,17 @@ public void testIndexHalfStoreFileRea
Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/168#discussion_r63469452
--- Diff: phoenix-core/src/main/java/org/apache/phoenix/util/IndexUtil.java
---
@@ -667,4 +651,28 @@ public static String
getIndexColumnExpressionStr(P
Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/168#discussion_r63469708
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java
---
@@ -2455,6 +2409,19 @@ public Void call() throws Exc
Github user JamesRTaylor commented on the pull request:
https://github.com/apache/phoenix/pull/168#issuecomment-219630101
Looks very good, @chrajeshbabu! Thanks so much for this. Are you ok making
the changes I mentioned?
---
If your project is set up for it, you can reply to this em
Github user chrajeshbabu commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/168#discussion_r64123637
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java
---
@@ -2455,6 +2409,19 @@ public Void call() throws Exc
Github user chrajeshbabu commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/168#discussion_r64123714
--- Diff:
phoenix-core/src/it/java/org/apache/phoenix/end2end/SortMergeJoinIT.java ---
@@ -187,13 +186,13 @@ public void initTable() throws Exception {
Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/168#discussion_r64124199
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/util/UpgradeUtil.java ---
@@ -292,6 +294,119 @@ private static void
preSplitSequenceTable(Phoen
Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/168#discussion_r64124279
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/coprocessor/UngroupedAggregateRegionObserver.java
---
@@ -165,6 +165,9 @@ public RegionScanner
28 matches
Mail list logo
