Github user chrajeshbabu commented on the pull request:
https://github.com/apache/phoenix/pull/77#issuecomment-96969719
It's committed. Hence closing.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user chrajeshbabu closed the pull request at:
https://github.com/apache/phoenix/pull/77
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/77#discussion_r29102300
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/expression/function/UDFExpression.java
---
@@ -0,0 +1,217 @@
+/*
+ * Licensed to the
Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/77#discussion_r29102639
--- Diff: phoenix-core/src/main/antlr3/PhoenixSQL.g ---
@@ -114,6 +114,15 @@ tokens
ASYNC='async';
SAMPLING='sampling';
Github user chrajeshbabu commented on the pull request:
https://github.com/apache/phoenix/pull/77#issuecomment-96276745
Thanks @JamesRTaylor @samarthjain
I have addressed the review comments and added to pull request. If it's ok
I will commit this tomorrow morning IST and work
Github user chrajeshbabu commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/77#discussion_r29103983
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/expression/function/UDFExpression.java
---
@@ -0,0 +1,217 @@
+/*
+ * Licensed to the
Github user chrajeshbabu commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/77#discussion_r29103995
--- Diff: phoenix-core/src/main/antlr3/PhoenixSQL.g ---
@@ -114,6 +114,15 @@ tokens
ASYNC='async';
SAMPLING='sampling';
Github user chrajeshbabu commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/77#discussion_r29098669
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/coprocessor/MetaDataEndpointImpl.java
---
@@ -700,6 +1007,29 @@ private PTable
Github user chrajeshbabu commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/77#discussion_r29098659
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/cache/GlobalCache.java ---
@@ -157,4 +159,18 @@ public TenantCache
Github user chrajeshbabu commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/77#discussion_r29098664
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/compile/CreateFunctionCompiler.java
---
@@ -0,0 +1,84 @@
+/*
+ * Licensed to the Apache
Github user chrajeshbabu commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/77#discussion_r29098873
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/expression/function/UDFExpression.java
---
@@ -0,0 +1,217 @@
+/*
+ * Licensed to the
Github user chrajeshbabu commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/77#discussion_r29098680
--- Diff:
phoenix-core/src/test/java/org/apache/phoenix/parse/QueryParserTest.java ---
@@ -289,24 +289,6 @@ public void testNegativeCountStar() throws
Github user chrajeshbabu commented on the pull request:
https://github.com/apache/phoenix/pull/77#issuecomment-96145601
Thanks Samarth for reviews. Will update patch addressing the comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/77#discussion_r29098825
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/expression/function/UDFExpression.java
---
@@ -0,0 +1,217 @@
+/*
+ * Licensed to the
Github user chrajeshbabu commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/77#discussion_r29098678
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/expression/function/UDFExpression.java
---
@@ -0,0 +1,217 @@
+/*
+ * Licensed to the
Github user chrajeshbabu commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/77#discussion_r29098894
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/expression/function/UDFExpression.java
---
@@ -0,0 +1,217 @@
+/*
+ * Licensed to the
Github user chrajeshbabu commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/77#discussion_r29098632
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/compile/FromCompiler.java ---
@@ -383,6 +448,85 @@ protected TableRef
GitHub user chrajeshbabu opened a pull request:
https://github.com/apache/phoenix/pull/77
PHOENIX-538 Support UDFs
Patch to support UDFs. It mainly includes
- create temporary/permanent function query parsing
- storing function info
- dynamically loading udf jars.
-
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/77#discussion_r29098096
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/coprocessor/MetaDataEndpointImpl.java
---
@@ -700,6 +1007,29 @@ private PTable
Github user samarthjain commented on the pull request:
https://github.com/apache/phoenix/pull/77#issuecomment-96133889
Almost there Rajesh. Just some minor nits and questions, otherwise LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/77#discussion_r29098070
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/compile/FromCompiler.java ---
@@ -383,6 +448,85 @@ protected TableRef
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/77#discussion_r29098063
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/compile/CreateFunctionCompiler.java
---
@@ -0,0 +1,84 @@
+/*
+ * Licensed to the Apache
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/77#discussion_r29098050
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/cache/GlobalCache.java ---
@@ -157,4 +159,18 @@ public TenantCache
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/77#discussion_r29098203
--- Diff:
phoenix-core/src/test/java/org/apache/phoenix/parse/QueryParserTest.java ---
@@ -289,24 +289,6 @@ public void testNegativeCountStar() throws
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/77#discussion_r29098156
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/expression/function/UDFExpression.java
---
@@ -0,0 +1,217 @@
+/*
+ * Licensed to the
25 matches
Mail list logo
