[GitHub] phoenix pull request: PHOENIX-978: Allow views to extend parent's ...

2015-08-10 Thread elilevine
Github user elilevine commented on the pull request: https://github.com/apache/phoenix/pull/97#issuecomment-129690323 Closing this PR. This has been checked in by @twdsilva. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] phoenix pull request: PHOENIX-978: Allow views to extend parent's ...

2015-08-10 Thread elilevine
Github user elilevine closed the pull request at: https://github.com/apache/phoenix/pull/97 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is e

[GitHub] phoenix pull request: PHOENIX-978: Allow views to extend parent's ...

2015-07-08 Thread elilevine
Github user elilevine commented on a diff in the pull request: https://github.com/apache/phoenix/pull/97#discussion_r34219079 --- Diff: phoenix-core/src/it/java/org/apache/phoenix/end2end/AlterTableIT.java --- @@ -2179,7 +2176,7 @@ public void testAddExistingViewPkColumnToBaseTabl

[GitHub] phoenix pull request: PHOENIX-978: Allow views to extend parent's ...

2015-07-08 Thread elilevine
Github user elilevine commented on a diff in the pull request: https://github.com/apache/phoenix/pull/97#discussion_r34219051 --- Diff: phoenix-core/src/it/java/org/apache/phoenix/end2end/AlterTableIT.java --- @@ -2132,15 +2131,13 @@ public void testAddExistingViewColumnToBaseTabl

[GitHub] phoenix pull request: PHOENIX-978: Allow views to extend parent's ...

2015-07-08 Thread elilevine
GitHub user elilevine opened a pull request: https://github.com/apache/phoenix/pull/97 PHOENIX-978: Allow views to extend parent's PK only if parent's last … …PK column is fixed length You can merge this pull request into a Git repository by running: $ git pull https://gith

[GitHub] phoenix pull request: PHOENIX-978: allow views to extend parent's ...

2015-07-08 Thread elilevine
Github user elilevine closed the pull request at: https://github.com/apache/phoenix/pull/91 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is e

[GitHub] phoenix pull request: PHOENIX-978: allow views to extend parent's ...

2015-06-27 Thread elilevine
GitHub user elilevine opened a pull request: https://github.com/apache/phoenix/pull/91 PHOENIX-978: allow views to extend parent's PK https://issues.apache.org/jira/browse/PHOENIX-978 You can merge this pull request into a Git repository by running: $ git pull https://github.co