Github user twdsilva commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/75#discussion_r29026064
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/schema/types/PDataType.java ---
@@ -1144,17 +1144,18 @@ public static PDataType fromLiteral(Object va
Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/75#discussion_r29023368
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/schema/types/PJsonDataType.java
---
@@ -0,0 +1,258 @@
+package org.apache.phoenix.schema.typ
Github user AakashPradeep closed the pull request at:
https://github.com/apache/phoenix/pull/75
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/75#discussion_r29023183
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/schema/types/PDataType.java ---
@@ -1144,17 +1144,18 @@ public static PDataType fromLiteral(Objec
Github user AakashPradeep commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/75#discussion_r29023060
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/schema/types/PJsonDataType.java
---
@@ -0,0 +1,258 @@
+package org.apache.phoenix.schema.ty
Github user AakashPradeep commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/75#discussion_r29022695
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/schema/types/PDataType.java ---
@@ -1144,17 +1144,18 @@ public static PDataType fromLiteral(Obje
Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/75#discussion_r28982616
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/schema/types/PJsonDataType.java
---
@@ -0,0 +1,258 @@
+package org.apache.phoenix.schema.typ
Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/75#discussion_r28983079
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/schema/types/PJsonDataType.java
---
@@ -0,0 +1,258 @@
+package org.apache.phoenix.schema.typ
Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/75#discussion_r28982969
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/schema/types/PDataType.java ---
@@ -1144,17 +1144,18 @@ public static PDataType fromLiteral(Objec
Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/75#discussion_r28982807
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/schema/types/PJsonDataType.java
---
@@ -0,0 +1,258 @@
+package org.apache.phoenix.schema.typ
Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/75#discussion_r28982704
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/schema/types/PJsonDataType.java
---
@@ -0,0 +1,258 @@
+package org.apache.phoenix.schema.typ
Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/75#discussion_r28982531
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/schema/types/PJsonDataType.java
---
@@ -0,0 +1,258 @@
+package org.apache.phoenix.schema.typ
Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/75#discussion_r28982446
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/schema/types/PJsonDataType.java
---
@@ -0,0 +1,258 @@
+package org.apache.phoenix.schema.typ
Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/75#discussion_r28982359
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/schema/types/PJsonDataType.java
---
@@ -0,0 +1,258 @@
+package org.apache.phoenix.schema.typ
Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/75#discussion_r28982298
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/schema/types/PJsonDataType.java
---
@@ -0,0 +1,258 @@
+package org.apache.phoenix.schema.typ
Github user JamesRTaylor commented on the pull request:
https://github.com/apache/phoenix/pull/75#issuecomment-95652863
@AakashPradeep - this pull request is associated with the wrong JIRA, as it
seems to be adding comments to PHOENIX-174. Can you close this pull and open
two new ones
Github user AakashPradeep commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/75#discussion_r28941403
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/schema/types/PDataType.java ---
@@ -1144,17 +1144,18 @@ public static PDataType fromLiteral(Obje
Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/75#discussion_r28936075
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/schema/types/PDataType.java ---
@@ -1144,17 +1144,18 @@ public static PDataType fromLiteral(Objec
Github user AakashPradeep commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/75#discussion_r28935794
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/schema/json/PhoenixJson.java ---
@@ -0,0 +1,216 @@
+package org.apache.phoenix.schema.json;
Github user AakashPradeep commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/75#discussion_r28935769
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/schema/types/PVarchar.java ---
@@ -30,134 +31,145 @@
public class PVarchar extends PD
Github user AakashPradeep commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/75#discussion_r28935743
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/schema/types/PDataType.java ---
@@ -1144,17 +1144,18 @@ public static PDataType fromLiteral(Obje
Github user AakashPradeep commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/75#discussion_r28935112
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/expression/function/JsonExtractPathTextFunction.java
---
@@ -0,0 +1,108 @@
+package org.apa
Github user JamesRTaylor commented on the pull request:
https://github.com/apache/phoenix/pull/75#issuecomment-95414642
Very nice, @AakashPradeep! @twdsilva - would you mind reviewing too? Also,
looks like it needs to be rebased.
---
If your project is set up for it, you can reply to
Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/75#discussion_r28934607
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/schema/types/PVarchar.java ---
@@ -30,134 +31,145 @@
public class PVarchar extends PDa
Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/75#discussion_r28934572
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/schema/types/PJsonDataType.java
---
@@ -0,0 +1,258 @@
+package org.apache.phoenix.schema.typ
Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/75#discussion_r28934535
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/schema/types/PDataType.java ---
@@ -1144,17 +1144,18 @@ public static PDataType fromLiteral(Objec
Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/75#discussion_r28934521
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/schema/types/PDataType.java ---
@@ -1144,17 +1144,18 @@ public static PDataType fromLiteral(Objec
Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/75#discussion_r28934484
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/schema/json/PhoenixJson.java ---
@@ -0,0 +1,216 @@
+package org.apache.phoenix.schema.json;
Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/75#discussion_r28934392
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/schema/json/PhoenixJson.java ---
@@ -0,0 +1,216 @@
+package org.apache.phoenix.schema.json;
Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/75#discussion_r28934224
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/expression/function/JsonExtractPathTextFunction.java
---
@@ -0,0 +1,108 @@
+package org.apac
Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/75#discussion_r28934216
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/expression/function/JsonExtractPathTextFunction.java
---
@@ -0,0 +1,108 @@
+package org.apac
Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/75#discussion_r28934116
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/expression/function/JsonExtractPathFunction.java
---
@@ -0,0 +1,110 @@
+package org.apache.p
Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/75#discussion_r28934102
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/expression/function/JsonExtractPathFunction.java
---
@@ -0,0 +1,110 @@
+package org.apache.p
Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/75#discussion_r28933972
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/expression/function/JsonExtractPathFunction.java
---
@@ -0,0 +1,110 @@
+package org.apache.p
Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/75#discussion_r28933979
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/expression/function/JsonExtractPathFunction.java
---
@@ -0,0 +1,110 @@
+package org.apache.p
Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/75#discussion_r28933941
--- Diff:
phoenix-core/src/it/java/org/apache/phoenix/end2end/PhoenixJsonE2ETest.java ---
@@ -0,0 +1,246 @@
+/**
+ *
+ */
+package org.a
Github user AakashPradeep commented on the pull request:
https://github.com/apache/phoenix/pull/75#issuecomment-95399238
@JamesRTaylor Can you please review Phoenix Json.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. I
GitHub user AakashPradeep opened a pull request:
https://github.com/apache/phoenix/pull/75
Support native JSON data type and json_extract_path function PHOENIX-174...
...3 and PHOENIX-1710
You can merge this pull request into a Git repository by running:
$ git pull https://git
38 matches
Mail list logo
