[GitHub] phoenix pull request: merging latest avatica

Github user codymarcel commented on the pull request: https://github.com/apache/phoenix/pull/157#issuecomment-209524084 @gkanade Any updates on this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does no

[GitHub] phoenix pull request: merging latest avatica

Github user codymarcel commented on the pull request: https://github.com/apache/phoenix/pull/157#issuecomment-205858884 General Comments. 1. Please add some unit tests. Especially around the instanceResolver and RulesApplier. We user https://github.com/apache/phoenix/blob/mas

[GitHub] phoenix pull request: merging latest avatica

Github user codymarcel commented on a diff in the pull request: https://github.com/apache/phoenix/pull/157#discussion_r58557911 --- Diff: phoenix-pherf/src/main/java/org/apache/phoenix/pherf/workload/WriteWorkload.java --- @@ -253,13 +255,22 @@ private void waitForBatches(DataLoad

[GitHub] phoenix pull request: merging latest avatica

Github user JamesRTaylor commented on the pull request: https://github.com/apache/phoenix/pull/157#issuecomment-205851053 @gkanade - please file a JIRA and update you git commit message to include the JIRA (i.e. PHOENIX- Update Pherf to support ). --- If your project is set u

[GitHub] phoenix pull request: merging latest avatica

Github user codymarcel commented on a diff in the pull request: https://github.com/apache/phoenix/pull/157#discussion_r58555009 --- Diff: phoenix-pherf/src/main/java/org/apache/phoenix/pherf/configuration/QuerySet.java --- @@ -31,7 +31,24 @@ private long numberOfExecutions

[GitHub] phoenix pull request: merging latest avatica

Github user codymarcel commented on a diff in the pull request: https://github.com/apache/phoenix/pull/157#discussion_r58554617 --- Diff: phoenix-pherf/src/main/java/org/apache/phoenix/pherf/configuration/DataTypeMapping.java --- @@ -25,7 +25,8 @@ CHAR("CHAR", Types.CHAR)

[GitHub] phoenix pull request: merging latest avatica

Github user codymarcel commented on a diff in the pull request: https://github.com/apache/phoenix/pull/157#discussion_r58554472 --- Diff: phoenix-pherf/src/main/java/org/apache/phoenix/pherf/Pherf.java --- @@ -254,6 +254,7 @@ public void run() throws Exception { //

[GitHub] phoenix pull request: merging latest avatica

Github user codymarcel commented on the pull request: https://github.com/apache/phoenix/pull/157#issuecomment-205847652 Yea, I'll take a look. What is the associated Jira? On Mon, Apr 4, 2016 at 8:02 PM, James Taylor wrote: > @codymarcel

[GitHub] phoenix pull request: merging latest avatica

Github user JamesRTaylor commented on the pull request: https://github.com/apache/phoenix/pull/157#issuecomment-205598163 @codymarcel - would it be possible for you to review this pull as Mujtaba is on PTO? --- If your project is set up for it, you can reply to this email and have yo

[GitHub] phoenix pull request: merging latest avatica

GitHub user gkanade opened a pull request: https://github.com/apache/phoenix/pull/157 merging latest avatica You can merge this pull request into a Git repository by running: $ git pull https://github.com/gkanade/phoenix master Alternatively you can review and apply these cha