[GitHub] phoenix pull request #289: PHOENIX-4528 PhoenixAccessController checks permi...

2018-01-16 Thread twdsilva
Github user twdsilva commented on a diff in the pull request: https://github.com/apache/phoenix/pull/289#discussion_r161893623 --- Diff: phoenix-core/src/it/java/org/apache/phoenix/end2end/ChangePermissionsIT.java --- @@ -267,4 +267,26 @@ public void testMultiTenantTables() throws

[GitHub] phoenix pull request #289: PHOENIX-4528 PhoenixAccessController checks permi...

2018-01-15 Thread karanmehta93
Github user karanmehta93 commented on a diff in the pull request: https://github.com/apache/phoenix/pull/289#discussion_r161662712 --- Diff: phoenix-core/src/it/java/org/apache/phoenix/end2end/ChangePermissionsIT.java --- @@ -267,4 +267,26 @@ public void testMultiTenantTables()

[GitHub] phoenix pull request #289: PHOENIX-4528 PhoenixAccessController checks permi...

2018-01-15 Thread ankitsinghal
Github user ankitsinghal commented on a diff in the pull request: https://github.com/apache/phoenix/pull/289#discussion_r161661425 --- Diff: phoenix-core/src/it/java/org/apache/phoenix/end2end/ChangePermissionsIT.java --- @@ -267,4 +267,26 @@ public void testMultiTenantTables()

[GitHub] phoenix pull request #289: PHOENIX-4528 PhoenixAccessController checks permi...

2018-01-13 Thread karanmehta93
GitHub user karanmehta93 opened a pull request: https://github.com/apache/phoenix/pull/289 PHOENIX-4528 PhoenixAccessController checks permissions only at table… … level when creating views @ankitsinghal @twdsilva Please review. @ankitsinghal Please suggest new

[GitHub] phoenix pull request #288: PHOENIX-4523 phoenix.schema.isNamespaceMappingEna...

2018-01-13 Thread karanmehta93
Github user karanmehta93 closed the pull request at: https://github.com/apache/phoenix/pull/288 ---

[GitHub] phoenix pull request #288: PHOENIX-4523 phoenix.schema.isNamespaceMappingEna...

2018-01-13 Thread karanmehta93
Github user karanmehta93 commented on a diff in the pull request: https://github.com/apache/phoenix/pull/288#discussion_r161383259 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java --- @@ -2543,16 +2543,15 @@ public Void call() throws

[GitHub] phoenix pull request #288: PHOENIX-4523 phoenix.schema.isNamespaceMappingEna...

2018-01-11 Thread karanmehta93
Github user karanmehta93 commented on a diff in the pull request: https://github.com/apache/phoenix/pull/288#discussion_r161023714 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java --- @@ -2543,16 +2543,15 @@ public Void call() throws

[GitHub] phoenix pull request #288: PHOENIX-4523 phoenix.schema.isNamespaceMappingEna...

2018-01-11 Thread fpompermaier
Github user fpompermaier commented on a diff in the pull request: https://github.com/apache/phoenix/pull/288#discussion_r160888052 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java --- @@ -2543,16 +2543,15 @@ public Void call() throws

[GitHub] phoenix pull request #288: PHOENIX-4523 phoenix.schema.isNamespaceMappingEna...

2018-01-10 Thread karanmehta93
GitHub user karanmehta93 opened a pull request: https://github.com/apache/phoenix/pull/288 PHOENIX-4523 phoenix.schema.isNamespaceMappingEnabled problem (TableExistsException should be ignored when trying to create SYSTEM:MUTEX table) @JamesRTaylor FYI. You can merge

[GitHub] phoenix pull request #287: PHOENIX-4370 Surface hbase metrics from perconnec...

2017-12-21 Thread aertoria
GitHub user aertoria opened a pull request: https://github.com/apache/phoenix/pull/287 PHOENIX-4370 Surface hbase metrics from perconnection to global metrics PHOENIX-4370 Surface hbase metrics from perconnection to global metrics Opening this p.r. for the connivence of

[GitHub] phoenix pull request #262: PHOENIX 153 implement TABLESAMPLE clause

2017-12-21 Thread aertoria
Github user aertoria closed the pull request at: https://github.com/apache/phoenix/pull/262 ---

[GitHub] phoenix pull request #286: Sync 4.x-HBase-1.2 to master

2017-12-12 Thread pboado
GitHub user pboado opened a pull request: https://github.com/apache/phoenix/pull/286 Sync 4.x-HBase-1.2 to master This PR syncs 4.x-HBase-1.2 to master branch You can merge this pull request into a Git repository by running: $ git pull https://github.com/pboado/phoenix

[GitHub] phoenix pull request #285: Sync 4.x-HBase-1.2 to master

2017-12-12 Thread pboado
Github user pboado closed the pull request at: https://github.com/apache/phoenix/pull/285 ---

[GitHub] phoenix pull request #285: Sync 4.x-HBase-1.2 to master

2017-12-12 Thread pboado
GitHub user pboado opened a pull request: https://github.com/apache/phoenix/pull/285 Sync 4.x-HBase-1.2 to master This PR syncs 4.x-HBase-1.2 to master branch You can merge this pull request into a Git repository by running: $ git pull https://github.com/pboado/phoenix

[GitHub] phoenix pull request #283: PHOENIX-672 Add GRANT and REVOKE commands using H...

2017-12-05 Thread karanmehta93
Github user karanmehta93 closed the pull request at: https://github.com/apache/phoenix/pull/283 ---

[GitHub] phoenix pull request #284: PHOENIX-4424 Allow users to create DEFAULT and HB...

2017-12-04 Thread karanmehta93
Github user karanmehta93 commented on a diff in the pull request: https://github.com/apache/phoenix/pull/284#discussion_r154737748 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/schema/MetaDataClient.java --- @@ -4125,7 +4125,7 @@ public MutationState

[GitHub] phoenix pull request #279: PHOENIX-3757 System mutex table not being created...

2017-12-03 Thread karanmehta93
Github user karanmehta93 closed the pull request at: https://github.com/apache/phoenix/pull/279 ---

[GitHub] phoenix pull request #284: PHOENIX-4424 Allow users to create DEFAULT and HB...

2017-12-01 Thread karanmehta93
Github user karanmehta93 commented on a diff in the pull request: https://github.com/apache/phoenix/pull/284#discussion_r154406035 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/schema/MetaDataClient.java --- @@ -4125,7 +4125,7 @@ public MutationState

[GitHub] phoenix pull request #284: PHOENIX-4424 Allow users to create DEFAULT and HB...

2017-11-30 Thread ankitsinghal
Github user ankitsinghal commented on a diff in the pull request: https://github.com/apache/phoenix/pull/284#discussion_r154282569 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/schema/MetaDataClient.java --- @@ -4125,7 +4125,7 @@ public MutationState

[GitHub] phoenix pull request #284: PHOENIX-4424 Allow users to create DEFAULT and HB...

2017-11-30 Thread karanmehta93
Github user karanmehta93 commented on a diff in the pull request: https://github.com/apache/phoenix/pull/284#discussion_r154276336 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/schema/MetaDataClient.java --- @@ -4125,7 +4125,7 @@ public MutationState

[GitHub] phoenix pull request #284: PHOENIX-4424 Allow users to create DEFAULT and HB...

2017-11-30 Thread JamesRTaylor
Github user JamesRTaylor commented on a diff in the pull request: https://github.com/apache/phoenix/pull/284#discussion_r154276255 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/schema/MetaDataClient.java --- @@ -4125,7 +4125,7 @@ public MutationState

[GitHub] phoenix pull request #284: PHOENIX-4424 Allow users to create DEFAULT and HB...

2017-11-30 Thread karanmehta93
Github user karanmehta93 commented on a diff in the pull request: https://github.com/apache/phoenix/pull/284#discussion_r154276127 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/schema/MetaDataClient.java --- @@ -4125,7 +4125,7 @@ public MutationState

[GitHub] phoenix pull request #284: PHOENIX-4424 Allow users to create DEFAULT and HB...

2017-11-30 Thread karanmehta93
Github user karanmehta93 commented on a diff in the pull request: https://github.com/apache/phoenix/pull/284#discussion_r154275774 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/parse/CreateSchemaStatement.java --- @@ -24,7 +24,7 @@ private final boolean

[GitHub] phoenix pull request #284: PHOENIX-4424 Allow users to create DEFAULT and HB...

2017-11-30 Thread karanmehta93
GitHub user karanmehta93 opened a pull request: https://github.com/apache/phoenix/pull/284 PHOENIX-4424 Allow users to create DEFAULT and HBASE Schema (Uppercas… …e Schema Names) @twdsilva Please review. You can merge this pull request into a Git repository by running:

[GitHub] phoenix pull request #246: [PHOENIX-3734] Refactor Phoenix to use TAL instea...

2017-11-29 Thread ohadshacham
Github user ohadshacham closed the pull request at: https://github.com/apache/phoenix/pull/246 ---

[GitHub] phoenix pull request #283: PHOENIX-672 Add GRANT and REVOKE commands using H...

2017-11-28 Thread twdsilva
Github user twdsilva commented on a diff in the pull request: https://github.com/apache/phoenix/pull/283#discussion_r153685552 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/schema/MetaDataClient.java --- @@ -4168,4 +4176,124 @@ public MutationState

[GitHub] phoenix pull request #283: PHOENIX-672 Add GRANT and REVOKE commands using H...

2017-11-28 Thread karanmehta93
Github user karanmehta93 commented on a diff in the pull request: https://github.com/apache/phoenix/pull/283#discussion_r153605197 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/schema/MetaDataClient.java --- @@ -4168,4 +4176,197 @@ public MutationState

[GitHub] phoenix pull request #281: PHOENIX-4288 Indexes not used when ordering by pr...

2017-11-28 Thread JamesRTaylor
Github user JamesRTaylor commented on a diff in the pull request: https://github.com/apache/phoenix/pull/281#discussion_r153594426 --- Diff: phoenix-core/src/it/java/org/apache/phoenix/end2end/CostBasedDecisionIT.java --- @@ -0,0 +1,171 @@ +package org.apache.phoenix.end2end;

[GitHub] phoenix pull request #283: PHOENIX-672 Add GRANT and REVOKE commands using H...

2017-11-28 Thread JamesRTaylor
Github user JamesRTaylor commented on a diff in the pull request: https://github.com/apache/phoenix/pull/283#discussion_r153589434 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/schema/MetaDataClient.java --- @@ -4168,4 +4176,197 @@ public MutationState

[GitHub] phoenix pull request #283: PHOENIX-672 Add GRANT and REVOKE commands using H...

2017-11-28 Thread karanmehta93
Github user karanmehta93 commented on a diff in the pull request: https://github.com/apache/phoenix/pull/283#discussion_r153582948 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/schema/MetaDataClient.java --- @@ -4168,4 +4176,197 @@ public MutationState

[GitHub] phoenix pull request #283: PHOENIX-672 Add GRANT and REVOKE commands using H...

2017-11-28 Thread karanmehta93
Github user karanmehta93 commented on a diff in the pull request: https://github.com/apache/phoenix/pull/283#discussion_r153582196 --- Diff: phoenix-core/src/it/java/org/apache/phoenix/end2end/BasePermissionsIT.java --- @@ -0,0 +1,635 @@ +/* + * Licensed to the Apache

[GitHub] phoenix pull request #281: PHOENIX-4288 Indexes not used when ordering by pr...

2017-11-28 Thread JamesRTaylor
Github user JamesRTaylor commented on a diff in the pull request: https://github.com/apache/phoenix/pull/281#discussion_r153574645 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/optimize/QueryOptimizer.java --- @@ -91,8 +91,23 @@ public QueryPlan optimize(PhoenixStatement

[GitHub] phoenix pull request #281: PHOENIX-4288 Indexes not used when ordering by pr...

2017-11-27 Thread maryannxue
Github user maryannxue commented on a diff in the pull request: https://github.com/apache/phoenix/pull/281#discussion_r153404439 --- Diff: phoenix-core/src/it/java/org/apache/phoenix/end2end/CostBasedDecisionIT.java --- @@ -0,0 +1,176 @@ +package org.apache.phoenix.end2end;

[GitHub] phoenix pull request #281: PHOENIX-4288 Indexes not used when ordering by pr...

2017-11-27 Thread JamesRTaylor
Github user JamesRTaylor commented on a diff in the pull request: https://github.com/apache/phoenix/pull/281#discussion_r153378386 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/optimize/QueryOptimizer.java --- @@ -91,8 +91,23 @@ public QueryPlan optimize(PhoenixStatement

[GitHub] phoenix pull request #281: PHOENIX-4288 Indexes not used when ordering by pr...

2017-11-27 Thread JamesRTaylor
Github user JamesRTaylor commented on a diff in the pull request: https://github.com/apache/phoenix/pull/281#discussion_r153377074 --- Diff: phoenix-core/src/it/java/org/apache/phoenix/end2end/CostBasedDecisionIT.java --- @@ -0,0 +1,176 @@ +package org.apache.phoenix.end2end;

[GitHub] phoenix pull request #281: PHOENIX-4288 Indexes not used when ordering by pr...

2017-11-27 Thread JamesRTaylor
Github user JamesRTaylor commented on a diff in the pull request: https://github.com/apache/phoenix/pull/281#discussion_r153377003 --- Diff: phoenix-core/src/it/java/org/apache/phoenix/end2end/CostBasedDecisionIT.java --- @@ -0,0 +1,176 @@ +package org.apache.phoenix.end2end;

[GitHub] phoenix pull request #283: PHOENIX-672 Add GRANT and REVOKE commands using H...

2017-11-27 Thread karanmehta93
Github user karanmehta93 commented on a diff in the pull request: https://github.com/apache/phoenix/pull/283#discussion_r153283989 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/schema/MetaDataClient.java --- @@ -4168,4 +4176,197 @@ public MutationState

[GitHub] phoenix pull request #283: PHOENIX-672 Add GRANT and REVOKE commands using H...

2017-11-22 Thread twdsilva
Github user twdsilva commented on a diff in the pull request: https://github.com/apache/phoenix/pull/283#discussion_r152691915 --- Diff: phoenix-core/src/it/java/org/apache/phoenix/end2end/BasePermissionsIT.java --- @@ -0,0 +1,635 @@ +/* + * Licensed to the Apache Software

[GitHub] phoenix pull request #283: PHOENIX-672 Add GRANT and REVOKE commands using H...

2017-11-22 Thread karanmehta93
Github user karanmehta93 commented on a diff in the pull request: https://github.com/apache/phoenix/pull/283#discussion_r152685262 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/coprocessor/PhoenixAccessController.java --- @@ -229,17 +227,12 @@ public void

[GitHub] phoenix pull request #283: PHOENIX-672 Add GRANT and REVOKE commands using H...

2017-11-22 Thread karanmehta93
Github user karanmehta93 commented on a diff in the pull request: https://github.com/apache/phoenix/pull/283#discussion_r152663200 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/schema/MetaDataClient.java --- @@ -4168,4 +4176,197 @@ public MutationState

[GitHub] phoenix pull request #283: PHOENIX-672 Add GRANT and REVOKE commands using H...

2017-11-22 Thread karanmehta93
Github user karanmehta93 commented on a diff in the pull request: https://github.com/apache/phoenix/pull/283#discussion_r152662904 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/schema/MetaDataClient.java --- @@ -4168,4 +4176,197 @@ public MutationState

[GitHub] phoenix pull request #283: PHOENIX-672 Add GRANT and REVOKE commands using H...

2017-11-22 Thread ankitsinghal
Github user ankitsinghal commented on a diff in the pull request: https://github.com/apache/phoenix/pull/283#discussion_r152656117 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/coprocessor/PhoenixAccessController.java --- @@ -229,17 +227,12 @@ public void

[GitHub] phoenix pull request #283: PHOENIX-672 Add GRANT and REVOKE commands using H...

2017-11-22 Thread JamesRTaylor
Github user JamesRTaylor commented on a diff in the pull request: https://github.com/apache/phoenix/pull/283#discussion_r152650744 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/coprocessor/PhoenixAccessController.java --- @@ -229,17 +227,12 @@ public void

[GitHub] phoenix pull request #283: PHOENIX-672 Add GRANT and REVOKE commands using H...

2017-11-22 Thread karanmehta93
Github user karanmehta93 commented on a diff in the pull request: https://github.com/apache/phoenix/pull/283#discussion_r152649147 --- Diff: phoenix-core/src/test/java/org/apache/phoenix/parse/QueryParserTest.java --- @@ -66,6 +68,46 @@ private void parseQueryThatShouldFail(String

[GitHub] phoenix pull request #283: PHOENIX-672 Add GRANT and REVOKE commands using H...

2017-11-22 Thread ankitsinghal
Github user ankitsinghal commented on a diff in the pull request: https://github.com/apache/phoenix/pull/283#discussion_r152648189 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/coprocessor/PhoenixAccessController.java --- @@ -229,17 +227,12 @@ public void

[GitHub] phoenix pull request #283: PHOENIX-672 Add GRANT and REVOKE commands using H...

2017-11-22 Thread karanmehta93
Github user karanmehta93 commented on a diff in the pull request: https://github.com/apache/phoenix/pull/283#discussion_r152646903 --- Diff: phoenix-core/src/test/java/org/apache/phoenix/parse/QueryParserTest.java --- @@ -66,6 +68,46 @@ private void parseQueryThatShouldFail(String

[GitHub] phoenix pull request #283: PHOENIX-672 Add GRANT and REVOKE commands using H...

2017-11-22 Thread karanmehta93
Github user karanmehta93 commented on a diff in the pull request: https://github.com/apache/phoenix/pull/283#discussion_r152646448 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/schema/TablesNotInSyncException.java --- @@ -0,0 +1,16 @@ +package

[GitHub] phoenix pull request #283: PHOENIX-672 Add GRANT and REVOKE commands using H...

2017-11-22 Thread karanmehta93
Github user karanmehta93 commented on a diff in the pull request: https://github.com/apache/phoenix/pull/283#discussion_r152646351 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/schema/MetaDataClient.java --- @@ -4168,4 +4176,197 @@ public MutationState

[GitHub] phoenix pull request #283: PHOENIX-672 Add GRANT and REVOKE commands using H...

2017-11-22 Thread karanmehta93
Github user karanmehta93 commented on a diff in the pull request: https://github.com/apache/phoenix/pull/283#discussion_r152645916 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/schema/MetaDataClient.java --- @@ -4168,4 +4176,197 @@ public MutationState

[GitHub] phoenix pull request #283: PHOENIX-672 Add GRANT and REVOKE commands using H...

2017-11-22 Thread karanmehta93
Github user karanmehta93 commented on a diff in the pull request: https://github.com/apache/phoenix/pull/283#discussion_r152645385 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/schema/MetaDataClient.java --- @@ -4168,4 +4176,197 @@ public MutationState

[GitHub] phoenix pull request #283: PHOENIX-672 Add GRANT and REVOKE commands using H...

2017-11-22 Thread karanmehta93
Github user karanmehta93 commented on a diff in the pull request: https://github.com/apache/phoenix/pull/283#discussion_r152645002 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/schema/MetaDataClient.java --- @@ -4168,4 +4176,197 @@ public MutationState

[GitHub] phoenix pull request #283: PHOENIX-672 Add GRANT and REVOKE commands using H...

2017-11-22 Thread karanmehta93
Github user karanmehta93 commented on a diff in the pull request: https://github.com/apache/phoenix/pull/283#discussion_r152644332 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/schema/MetaDataClient.java --- @@ -4168,4 +4176,197 @@ public MutationState

[GitHub] phoenix pull request #283: PHOENIX-672 Add GRANT and REVOKE commands using H...

2017-11-22 Thread karanmehta93
Github user karanmehta93 commented on a diff in the pull request: https://github.com/apache/phoenix/pull/283#discussion_r152644103 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/schema/MetaDataClient.java --- @@ -4168,4 +4176,197 @@ public MutationState

[GitHub] phoenix pull request #283: PHOENIX-672 Add GRANT and REVOKE commands using H...

2017-11-22 Thread twdsilva
Github user twdsilva commented on a diff in the pull request: https://github.com/apache/phoenix/pull/283#discussion_r152644100 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/coprocessor/PhoenixAccessController.java --- @@ -229,17 +227,12 @@ public void

[GitHub] phoenix pull request #283: PHOENIX-672 Add GRANT and REVOKE commands using H...

2017-11-22 Thread karanmehta93
Github user karanmehta93 commented on a diff in the pull request: https://github.com/apache/phoenix/pull/283#discussion_r152643463 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/coprocessor/PhoenixAccessController.java --- @@ -229,17 +227,12 @@ public void

[GitHub] phoenix pull request #283: PHOENIX-672 Add GRANT and REVOKE commands using H...

2017-11-22 Thread karanmehta93
Github user karanmehta93 commented on a diff in the pull request: https://github.com/apache/phoenix/pull/283#discussion_r152642780 --- Diff: phoenix-core/src/it/java/org/apache/phoenix/end2end/TableDDLPermissionsIT.java --- @@ -210,25 +98,20 @@ public Void run() throws Exception

[GitHub] phoenix pull request #283: PHOENIX-672 Add GRANT and REVOKE commands using H...

2017-11-22 Thread karanmehta93
Github user karanmehta93 commented on a diff in the pull request: https://github.com/apache/phoenix/pull/283#discussion_r152642518 --- Diff: phoenix-core/src/it/java/org/apache/phoenix/end2end/BasePermissionsIT.java --- @@ -0,0 +1,635 @@ +/* + * Licensed to the Apache

[GitHub] phoenix pull request #283: PHOENIX-672 Add GRANT and REVOKE commands using H...

2017-11-21 Thread ankitsinghal
Github user ankitsinghal commented on a diff in the pull request: https://github.com/apache/phoenix/pull/283#discussion_r152483233 --- Diff: phoenix-core/src/it/java/org/apache/phoenix/end2end/TableDDLPermissionsIT.java --- @@ -210,25 +98,20 @@ public Void run() throws Exception

[GitHub] phoenix pull request #283: PHOENIX-672 Add GRANT and REVOKE commands using H...

2017-11-21 Thread ankitsinghal
Github user ankitsinghal commented on a diff in the pull request: https://github.com/apache/phoenix/pull/283#discussion_r152483142 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/schema/MetaDataClient.java --- @@ -4168,4 +4176,197 @@ public MutationState

[GitHub] phoenix pull request #283: PHOENIX-672 Add GRANT and REVOKE commands using H...

2017-11-21 Thread ankitsinghal
Github user ankitsinghal commented on a diff in the pull request: https://github.com/apache/phoenix/pull/283#discussion_r152481907 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/coprocessor/PhoenixAccessController.java --- @@ -229,17 +227,12 @@ public void

[GitHub] phoenix pull request #283: PHOENIX-672 Add GRANT and REVOKE commands using H...

2017-11-21 Thread ankitsinghal
Github user ankitsinghal commented on a diff in the pull request: https://github.com/apache/phoenix/pull/283#discussion_r152480973 --- Diff: phoenix-core/src/test/java/org/apache/phoenix/parse/QueryParserTest.java --- @@ -66,6 +68,46 @@ private void parseQueryThatShouldFail(String

[GitHub] phoenix pull request #283: PHOENIX-672 Add GRANT and REVOKE commands using H...

2017-11-21 Thread ankitsinghal
Github user ankitsinghal commented on a diff in the pull request: https://github.com/apache/phoenix/pull/283#discussion_r152480644 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/schema/TablesNotInSyncException.java --- @@ -0,0 +1,16 @@ +package

[GitHub] phoenix pull request #283: PHOENIX-672 Add GRANT and REVOKE commands using H...

2017-11-21 Thread ankitsinghal
Github user ankitsinghal commented on a diff in the pull request: https://github.com/apache/phoenix/pull/283#discussion_r152479671 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/schema/MetaDataClient.java --- @@ -4168,4 +4176,197 @@ public MutationState

[GitHub] phoenix pull request #283: PHOENIX-672 Add GRANT and REVOKE commands using H...

2017-11-21 Thread ankitsinghal
Github user ankitsinghal commented on a diff in the pull request: https://github.com/apache/phoenix/pull/283#discussion_r152478348 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/schema/MetaDataClient.java --- @@ -4168,4 +4176,197 @@ public MutationState

[GitHub] phoenix pull request #283: PHOENIX-672 Add GRANT and REVOKE commands using H...

2017-11-21 Thread ankitsinghal
Github user ankitsinghal commented on a diff in the pull request: https://github.com/apache/phoenix/pull/283#discussion_r152478050 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/schema/MetaDataClient.java --- @@ -4168,4 +4176,197 @@ public MutationState

[GitHub] phoenix pull request #283: PHOENIX-672 Add GRANT and REVOKE commands using H...

2017-11-21 Thread ankitsinghal
Github user ankitsinghal commented on a diff in the pull request: https://github.com/apache/phoenix/pull/283#discussion_r152477915 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/schema/MetaDataClient.java --- @@ -4168,4 +4176,197 @@ public MutationState

[GitHub] phoenix pull request #283: PHOENIX-672 Add GRANT and REVOKE commands using H...

2017-11-21 Thread ankitsinghal
Github user ankitsinghal commented on a diff in the pull request: https://github.com/apache/phoenix/pull/283#discussion_r152477760 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/schema/MetaDataClient.java --- @@ -4168,4 +4176,197 @@ public MutationState

[GitHub] phoenix pull request #283: PHOENIX-672 Add GRANT and REVOKE commands using H...

2017-11-21 Thread twdsilva
Github user twdsilva commented on a diff in the pull request: https://github.com/apache/phoenix/pull/283#discussion_r152460399 --- Diff: phoenix-core/src/it/java/org/apache/phoenix/end2end/BasePermissionsIT.java --- @@ -0,0 +1,635 @@ +/* + * Licensed to the Apache Software

[GitHub] phoenix pull request #283: PHOENIX-672 Add GRANT and REVOKE commands using H...

2017-11-21 Thread twdsilva
Github user twdsilva commented on a diff in the pull request: https://github.com/apache/phoenix/pull/283#discussion_r152459739 --- Diff: phoenix-core/src/test/java/org/apache/phoenix/parse/QueryParserTest.java --- @@ -66,6 +68,46 @@ private void parseQueryThatShouldFail(String

[GitHub] phoenix pull request #283: PHOENIX-672 Add GRANT and REVOKE commands using H...

2017-11-21 Thread twdsilva
Github user twdsilva commented on a diff in the pull request: https://github.com/apache/phoenix/pull/283#discussion_r152459035 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/schema/MetaDataClient.java --- @@ -4168,4 +4176,197 @@ public MutationState

[GitHub] phoenix pull request #283: PHOENIX-672 Add GRANT and REVOKE commands using H...

2017-11-21 Thread twdsilva
Github user twdsilva commented on a diff in the pull request: https://github.com/apache/phoenix/pull/283#discussion_r152457942 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/schema/MetaDataClient.java --- @@ -4168,4 +4176,197 @@ public MutationState

[GitHub] phoenix pull request #283: PHOENIX-672 Add GRANT and REVOKE commands using H...

2017-11-21 Thread twdsilva
Github user twdsilva commented on a diff in the pull request: https://github.com/apache/phoenix/pull/283#discussion_r152457669 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/schema/MetaDataClient.java --- @@ -4168,4 +4176,197 @@ public MutationState

[GitHub] phoenix pull request #283: PHOENIX-672 Add GRANT and REVOKE commands using H...

2017-11-21 Thread twdsilva
Github user twdsilva commented on a diff in the pull request: https://github.com/apache/phoenix/pull/283#discussion_r152457161 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/coprocessor/PhoenixAccessController.java --- @@ -229,17 +227,12 @@ public void

[GitHub] phoenix pull request #283: PHOENIX-672 Add GRANT and REVOKE commands using H...

2017-11-21 Thread karanmehta93
Github user karanmehta93 commented on a diff in the pull request: https://github.com/apache/phoenix/pull/283#discussion_r152445087 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/coprocessor/PhoenixAccessController.java --- @@ -229,17 +227,12 @@ public void

[GitHub] phoenix pull request #283: PHOENIX-672 Add GRANT and REVOKE commands using H...

2017-11-21 Thread twdsilva
Github user twdsilva commented on a diff in the pull request: https://github.com/apache/phoenix/pull/283#discussion_r152442952 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/coprocessor/PhoenixAccessController.java --- @@ -229,17 +227,12 @@ public void

[GitHub] phoenix pull request #281: PHOENIX-4288 Indexes not used when ordering by pr...

2017-11-17 Thread maryannxue
Github user maryannxue commented on a diff in the pull request: https://github.com/apache/phoenix/pull/281#discussion_r151829519 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/optimize/QueryOptimizer.java --- @@ -91,8 +91,23 @@ public QueryPlan optimize(PhoenixStatement

[GitHub] phoenix pull request #281: PHOENIX-4288 Indexes not used when ordering by pr...

2017-11-17 Thread JamesRTaylor
Github user JamesRTaylor commented on a diff in the pull request: https://github.com/apache/phoenix/pull/281#discussion_r151623809 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/optimize/QueryOptimizer.java --- @@ -91,8 +91,23 @@ public QueryPlan optimize(PhoenixStatement

[GitHub] phoenix pull request #281: PHOENIX-4288 Indexes not used when ordering by pr...

2017-11-16 Thread katameru
Github user katameru commented on a diff in the pull request: https://github.com/apache/phoenix/pull/281#discussion_r151620890 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/optimize/QueryOptimizer.java --- @@ -91,8 +91,23 @@ public QueryPlan optimize(PhoenixStatement

[GitHub] phoenix pull request #277: PHOENIX-3757 System mutex table not being created...

2017-11-16 Thread karanmehta93
Github user karanmehta93 closed the pull request at: https://github.com/apache/phoenix/pull/277 ---

[GitHub] phoenix pull request #283: PHOENIX-672 Add GRANT and REVOKE commands using H...

2017-11-16 Thread karanmehta93
GitHub user karanmehta93 opened a pull request: https://github.com/apache/phoenix/pull/283 PHOENIX-672 Add GRANT and REVOKE commands using HBase AccessController Initial patch Added support for Grant Revoke SQL statements for HBase ACL Permissions Refactored the tests,

[GitHub] phoenix pull request #281: PHOENIX-4288 Indexes not used when ordering by pr...

2017-11-16 Thread maryannxue
Github user maryannxue commented on a diff in the pull request: https://github.com/apache/phoenix/pull/281#discussion_r151580119 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/optimize/QueryOptimizer.java --- @@ -91,8 +91,23 @@ public QueryPlan optimize(PhoenixStatement

[GitHub] phoenix pull request #282: PHOENIX-4361: Remove redundant argument in separa...

2017-11-16 Thread aertoria
Github user aertoria commented on a diff in the pull request: https://github.com/apache/phoenix/pull/282#discussion_r151541162 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java --- @@ -1940,7 +1940,8 @@ private void

[GitHub] phoenix pull request #281: PHOENIX-4288 Indexes not used when ordering by pr...

2017-11-16 Thread katameru
Github user katameru commented on a diff in the pull request: https://github.com/apache/phoenix/pull/281#discussion_r151421537 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/optimize/QueryOptimizer.java --- @@ -91,8 +91,23 @@ public QueryPlan optimize(PhoenixStatement

[GitHub] phoenix pull request #282: PHOENIX-4361: Remove redundant argument in separa...

2017-11-15 Thread ChinmaySKulkarni
GitHub user ChinmaySKulkarni opened a pull request: https://github.com/apache/phoenix/pull/282 PHOENIX-4361: Remove redundant argument in separateAndValidateProperties in CQSI You can merge this pull request into a Git repository by running: $ git pull

[GitHub] phoenix pull request #281: PHOENIX-4288 Indexes not used when ordering by pr...

2017-11-14 Thread JamesRTaylor
Github user JamesRTaylor commented on a diff in the pull request: https://github.com/apache/phoenix/pull/281#discussion_r151013728 --- Diff: phoenix-core/src/it/java/org/apache/phoenix/end2end/CostBasedDecisionIT.java --- @@ -0,0 +1,50 @@ +package org.apache.phoenix.end2end;

[GitHub] phoenix pull request #281: PHOENIX-4288 Indexes not used when ordering by pr...

2017-11-14 Thread JamesRTaylor
Github user JamesRTaylor commented on a diff in the pull request: https://github.com/apache/phoenix/pull/281#discussion_r151015089 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/execute/AggregatePlan.java --- @@ -112,7 +114,26 @@ private AggregatePlan(StatementContext

[GitHub] phoenix pull request #281: PHOENIX-4288 Indexes not used when ordering by pr...

2017-11-14 Thread JamesRTaylor
Github user JamesRTaylor commented on a diff in the pull request: https://github.com/apache/phoenix/pull/281#discussion_r151014919 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/execute/AggregatePlan.java --- @@ -112,7 +114,26 @@ private AggregatePlan(StatementContext

[GitHub] phoenix pull request #281: PHOENIX-4288 Indexes not used when ordering by pr...

2017-11-14 Thread JamesRTaylor
Github user JamesRTaylor commented on a diff in the pull request: https://github.com/apache/phoenix/pull/281#discussion_r151016226 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/execute/AggregatePlan.java --- @@ -112,7 +114,26 @@ private AggregatePlan(StatementContext

[GitHub] phoenix pull request #281: PHOENIX-4288 Indexes not used when ordering by pr...

2017-11-14 Thread JamesRTaylor
Github user JamesRTaylor commented on a diff in the pull request: https://github.com/apache/phoenix/pull/281#discussion_r151015944 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/optimize/QueryOptimizer.java --- @@ -91,8 +91,23 @@ public QueryPlan optimize(PhoenixStatement

[GitHub] phoenix pull request #281: PHOENIX-4288 Indexes not used when ordering by pr...

2017-11-14 Thread JamesRTaylor
Github user JamesRTaylor commented on a diff in the pull request: https://github.com/apache/phoenix/pull/281#discussion_r151015329 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/execute/ClientAggregatePlan.java --- @@ -87,6 +89,25 @@ public

[GitHub] phoenix pull request #281: PHOENIX-4288 Indexes not used when ordering by pr...

2017-11-14 Thread JamesRTaylor
Github user JamesRTaylor commented on a diff in the pull request: https://github.com/apache/phoenix/pull/281#discussion_r151012514 --- Diff: phoenix-core/src/it/java/org/apache/phoenix/end2end/CostBasedDecisionIT.java --- @@ -0,0 +1,50 @@ +package org.apache.phoenix.end2end;

[GitHub] phoenix pull request #281: PHOENIX-4288 Indexes not used when ordering by pr...

2017-11-14 Thread JamesRTaylor
Github user JamesRTaylor commented on a diff in the pull request: https://github.com/apache/phoenix/pull/281#discussion_r151014126 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/execute/HashJoinPlan.java --- @@ -290,6 +291,25 @@ public FilterableStatement getStatement() {

[GitHub] phoenix pull request #281: PHOENIX-4288 Indexes not used when ordering by pr...

2017-11-14 Thread JamesRTaylor
Github user JamesRTaylor commented on a diff in the pull request: https://github.com/apache/phoenix/pull/281#discussion_r151012292 --- Diff: phoenix-core/src/it/java/org/apache/phoenix/end2end/CostBasedDecisionIT.java --- @@ -0,0 +1,50 @@ +package org.apache.phoenix.end2end;

[GitHub] phoenix pull request #281: PHOENIX-4288 Indexes not used when ordering by pr...

2017-11-14 Thread JamesRTaylor
Github user JamesRTaylor commented on a diff in the pull request: https://github.com/apache/phoenix/pull/281#discussion_r151014001 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/execute/BaseQueryPlan.java --- @@ -500,7 +500,10 @@ public ExplainPlan getExplainPlan() throws

[GitHub] phoenix pull request #281: PHOENIX-4288 Indexes not used when ordering by pr...

2017-11-07 Thread maryannxue
GitHub user maryannxue opened a pull request: https://github.com/apache/phoenix/pull/281 PHOENIX-4288 Indexes not used when ordering by primary key 1. Add class Cost. 2. Add method getCost() in QueryPlan. 3. Let QueryOptimizer choose the best plan based on Cost; meanwhile if

[GitHub] phoenix pull request #280: indextool inedxTable is not an index table for da...

2017-11-02 Thread xsq0718
GitHub user xsq0718 opened a pull request: https://github.com/apache/phoenix/pull/280 indextool inedxTable is not an index table for dataTable Phoenix;phoenix-4.8.0-cdh5.8.0 Hbase;1.2.0 Create phoenixTable ; CREATE Table "everAp"(pk VARCHAR PRIMARY KEY,"ba"."ap"

[GitHub] phoenix pull request #279: PHOENIX-3757 System mutex table not being created...

2017-10-27 Thread karanmehta93
GitHub user karanmehta93 opened a pull request: https://github.com/apache/phoenix/pull/279 PHOENIX-3757 System mutex table not being created in SYSTEM namespace… … when namespace mapping is enabled Backport of https://github.com/apache/phoenix/pull/277 PR @twdsilva

[GitHub] phoenix pull request #278: PHOENIX-4322 DESC primary key column with variabl...

2017-10-25 Thread maryannxue
GitHub user maryannxue opened a pull request: https://github.com/apache/phoenix/pull/278 PHOENIX-4322 DESC primary key column with variable length does not work in SkipScanFilter Changes: Avoid adding an extra trailing separator to the key You can merge this pull request into

[GitHub] phoenix pull request #277: PHOENIX-3757 System mutex table not being created...

2017-10-25 Thread twdsilva
Github user twdsilva commented on a diff in the pull request: https://github.com/apache/phoenix/pull/277#discussion_r146998114 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java --- @@ -2526,8 +2541,14 @@ private void

[GitHub] phoenix pull request #277: PHOENIX-3757 System mutex table not being created...

2017-10-25 Thread aertoria
Github user aertoria commented on a diff in the pull request: https://github.com/apache/phoenix/pull/277#discussion_r146990595 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java --- @@ -2526,8 +2541,14 @@ private void

<    1   2   3   4   5   6   7   8   9   10   >