[GitHub] phoenix pull request #186: cleanup sqlline*.py using python idioms.

2016-08-13 Thread btbytes
Github user btbytes commented on a diff in the pull request: https://github.com/apache/phoenix/pull/186#discussion_r74688048 --- Diff: bin/sqlline.py --- @@ -1,4 +1,5 @@ #!/usr/bin/env python +"""sqlline.py""" --- End diff -- This was to quieten PEP8 from

[GitHub] phoenix pull request #186: cleanup sqlline*.py using python idioms.

2016-08-12 Thread joshelser
Github user joshelser commented on a diff in the pull request: https://github.com/apache/phoenix/pull/186#discussion_r74614217 --- Diff: bin/sqlline.py --- @@ -1,4 +1,5 @@ #!/usr/bin/env python +"""sqlline.py""" --- End diff -- Is this a convention I don't