[GitHub] phoenix pull request #192: Phoenix Cursors implementation

2016-08-18 Thread anirudha
GitHub user anirudha opened a pull request: https://github.com/apache/phoenix/pull/192 Phoenix Cursors implementation //todo You can merge this pull request into a Git repository by running: $ git pull https://github.com/bloomberg/phoenix cursors_snapshot Alternatively you can

[GitHub] phoenix pull request #192: Phoenix Cursors implementation

2016-09-06 Thread ankitsinghal
Github user ankitsinghal commented on a diff in the pull request: https://github.com/apache/phoenix/pull/192#discussion_r77612036 --- Diff: phoenix-core/src/main/antlr3/PhoenixSQL.g --- @@ -726,8 +727,11 @@ upsert_column_refs returns [Pair,List> ret] // Parse a full decl

[GitHub] phoenix pull request #192: Phoenix Cursors implementation

2016-09-06 Thread ankitsinghal
Github user ankitsinghal commented on a diff in the pull request: https://github.com/apache/phoenix/pull/192#discussion_r77612514 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/util/CursorUtil.java --- @@ -62,24 +64,44 @@ private boolean selectHasPKCol = false

[GitHub] phoenix pull request #192: Phoenix Cursors implementation

2016-09-06 Thread ankitsinghal
Github user ankitsinghal commented on a diff in the pull request: https://github.com/apache/phoenix/pull/192#discussion_r77613518 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/util/CursorUtil.java --- @@ -247,11 +269,11 @@ private void updateSelectValues(Tuple currentRow)

[GitHub] phoenix pull request #192: Phoenix Cursors implementation

2017-04-27 Thread anirudha
Github user anirudha closed the pull request at: https://github.com/apache/phoenix/pull/192 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is e