Github user lomoree closed the pull request at:
https://github.com/apache/phoenix/pull/224
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user maryannxue commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/224#discussion_r91163250
--- Diff:
phoenix-core/src/it/java/org/apache/phoenix/calcite/CalciteIT.java ---
@@ -1343,6 +1343,28 @@ public void initTable() throws Exception {
Github user lomoree commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/224#discussion_r91162501
--- Diff:
phoenix-core/src/it/java/org/apache/phoenix/calcite/CalciteIT.java ---
@@ -1343,6 +1343,28 @@ public void initTable() throws Exception {
Github user maryannxue commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/224#discussion_r91152331
--- Diff:
phoenix-core/src/it/java/org/apache/phoenix/calcite/CalciteIT.java ---
@@ -1343,6 +1343,28 @@ public void initTable() throws Exception {
Github user maryannxue commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/224#discussion_r91155610
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/calcite/rel/PhoenixClientProject.java
---
@@ -73,13 +70,10 @@ public QueryPlan
Github user maryannxue commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/224#discussion_r91152478
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/calcite/CalciteUtils.java ---
@@ -1115,6 +1099,11 @@ public Void visitCall(RexCall call) {
GitHub user lomoree opened a pull request:
https://github.com/apache/phoenix/pull/224
PHOENIX-3477 Support sequence arithmetic in Calcite-Phoenix
PhoenixConverterRules is meant to route any logical project through
PhoenixClientProject. Before, sequences were not properly being
