[GitHub] phoenix pull request #232: Pull request for merging the encode columns branc...

2017-03-15 Thread samarthjain
Github user samarthjain closed the pull request at: https://github.com/apache/phoenix/pull/232 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature i

[GitHub] phoenix pull request #232: Pull request for merging the encode columns branc...

2017-02-23 Thread JamesRTaylor
Github user JamesRTaylor commented on a diff in the pull request: https://github.com/apache/phoenix/pull/232#discussion_r102852972 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/compile/FromCompiler.java --- @@ -858,7 +868,7 @@ public ColumnRef resolveColumn(String schemaN

[GitHub] phoenix pull request #232: Pull request for merging the encode columns branc...

2017-02-23 Thread JamesRTaylor
Github user JamesRTaylor commented on a diff in the pull request: https://github.com/apache/phoenix/pull/232#discussion_r102846635 --- Diff: phoenix-core/src/it/java/org/apache/phoenix/end2end/PhoenixRuntimeIT.java --- @@ -61,11 +61,11 @@ private static void assertTenantIds(Express

[GitHub] phoenix pull request #232: Pull request for merging the encode columns branc...

2017-02-23 Thread JamesRTaylor
Github user JamesRTaylor commented on a diff in the pull request: https://github.com/apache/phoenix/pull/232#discussion_r102846784 --- Diff: phoenix-core/src/it/java/org/apache/phoenix/end2end/PointInTimeQueryIT.java --- @@ -57,61 +52,6 @@ public static void doSetup() throws Except

[GitHub] phoenix pull request #232: Pull request for merging the encode columns branc...

2017-02-23 Thread JamesRTaylor
Github user JamesRTaylor commented on a diff in the pull request: https://github.com/apache/phoenix/pull/232#discussion_r102850416 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/index/IndexMaintainer.java --- @@ -291,39 +324,59 @@ public static void serializeAdditional(PTa

[GitHub] phoenix pull request #232: Pull request for merging the encode columns branc...

2017-02-23 Thread JamesRTaylor
Github user JamesRTaylor commented on a diff in the pull request: https://github.com/apache/phoenix/pull/232#discussion_r102846115 --- Diff: phoenix-core/src/it/java/org/apache/phoenix/end2end/CaseStatementIT.java --- @@ -177,41 +177,8 @@ public void testUnfoundMultiColumnCaseState

[GitHub] phoenix pull request #232: Pull request for merging the encode columns branc...

2017-02-23 Thread JamesRTaylor
Github user JamesRTaylor commented on a diff in the pull request: https://github.com/apache/phoenix/pull/232#discussion_r102850787 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/index/IndexMaintainer.java --- @@ -291,39 +324,59 @@ public static void serializeAdditional(PTa

[GitHub] phoenix pull request #232: Pull request for merging the encode columns branc...

2017-02-23 Thread JamesRTaylor
Github user JamesRTaylor commented on a diff in the pull request: https://github.com/apache/phoenix/pull/232#discussion_r102846897 --- Diff: phoenix-core/src/it/java/org/apache/phoenix/end2end/QueryIT.java --- @@ -124,13 +124,8 @@ public void testIntFilter() throws Exception {

[GitHub] phoenix pull request #232: Pull request for merging the encode columns branc...

2017-02-23 Thread JamesRTaylor
Github user JamesRTaylor commented on a diff in the pull request: https://github.com/apache/phoenix/pull/232#discussion_r102846464 --- Diff: phoenix-core/src/it/java/org/apache/phoenix/end2end/ParallelClientManagedTimeIT.java --- @@ -0,0 +1,39 @@ +/* + * Licensed to the Ap

[GitHub] phoenix pull request #232: Pull request for merging the encode columns branc...

2017-02-23 Thread JamesRTaylor
Github user JamesRTaylor commented on a diff in the pull request: https://github.com/apache/phoenix/pull/232#discussion_r102849484 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/coprocessor/BaseScannerRegionObserver.java --- @@ -528,21 +552,6 @@ private int replaceArrayIn

[GitHub] phoenix pull request #232: Pull request for merging the encode columns branc...

2017-02-23 Thread JamesRTaylor
Github user JamesRTaylor commented on a diff in the pull request: https://github.com/apache/phoenix/pull/232#discussion_r102848050 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/compile/FromCompiler.java --- @@ -858,7 +868,7 @@ public ColumnRef resolveColumn(String schemaN

[GitHub] phoenix pull request #232: Pull request for merging the encode columns branc...

2017-02-23 Thread JamesRTaylor
Github user JamesRTaylor commented on a diff in the pull request: https://github.com/apache/phoenix/pull/232#discussion_r102848383 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/compile/QueryCompiler.java --- @@ -94,7 +94,7 @@ */ private static final Str

[GitHub] phoenix pull request #232: Pull request for merging the encode columns branc...

2017-02-23 Thread JamesRTaylor
Github user JamesRTaylor commented on a diff in the pull request: https://github.com/apache/phoenix/pull/232#discussion_r102851976 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/schema/PTableImpl.java --- @@ -106,7 +115,8 @@ private List families; private

[GitHub] phoenix pull request #232: Pull request for merging the encode columns branc...

2017-02-23 Thread JamesRTaylor
Github user JamesRTaylor commented on a diff in the pull request: https://github.com/apache/phoenix/pull/232#discussion_r102851725 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/query/QueryServicesOptions.java --- @@ -263,6 +264,8 @@ public static final String DE

[GitHub] phoenix pull request #232: Pull request for merging the encode columns branc...

2017-02-23 Thread samarthjain
Github user samarthjain commented on a diff in the pull request: https://github.com/apache/phoenix/pull/232#discussion_r102769336 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/schema/tuple/PositionBasedMultiKeyValueTuple.java --- @@ -0,0 +1,86 @@ +/* + * Licensed

[GitHub] phoenix pull request #232: Pull request for merging the encode columns branc...

2017-02-14 Thread samarthjain
GitHub user samarthjain opened a pull request: https://github.com/apache/phoenix/pull/232 Pull request for merging the encode columns branch to 4.x-HBase-0.98 You can merge this pull request into a Git repository by running: $ git pull https://github.com/apache/phoenix encodec