[GitHub] phoenix pull request #268: PHOENIX-4010 Hash Join cache may not be send to a...

2017-09-07 Thread JamesRTaylor
Github user JamesRTaylor commented on a diff in the pull request: https://github.com/apache/phoenix/pull/268#discussion_r137629055 --- Diff: phoenix-core/src/it/java/org/apache/phoenix/end2end/BaseJoinIT.java --- @@ -30,14 +30,19 @@ import java.util.Map; import java.util.

[GitHub] phoenix pull request #268: PHOENIX-4010 Hash Join cache may not be send to a...

2017-09-07 Thread JamesRTaylor
Github user JamesRTaylor commented on a diff in the pull request: https://github.com/apache/phoenix/pull/268#discussion_r137628509 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/coprocessor/BaseScannerRegionObserver.java --- @@ -109,12 +110,16 @@ /** Expose

[GitHub] phoenix pull request #268: PHOENIX-4010 Hash Join cache may not be send to a...

2017-07-26 Thread JamesRTaylor
Github user JamesRTaylor commented on a diff in the pull request: https://github.com/apache/phoenix/pull/268#discussion_r129601553 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/compile/UpsertCompiler.java --- @@ -804,6 +804,7 @@ public Long getEstimatedBytesToScan() throw

[GitHub] phoenix pull request #268: PHOENIX-4010 Hash Join cache may not be send to a...

2017-07-26 Thread ankitsinghal
Github user ankitsinghal commented on a diff in the pull request: https://github.com/apache/phoenix/pull/268#discussion_r129589111 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/compile/UpsertCompiler.java --- @@ -804,6 +804,7 @@ public Long getEstimatedBytesToScan() throw

[GitHub] phoenix pull request #268: PHOENIX-4010 Hash Join cache may not be send to a...

2017-07-24 Thread JamesRTaylor
Github user JamesRTaylor commented on a diff in the pull request: https://github.com/apache/phoenix/pull/268#discussion_r129188027 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/iterate/TableResultIterator.java --- @@ -108,6 +126,10 @@ public TableResultIterator(MutationS

[GitHub] phoenix pull request #268: PHOENIX-4010 Hash Join cache may not be send to a...

2017-07-24 Thread JamesRTaylor
Github user JamesRTaylor commented on a diff in the pull request: https://github.com/apache/phoenix/pull/268#discussion_r129187485 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/compile/UpsertCompiler.java --- @@ -804,6 +804,7 @@ public Long getEstimatedBytesToScan() throw

[GitHub] phoenix pull request #268: PHOENIX-4010 Hash Join cache may not be send to a...

2017-07-24 Thread JamesRTaylor
Github user JamesRTaylor commented on a diff in the pull request: https://github.com/apache/phoenix/pull/268#discussion_r129187099 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/cache/ServerCacheClient.java --- @@ -303,73 +318,84 @@ public TaskExecutionMetricsHolder getTa

[GitHub] phoenix pull request #268: PHOENIX-4010 Hash Join cache may not be send to a...

2017-07-24 Thread JamesRTaylor
Github user JamesRTaylor commented on a diff in the pull request: https://github.com/apache/phoenix/pull/268#discussion_r129186906 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/cache/ServerCacheClient.java --- @@ -303,73 +318,84 @@ public TaskExecutionMetricsHolder getTa

[GitHub] phoenix pull request #268: PHOENIX-4010 Hash Join cache may not be send to a...

2017-07-24 Thread JamesRTaylor
Github user JamesRTaylor commented on a diff in the pull request: https://github.com/apache/phoenix/pull/268#discussion_r129185736 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/iterate/TableResultIterator.java --- @@ -163,8 +185,38 @@ public Tuple next() throws SQLExcept

[GitHub] phoenix pull request #268: PHOENIX-4010 Hash Join cache may not be send to a...

2017-07-24 Thread JamesRTaylor
Github user JamesRTaylor commented on a diff in the pull request: https://github.com/apache/phoenix/pull/268#discussion_r129185421 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/cache/ServerCacheClient.java --- @@ -394,4 +420,82 @@ public static String idToString(byte[] uu

[GitHub] phoenix pull request #268: PHOENIX-4010 Hash Join cache may not be send to a...

2017-07-24 Thread JamesRTaylor
Github user JamesRTaylor commented on a diff in the pull request: https://github.com/apache/phoenix/pull/268#discussion_r129152257 --- Diff: phoenix-core/src/it/java/org/apache/phoenix/end2end/HashJoinIT.java --- @@ -3453,4 +3496,27 @@ public void testJoinWithSetMaxRows() throws E

[GitHub] phoenix pull request #268: PHOENIX-4010 Hash Join cache may not be send to a...

2017-07-21 Thread ankitsinghal
GitHub user ankitsinghal opened a pull request: https://github.com/apache/phoenix/pull/268 PHOENIX-4010 Hash Join cache may not be send to all regionservers whe… …n we have stale HBase meta cache You can merge this pull request into a Git repository by running: $ git pull h