[GitHub] phoenix pull request #291: [PHOENIX-4278] Implement pure client side transac...

2018-02-12 Thread ohadshacham
Github user ohadshacham commented on a diff in the pull request: https://github.com/apache/phoenix/pull/291#discussion_r167501024 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java --- @@ -850,19 +849,12 @@ private void addCoprocessors(b

[GitHub] phoenix pull request #291: [PHOENIX-4278] Implement pure client side transac...

2018-02-08 Thread JamesRTaylor
Github user JamesRTaylor commented on a diff in the pull request: https://github.com/apache/phoenix/pull/291#discussion_r166987506 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/execute/PhoenixTxnIndexMutationGenerator.java --- @@ -0,0 +1,505 @@ +/* + * Licensed t

[GitHub] phoenix pull request #291: [PHOENIX-4278] Implement pure client side transac...

2018-02-08 Thread JamesRTaylor
Github user JamesRTaylor commented on a diff in the pull request: https://github.com/apache/phoenix/pull/291#discussion_r166986822 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/schema/PTableImpl.java --- @@ -1038,32 +1038,21 @@ public void setValue(PColumn column, byte[]

[GitHub] phoenix pull request #291: [PHOENIX-4278] Implement pure client side transac...

2018-02-08 Thread JamesRTaylor
Github user JamesRTaylor commented on a diff in the pull request: https://github.com/apache/phoenix/pull/291#discussion_r166985377 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java --- @@ -850,19 +849,12 @@ private void addCoprocessors(

[GitHub] phoenix pull request #291: [PHOENIX-4278] Implement pure client side transac...

2018-02-08 Thread ohadshacham
Github user ohadshacham commented on a diff in the pull request: https://github.com/apache/phoenix/pull/291#discussion_r166908718 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/execute/PhoenixTxnIndexMutationGenerator.java --- @@ -0,0 +1,505 @@ +/* + * Licensed to

[GitHub] phoenix pull request #291: [PHOENIX-4278] Implement pure client side transac...

2018-02-08 Thread ohadshacham
Github user ohadshacham commented on a diff in the pull request: https://github.com/apache/phoenix/pull/291#discussion_r166876845 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/execute/PhoenixTxnIndexMutationGenerator.java --- @@ -0,0 +1,505 @@ +/* + * Licensed to

[GitHub] phoenix pull request #291: [PHOENIX-4278] Implement pure client side transac...

2018-02-08 Thread ohadshacham
Github user ohadshacham commented on a diff in the pull request: https://github.com/apache/phoenix/pull/291#discussion_r166875958 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java --- @@ -850,19 +849,12 @@ private void addCoprocessors(b

[GitHub] phoenix pull request #291: [PHOENIX-4278] Implement pure client side transac...

2018-02-08 Thread ohadshacham
Github user ohadshacham commented on a diff in the pull request: https://github.com/apache/phoenix/pull/291#discussion_r166868712 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/schema/PTableImpl.java --- @@ -1038,32 +1038,21 @@ public void setValue(PColumn column, byte[]

[GitHub] phoenix pull request #291: [PHOENIX-4278] Implement pure client side transac...

2018-02-07 Thread JamesRTaylor
Github user JamesRTaylor commented on a diff in the pull request: https://github.com/apache/phoenix/pull/291#discussion_r166816653 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/execute/PhoenixTxnIndexMutationGenerator.java --- @@ -0,0 +1,505 @@ +/* + * Licensed t

[GitHub] phoenix pull request #291: [PHOENIX-4278] Implement pure client side transac...

2018-02-07 Thread JamesRTaylor
Github user JamesRTaylor commented on a diff in the pull request: https://github.com/apache/phoenix/pull/291#discussion_r166816466 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/execute/PhoenixTxnIndexMutationGenerator.java --- @@ -0,0 +1,505 @@ +/* + * Licensed t

[GitHub] phoenix pull request #291: [PHOENIX-4278] Implement pure client side transac...

2018-02-07 Thread JamesRTaylor
Github user JamesRTaylor commented on a diff in the pull request: https://github.com/apache/phoenix/pull/291#discussion_r166809191 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/schema/PTableImpl.java --- @@ -1038,32 +1038,21 @@ public void setValue(PColumn column, byte[]

[GitHub] phoenix pull request #291: [PHOENIX-4278] Implement pure client side transac...

2018-02-07 Thread JamesRTaylor
Github user JamesRTaylor commented on a diff in the pull request: https://github.com/apache/phoenix/pull/291#discussion_r166808341 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java --- @@ -850,19 +849,12 @@ private void addCoprocessors(

[GitHub] phoenix pull request #291: [PHOENIX-4278] Implement pure client side transac...

2018-01-29 Thread ohadshacham
GitHub user ohadshacham opened a pull request: https://github.com/apache/phoenix/pull/291 [PHOENIX-4278] Implement pure client side transactional index mainten… …ance. Moving the index update from a coprocessor to the client side. This is done only for transactions