Github user ankitsinghal commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/313#discussion_r206741679
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/query/QueryConstants.java ---
@@ -355,5 +355,19 @@
+ "," + COLUMN_NAME
Github user ankitsinghal commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/313#discussion_r206738423
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java
---
@@ -2723,13 +2712,10 @@ private void
Github user ankitsinghal commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/313#discussion_r206738342
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/query/QueryConstants.java ---
@@ -355,5 +355,19 @@
+ "," + COLUMN_NAME
Github user twdsilva commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/313#discussion_r206737818
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/query/QueryConstants.java ---
@@ -355,5 +355,19 @@
+ "," + COLUMN_NAME +
Github user twdsilva commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/313#discussion_r206737372
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java
---
@@ -2723,13 +2712,10 @@ private void
Github user twdsilva commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/313#discussion_r206737111
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/query/QueryConstants.java ---
@@ -355,5 +355,19 @@
+ "," + COLUMN_NAME +
Github user ankitsinghal commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/313#discussion_r206735726
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/query/QueryConstants.java ---
@@ -355,5 +355,19 @@
+ "," + COLUMN_NAME
Github user ankitsinghal commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/313#discussion_r206736061
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java
---
@@ -2723,13 +2712,10 @@ private void
Github user twdsilva commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/313#discussion_r206688033
--- Diff:
phoenix-core/src/it/java/org/apache/phoenix/end2end/BasePermissionsIT.java ---
@@ -82,6 +82,10 @@
static final String
Github user twdsilva commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/313#discussion_r206687937
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/schema/MetaDataClient.java ---
@@ -2957,6 +3010,11 @@ MutationState dropTable(String schemaName,
Github user twdsilva commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/313#discussion_r206687568
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/schema/MetaDataClient.java ---
@@ -1913,6 +1940,21 @@ private PTable
Github user twdsilva commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/313#discussion_r206687510
--- Diff:
phoenix-core/src/it/java/org/apache/phoenix/end2end/BasePermissionsIT.java ---
@@ -16,8 +16,29 @@
*/
package
Github user karanmehta93 commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/313#discussion_r206416912
--- Diff:
phoenix-core/src/it/java/org/apache/phoenix/end2end/BasePermissionsIT.java ---
@@ -16,8 +16,29 @@
*/
package
Github user karanmehta93 commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/313#discussion_r206415970
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/schema/MetaDataClient.java ---
@@ -2957,6 +3010,11 @@ MutationState dropTable(String
Github user karanmehta93 commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/313#discussion_r206415547
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/schema/MetaDataClient.java ---
@@ -1913,6 +1940,21 @@ private PTable
Github user karanmehta93 commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/313#discussion_r206414686
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java
---
@@ -3410,17 +3405,10 @@ void
Github user karanmehta93 commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/313#discussion_r206414419
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java
---
@@ -2723,6 +2712,9 @@ private void
Github user karanmehta93 commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/313#discussion_r206412733
--- Diff:
phoenix-core/src/it/java/org/apache/phoenix/end2end/BasePermissionsIT.java ---
@@ -82,6 +82,10 @@
static final String
Github user twdsilva commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/313#discussion_r206411967
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/schema/MetaDataClient.java ---
@@ -3604,6 +3681,18 @@ public MutationState addColumn(PTable table,
Github user ankitsinghal commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/313#discussion_r206330492
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/schema/MetaDataClient.java ---
@@ -3604,6 +3681,18 @@ public MutationState addColumn(PTable
Github user twdsilva commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/313#discussion_r205950165
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/schema/MetaDataClient.java ---
@@ -3604,6 +3675,17 @@ public MutationState addColumn(PTable table,
Github user twdsilva commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/313#discussion_r205950104
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/schema/MetaDataClient.java ---
@@ -3034,6 +3088,11 @@ MutationState dropTable(String schemaName,
Github user ankitsinghal commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/313#discussion_r205594858
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/schema/MetaDataClient.java ---
@@ -3604,6 +3675,17 @@ public MutationState addColumn(PTable
Github user ankitsinghal commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/313#discussion_r205595041
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/schema/MetaDataClient.java ---
@@ -3034,6 +3088,11 @@ MutationState dropTable(String
Github user ChinmaySKulkarni commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/313#discussion_r204969054
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/schema/MetaDataClient.java ---
@@ -3034,6 +3086,10 @@ MutationState dropTable(String
Github user ChinmaySKulkarni commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/313#discussion_r204968948
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/schema/MetaDataClient.java ---
@@ -1874,6 +1881,31 @@ private static boolean
Github user ChinmaySKulkarni commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/313#discussion_r204968823
--- Diff: phoenix-core/src/it/java/org/apache/phoenix/end2end/ViewIT.java
---
@@ -123,6 +148,48 @@ public static void doSetup() throws Exception {
Github user ChinmaySKulkarni commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/313#discussion_r204968699
--- Diff: phoenix-core/src/it/java/org/apache/phoenix/end2end/ViewIT.java
---
@@ -1274,28 +1341,145 @@ public void testChildViewCreationFails()
Github user ChinmaySKulkarni commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/313#discussion_r204968683
--- Diff: phoenix-core/src/it/java/org/apache/phoenix/end2end/ViewIT.java
---
@@ -1274,28 +1341,145 @@ public void testChildViewCreationFails()
GitHub user twdsilva opened a pull request:
https://github.com/apache/phoenix/pull/313
PHOENIX-4799 Write cells using checkAndMutate to prevent conflicting â¦
â¦changes
@vincentpoon @karanmehta93 @ChinmaySKulkarni Can you please review?
With this patch, when we add
30 matches
Mail list logo
