[jira] [Commented] (PHOENIX-852) Optimize child/parent foreign key joins

[ https://issues.apache.org/jira/browse/PHOENIX-852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15780999#comment-15780999 ] ASF GitHub Bot commented on PHOENIX-852: Github user maryannxue closed the pull r

[jira] [Commented] (PHOENIX-852) Optimize child/parent foreign key joins

[ https://issues.apache.org/jira/browse/PHOENIX-852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14118280#comment-14118280 ] Hudson commented on PHOENIX-852: SUCCESS: Integrated in Phoenix | 4.0 | Hadoop2 #88 (See

[jira] [Commented] (PHOENIX-852) Optimize child/parent foreign key joins

[ https://issues.apache.org/jira/browse/PHOENIX-852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14118276#comment-14118276 ] Hudson commented on PHOENIX-852: SUCCESS: Integrated in Phoenix | 3.0 | Hadoop1 #203 (See

[jira] [Commented] (PHOENIX-852) Optimize child/parent foreign key joins

[ https://issues.apache.org/jira/browse/PHOENIX-852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14118270#comment-14118270 ] Hudson commented on PHOENIX-852: SUCCESS: Integrated in Phoenix | Master | Hadoop1 #353 (

[jira] [Commented] (PHOENIX-852) Optimize child/parent foreign key joins

[ https://issues.apache.org/jira/browse/PHOENIX-852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14117603#comment-14117603 ] James Taylor commented on PHOENIX-852: -- I see. Note that for VARCHAR and VARBINARY,

[jira] [Commented] (PHOENIX-852) Optimize child/parent foreign key joins

[ https://issues.apache.org/jira/browse/PHOENIX-852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14117560#comment-14117560 ] Maryann Xue commented on PHOENIX-852: - Think the getSampleValue() itself has no probl

[jira] [Commented] (PHOENIX-852) Optimize child/parent foreign key joins

[ https://issues.apache.org/jira/browse/PHOENIX-852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14116930#comment-14116930 ] James Taylor commented on PHOENIX-852: -- Looks good, [~maryannxue]. See my comment on

[jira] [Commented] (PHOENIX-852) Optimize child/parent foreign key joins

[ https://issues.apache.org/jira/browse/PHOENIX-852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14114042#comment-14114042 ] Maryann Xue commented on PHOENIX-852: - Thanks a lot for the information, [~jamestaylo

[jira] [Commented] (PHOENIX-852) Optimize child/parent foreign key joins

[ https://issues.apache.org/jira/browse/PHOENIX-852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14113346#comment-14113346 ] James Taylor commented on PHOENIX-852: -- For ScanRanges, I'd create a new method like

[jira] [Commented] (PHOENIX-852) Optimize child/parent foreign key joins

[ https://issues.apache.org/jira/browse/PHOENIX-852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14113205#comment-14113205 ] James Taylor commented on PHOENIX-852: -- That's a nice improvement, [~maryannxue]! R

[jira] [Commented] (PHOENIX-852) Optimize child/parent foreign key joins

[ https://issues.apache.org/jira/browse/PHOENIX-852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14113186#comment-14113186 ] Maryann Xue commented on PHOENIX-852: - Did a local performance test: *Group1:* CREAT

[jira] [Commented] (PHOENIX-852) Optimize child/parent foreign key joins

[ https://issues.apache.org/jira/browse/PHOENIX-852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14112653#comment-14112653 ] Maryann Xue commented on PHOENIX-852: - Yes, I will sort the qualified join keys in pk

[jira] [Commented] (PHOENIX-852) Optimize child/parent foreign key joins

[ https://issues.apache.org/jira/browse/PHOENIX-852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14112540#comment-14112540 ] James Taylor commented on PHOENIX-852: -- Good point. You'll need to sort the join key

[jira] [Commented] (PHOENIX-852) Optimize child/parent foreign key joins

[ https://issues.apache.org/jira/browse/PHOENIX-852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1440#comment-1440 ] Maryann Xue commented on PHOENIX-852: - With more than one qualified join key, like pk

[jira] [Commented] (PHOENIX-852) Optimize child/parent foreign key joins

[ https://issues.apache.org/jira/browse/PHOENIX-852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14111059#comment-14111059 ] James Taylor commented on PHOENIX-852: -- My top level point is to make sure we have a

[jira] [Commented] (PHOENIX-852) Optimize child/parent foreign key joins

[ https://issues.apache.org/jira/browse/PHOENIX-852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14111020#comment-14111020 ] Maryann Xue commented on PHOENIX-852: - I had not read the new WhereOptimizer code whe

[jira] [Commented] (PHOENIX-852) Optimize child/parent foreign key joins

[ https://issues.apache.org/jira/browse/PHOENIX-852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14110918#comment-14110918 ] Maryann Xue commented on PHOENIX-852: - bq. One other question. In HashCacheClient, ca

[jira] [Commented] (PHOENIX-852) Optimize child/parent foreign key joins

[ https://issues.apache.org/jira/browse/PHOENIX-852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14110890#comment-14110890 ] James Taylor commented on PHOENIX-852: -- And instead of the code below, it'd be bette

[jira] [Commented] (PHOENIX-852) Optimize child/parent foreign key joins

[ https://issues.apache.org/jira/browse/PHOENIX-852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14110883#comment-14110883 ] James Taylor commented on PHOENIX-852: -- One other question. In HashCacheClient, can

[jira] [Commented] (PHOENIX-852) Optimize child/parent foreign key joins

[ https://issues.apache.org/jira/browse/PHOENIX-852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14110456#comment-14110456 ] James Taylor commented on PHOENIX-852: -- +1. Looks great, [~maryannxue]. Have you don

[jira] [Commented] (PHOENIX-852) Optimize child/parent foreign key joins

[ https://issues.apache.org/jira/browse/PHOENIX-852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14105734#comment-14105734 ] Maryann Xue commented on PHOENIX-852: - Agreed :) > Optimize child/parent foreign key

[jira] [Commented] (PHOENIX-852) Optimize child/parent foreign key joins

[ https://issues.apache.org/jira/browse/PHOENIX-852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14105721#comment-14105721 ] James Taylor commented on PHOENIX-852: -- It'll always be the case that an optimizatio

[jira] [Commented] (PHOENIX-852) Optimize child/parent foreign key joins

[ https://issues.apache.org/jira/browse/PHOENIX-852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14105699#comment-14105699 ] Maryann Xue commented on PHOENIX-852: - Yeah, I'm ok with checking in later, after the

[jira] [Commented] (PHOENIX-852) Optimize child/parent foreign key joins

[ https://issues.apache.org/jira/browse/PHOENIX-852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14105533#comment-14105533 ] James Taylor commented on PHOENIX-852: -- I think we should do some perf testing to fi

[jira] [Commented] (PHOENIX-852) Optimize child/parent foreign key joins

[ https://issues.apache.org/jira/browse/PHOENIX-852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14105520#comment-14105520 ] Maryann Xue commented on PHOENIX-852: - bq. What about the case where the RHS has been

[jira] [Commented] (PHOENIX-852) Optimize child/parent foreign key joins

[ https://issues.apache.org/jira/browse/PHOENIX-852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14105499#comment-14105499 ] James Taylor commented on PHOENIX-852: -- If it's ok with you, let's hold off on commi

[jira] [Commented] (PHOENIX-852) Optimize child/parent foreign key joins

[ https://issues.apache.org/jira/browse/PHOENIX-852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14105475#comment-14105475 ] Maryann Xue commented on PHOENIX-852: - Suppose the child table has PK c1,c2,c3, and t

[jira] [Commented] (PHOENIX-852) Optimize child/parent foreign key joins

[ https://issues.apache.org/jira/browse/PHOENIX-852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14105467#comment-14105467 ] Maryann Xue commented on PHOENIX-852: - Since using skip scan or range scan in joins l

[jira] [Commented] (PHOENIX-852) Optimize child/parent foreign key joins

[ https://issues.apache.org/jira/browse/PHOENIX-852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14104987#comment-14104987 ] James Taylor commented on PHOENIX-852: -- In the absence of any hints, I think the def

[jira] [Commented] (PHOENIX-852) Optimize child/parent foreign key joins

[ https://issues.apache.org/jira/browse/PHOENIX-852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14104968#comment-14104968 ] Maryann Xue commented on PHOENIX-852: - well, think the quick-and-dirty way will be en

[jira] [Commented] (PHOENIX-852) Optimize child/parent foreign key joins

[ https://issues.apache.org/jira/browse/PHOENIX-852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14104946#comment-14104946 ] James Taylor commented on PHOENIX-852: -- Thanks for the quick turn around on the patc

[jira] [Commented] (PHOENIX-852) Optimize child/parent foreign key joins

[ https://issues.apache.org/jira/browse/PHOENIX-852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14104723#comment-14104723 ] James Taylor commented on PHOENIX-852: -- Ah right - I forgot - I compile BETWEEN AND

[jira] [Commented] (PHOENIX-852) Optimize child/parent foreign key joins

[ https://issues.apache.org/jira/browse/PHOENIX-852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14104718#comment-14104718 ] Maryann Xue commented on PHOENIX-852: - Good, thanks! There's actually no between expr

[jira] [Commented] (PHOENIX-852) Optimize child/parent foreign key joins

[ https://issues.apache.org/jira/browse/PHOENIX-852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14104660#comment-14104660 ] James Taylor commented on PHOENIX-852: -- Yes, nulls would never be included. I can't

[jira] [Commented] (PHOENIX-852) Optimize child/parent foreign key joins

[ https://issues.apache.org/jira/browse/PHOENIX-852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14104641#comment-14104641 ] Maryann Xue commented on PHOENIX-852: - One question, is it safe to use BETWEEN-AND if

[jira] [Commented] (PHOENIX-852) Optimize child/parent foreign key joins

[ https://issues.apache.org/jira/browse/PHOENIX-852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14104448#comment-14104448 ] James Taylor commented on PHOENIX-852: -- +1 > Optimize child/parent foreign key join

[jira] [Commented] (PHOENIX-852) Optimize child/parent foreign key joins

[ https://issues.apache.org/jira/browse/PHOENIX-852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14104447#comment-14104447 ] Maryann Xue commented on PHOENIX-852: - bq. I see - so without a filter, there's no ne

[jira] [Commented] (PHOENIX-852) Optimize child/parent foreign key joins

[ https://issues.apache.org/jira/browse/PHOENIX-852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14104083#comment-14104083 ] James Taylor commented on PHOENIX-852: -- I see - so without a filter, there's no need

[jira] [Commented] (PHOENIX-852) Optimize child/parent foreign key joins

[ https://issues.apache.org/jira/browse/PHOENIX-852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14103834#comment-14103834 ] Maryann Xue commented on PHOENIX-852: - Think it will be ok. My only concern is when t

[jira] [Commented] (PHOENIX-852) Optimize child/parent foreign key joins

[ https://issues.apache.org/jira/browse/PHOENIX-852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14103576#comment-14103576 ] James Taylor commented on PHOENIX-852: -- What's your thinking for putting this in the

[jira] [Commented] (PHOENIX-852) Optimize child/parent foreign key joins

[ https://issues.apache.org/jira/browse/PHOENIX-852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14101777#comment-14101777 ] ASF GitHub Bot commented on PHOENIX-852: GitHub user maryannxue opened a pull req

[jira] [Commented] (PHOENIX-852) Optimize child/parent foreign key joins

[ https://issues.apache.org/jira/browse/PHOENIX-852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14099422#comment-14099422 ] Maryann Xue commented on PHOENIX-852: - Since we don't have stats, it is difficult to

[jira] [Commented] (PHOENIX-852) Optimize child/parent foreign key joins

[ https://issues.apache.org/jira/browse/PHOENIX-852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14099409#comment-14099409 ] James Taylor commented on PHOENIX-852: -- Yes, the decision of using/not using will be

[jira] [Commented] (PHOENIX-852) Optimize child/parent foreign key joins

[ https://issues.apache.org/jira/browse/PHOENIX-852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14099398#comment-14099398 ] Maryann Xue commented on PHOENIX-852: - How abt apply some "smart" decision, (like if

[jira] [Commented] (PHOENIX-852) Optimize child/parent foreign key joins

[ https://issues.apache.org/jira/browse/PHOENIX-852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14099341#comment-14099341 ] James Taylor commented on PHOENIX-852: -- For now maybe a hint is enough to disable th

[jira] [Commented] (PHOENIX-852) Optimize child/parent foreign key joins

[ https://issues.apache.org/jira/browse/PHOENIX-852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14099331#comment-14099331 ] Maryann Xue commented on PHOENIX-852: - [~jamestaylor] Just realized one thing: Some c

[jira] [Commented] (PHOENIX-852) Optimize child/parent foreign key joins

[ https://issues.apache.org/jira/browse/PHOENIX-852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14097820#comment-14097820 ] James Taylor commented on PHOENIX-852: -- Yes, that's the code. +1 for new JIRA. We al

[jira] [Commented] (PHOENIX-852) Optimize child/parent foreign key joins

[ https://issues.apache.org/jira/browse/PHOENIX-852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14097806#comment-14097806 ] Maryann Xue commented on PHOENIX-852: - I will open another issue to cover this improv

[jira] [Commented] (PHOENIX-852) Optimize child/parent foreign key joins

[ https://issues.apache.org/jira/browse/PHOENIX-852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14097782#comment-14097782 ] Maryann Xue commented on PHOENIX-852: - I see. So the below code is now what handles p

[jira] [Commented] (PHOENIX-852) Optimize child/parent foreign key joins

[ https://issues.apache.org/jira/browse/PHOENIX-852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14097775#comment-14097775 ] James Taylor commented on PHOENIX-852: -- Yes, correct - must be leading columns. Ther

[jira] [Commented] (PHOENIX-852) Optimize child/parent foreign key joins

[ https://issues.apache.org/jira/browse/PHOENIX-852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14097699#comment-14097699 ] Maryann Xue commented on PHOENIX-852: - Yes... guess I'm a little confused about the h

[jira] [Commented] (PHOENIX-852) Optimize child/parent foreign key joins

[ https://issues.apache.org/jira/browse/PHOENIX-852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14093722#comment-14093722 ] James Taylor commented on PHOENIX-852: -- +1. Nice approach. Note that in the case of

[jira] [Commented] (PHOENIX-852) Optimize child/parent foreign key joins

[ https://issues.apache.org/jira/browse/PHOENIX-852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14093072#comment-14093072 ] Maryann Xue commented on PHOENIX-852: - The approach I'm gonna take for now for join o

[jira] [Commented] (PHOENIX-852) Optimize child/parent foreign key joins

[ https://issues.apache.org/jira/browse/PHOENIX-852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14092985#comment-14092985 ] James Taylor commented on PHOENIX-852: -- I can see that the correlated subquery case

[jira] [Commented] (PHOENIX-852) Optimize child/parent foreign key joins

[ https://issues.apache.org/jira/browse/PHOENIX-852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14092907#comment-14092907 ] Maryann Xue commented on PHOENIX-852: - Yes. Let me make it clearer: LHS=(a, 1),(c, 2

[jira] [Commented] (PHOENIX-852) Optimize child/parent foreign key joins

[ https://issues.apache.org/jira/browse/PHOENIX-852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14092887#comment-14092887 ] James Taylor commented on PHOENIX-852: -- With RHS = (a,5) and LHS = (a,1),(a,1),(c,2)

[jira] [Commented] (PHOENIX-852) Optimize child/parent foreign key joins

[ https://issues.apache.org/jira/browse/PHOENIX-852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14092850#comment-14092850 ] Maryann Xue commented on PHOENIX-852: - bq. We could come in at a slightly lower level

[jira] [Commented] (PHOENIX-852) Optimize child/parent foreign key joins

[ https://issues.apache.org/jira/browse/PHOENIX-852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14092329#comment-14092329 ] James Taylor commented on PHOENIX-852: -- bq. I am thinking if it is possible to merge

[jira] [Commented] (PHOENIX-852) Optimize child/parent foreign key joins

[ https://issues.apache.org/jira/browse/PHOENIX-852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14090108#comment-14090108 ] Maryann Xue commented on PHOENIX-852: - We now need to introduce something like dynami

[jira] [Commented] (PHOENIX-852) Optimize child/parent foreign key joins

[ https://issues.apache.org/jira/browse/PHOENIX-852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14088735#comment-14088735 ] James Taylor commented on PHOENIX-852: -- I think it'd be easiest to just take the row