GitHub user ramkrish86 opened a pull request:
https://github.com/apache/incubator-phoenix/pull/18
Phoenix-128
Pull request for Phoenix-128
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ramkrish86/incubator-phoenix Phoenix-128
Github user ramkrish86 commented on a diff in the pull request:
https://github.com/apache/incubator-phoenix/pull/18#discussion_r10552682
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/schema/PArrayDataType.java ---
@@ -211,25 +211,33 @@ public boolean
isSizeCompatible
Github user ramkrish86 commented on a diff in the pull request:
https://github.com/apache/incubator-phoenix/pull/18#discussion_r10552686
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/schema/PArrayDataType.java ---
@@ -211,25 +211,33 @@ public boolean
isSizeCompatible
Github user ramkrish86 commented on a diff in the pull request:
https://github.com/apache/incubator-phoenix/pull/18#discussion_r10554556
--- Diff:
phoenix-core/src/test/java/org/apache/phoenix/end2end/ArrayTest.java ---
@@ -524,7 +524,43 @@ public void testCharArraySpecificIndex
Github user ramkrish86 commented on a diff in the pull request:
https://github.com/apache/incubator-phoenix/pull/18#discussion_r10595871
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/parse/CastParseNode.java ---
@@ -40,14 +40,23 @@
private final
GitHub user ramkrish86 opened a pull request:
https://github.com/apache/incubator-phoenix/pull/8
Phoenix 37
First cut pull request. Still not changed the format of serialization of
variable length array in ArrayConstructorExpression.
Moved the HEader information of the
Github user ramkrish86 commented on the pull request:
https://github.com/apache/incubator-phoenix/pull/8#discussion_r9854798
this is where i have a question. Now this serialization format should
comply with the one in the ParrayDataType where the normal array serialization
occurs and
Github user ramkrish86 commented on the pull request:
https://github.com/apache/incubator-phoenix/pull/8#discussion_r9854849
Okie, so here on the ptr you mean. I foudn that internally if we are able
to specify a correct size for the TrustedByteStream then calling toByteArray
does
Github user ramkrish86 commented on the pull request:
https://github.com/apache/incubator-phoenix/pull/8#issuecomment-35469062
Okie, so you mean avoiding the comparison of the first few bytes like
version, no of elements can be avoided.
---
If your project is set up for it, you can
Github user ramkrish86 commented on the pull request:
https://github.com/apache/incubator-phoenix/pull/8#issuecomment-35469802
Hmm, makes sense, but what i felt is in case of comparisons of such arrays,
wont we specify the offset from where the comparison should happen? Leaving
out
Github user ramkrish86 commented on the pull request:
https://github.com/apache/incubator-phoenix/pull/8#issuecomment-35471151
Hmmm..Got it in this context. Should have thought of this myself.. Thanks
James.
---
If your project is set up for it, you can reply to this email and have
Github user ramkrish86 commented on the pull request:
https://github.com/apache/incubator-phoenix/pull/8#discussion_r9859568
I have done this now. But not in the above way instead
ptr.set(byteStream.getBuffer(), 0, estimatedSize + elementLength);
where am
Github user ramkrish86 commented on the pull request:
https://github.com/apache/incubator-phoenix/pull/8#discussion_r9859582
done
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. To do so, please top-post your response
Github user ramkrish86 commented on the pull request:
https://github.com/apache/incubator-phoenix/pull/8#discussion_r9859631
(there's example code around for this - I think you have this already)
I think this is already done and we know what is the baseType of
Github user ramkrish86 commented on the pull request:
https://github.com/apache/incubator-phoenix/pull/8#discussion_r9859654
Done
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. To do so, please top-post your response
Github user ramkrish86 commented on the pull request:
https://github.com/apache/incubator-phoenix/pull/8#discussion_r9859645
done this. Treating it is an int array only. Hence writing the number of
elements as negative.
---
If your project is set up for it, you can reply to this
Github user ramkrish86 commented on the pull request:
https://github.com/apache/incubator-phoenix/pull/8#discussion_r9859649
Done
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. To do so, please top-post your response
Github user ramkrish86 commented on a diff in the pull request:
https://github.com/apache/incubator-phoenix/pull/8#discussion_r9902607
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/schema/PArrayDataType.java ---
@@ -253,9 +248,9 @@ public Object toObject(Object object
Github user ramkrish86 commented on a diff in the pull request:
https://github.com/apache/incubator-phoenix/pull/8#discussion_r9902647
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/expression/ArrayConstructorExpression.java
---
@@ -62,27 +67,62 @@ public void reset
Github user ramkrish86 commented on a diff in the pull request:
https://github.com/apache/incubator-phoenix/pull/8#discussion_r9902661
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/expression/ArrayConstructorExpression.java
---
@@ -62,27 +67,62 @@ public void reset
Github user ramkrish86 commented on a diff in the pull request:
https://github.com/apache/incubator-phoenix/pull/8#discussion_r9902697
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/expression/ArrayConstructorExpression.java
---
@@ -62,27 +67,62 @@ public void reset
Github user ramkrish86 commented on a diff in the pull request:
https://github.com/apache/incubator-phoenix/pull/8#discussion_r9902702
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/expression/ArrayConstructorExpression.java
---
@@ -39,18 +32,30 @@
private
Github user ramkrish86 commented on a diff in the pull request:
https://github.com/apache/incubator-phoenix/pull/8#discussion_r9902707
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/expression/ArrayConstructorExpression.java
---
@@ -62,27 +67,62 @@ public void reset
Github user ramkrish86 commented on a diff in the pull request:
https://github.com/apache/incubator-phoenix/pull/8#discussion_r9903698
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/expression/ArrayConstructorExpression.java
---
@@ -62,27 +67,62 @@ public void reset
Github user ramkrish86 commented on a diff in the pull request:
https://github.com/apache/incubator-phoenix/pull/8#discussion_r9903866
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/expression/ArrayConstructorExpression.java
---
@@ -62,27 +67,62 @@ public void reset
Github user ramkrish86 commented on a diff in the pull request:
https://github.com/apache/incubator-phoenix/pull/8#discussion_r9938141
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/expression/ArrayConstructorExpression.java
---
@@ -62,27 +63,54 @@ public void reset
Github user ramkrish86 commented on a diff in the pull request:
https://github.com/apache/incubator-phoenix/pull/8#discussion_r9938250
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/expression/ArrayConstructorExpression.java
---
@@ -62,27 +63,54 @@ public void reset
Github user ramkrish86 commented on a diff in the pull request:
https://github.com/apache/incubator-phoenix/pull/8#discussion_r9938328
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/expression/ArrayConstructorExpression.java
---
@@ -62,27 +63,54 @@ public void reset
Github user ramkrish86 commented on a diff in the pull request:
https://github.com/apache/incubator-phoenix/pull/8#discussion_r9948567
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/expression/ArrayConstructorExpression.java
---
@@ -62,27 +63,54 @@ public void reset
Github user ramkrish86 commented on a diff in the pull request:
https://github.com/apache/incubator-phoenix/pull/8#discussion_r9956836
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/expression/ArrayConstructorExpression.java
---
@@ -62,27 +63,54 @@ public void reset
Github user ramkrish86 commented on a diff in the pull request:
https://github.com/apache/incubator-phoenix/pull/8#discussion_r9957494
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/expression/ArrayConstructorExpression.java
---
@@ -62,27 +63,54 @@ public void reset
Github user ramkrish86 commented on a diff in the pull request:
https://github.com/apache/incubator-phoenix/pull/8#discussion_r9980773
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/expression/ArrayConstructorExpression.java
---
@@ -39,18 +31,27 @@
private
Github user ramkrish86 commented on a diff in the pull request:
https://github.com/apache/incubator-phoenix/pull/8#discussion_r9980788
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/expression/ArrayConstructorExpression.java
---
@@ -62,27 +63,54 @@ public void reset
Github user ramkrish86 commented on a diff in the pull request:
https://github.com/apache/incubator-phoenix/pull/8#discussion_r9980802
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/schema/PArrayDataType.java ---
@@ -77,9 +130,47 @@ public int toBytes(Object object, byte
Github user ramkrish86 commented on a diff in the pull request:
https://github.com/apache/incubator-phoenix/pull/8#discussion_r9980816
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/schema/PArrayDataType.java ---
@@ -77,9 +130,47 @@ public int toBytes(Object object, byte
Github user ramkrish86 commented on a diff in the pull request:
https://github.com/apache/incubator-phoenix/pull/8#discussion_r9982719
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/expression/ArrayConstructorExpression.java
---
@@ -62,27 +63,54 @@ public void reset
Github user ramkrish86 commented on a diff in the pull request:
https://github.com/apache/incubator-phoenix/pull/8#discussion_r9982793
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/schema/PArrayDataType.java ---
@@ -39,8 +42,9 @@ public PArrayDataType
Github user ramkrish86 commented on a diff in the pull request:
https://github.com/apache/incubator-phoenix/pull/8#discussion_r9982818
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/schema/PArrayDataType.java ---
@@ -146,11 +237,16 @@ public static void
Github user ramkrish86 commented on a diff in the pull request:
https://github.com/apache/incubator-phoenix/pull/8#discussion_r9982821
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/schema/PArrayDataType.java ---
@@ -228,49 +365,121 @@ public Object toObject(Object object
Github user ramkrish86 commented on a diff in the pull request:
https://github.com/apache/incubator-phoenix/pull/8#discussion_r10001826
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/schema/PArrayDataType.java ---
@@ -39,36 +49,64 @@ public PArrayDataType
Github user ramkrish86 commented on a diff in the pull request:
https://github.com/apache/incubator-phoenix/pull/8#discussion_r10001838
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/schema/PArrayDataType.java ---
@@ -77,9 +130,47 @@ public int toBytes(Object object, byte
Github user ramkrish86 commented on a diff in the pull request:
https://github.com/apache/incubator-phoenix/pull/8#discussion_r10005433
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/schema/PArrayDataType.java ---
@@ -160,44 +236,85 @@ public static void
Github user ramkrish86 commented on a diff in the pull request:
https://github.com/apache/incubator-phoenix/pull/8#discussion_r10005456
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/schema/PArrayDataType.java ---
@@ -289,75 +462,105 @@ private Object createPhoenixArray
Github user ramkrish86 commented on a diff in the pull request:
https://github.com/apache/incubator-phoenix/pull/8#discussion_r10005589
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/schema/PArrayDataType.java ---
@@ -39,36 +49,64 @@ public PArrayDataType
Github user ramkrish86 commented on a diff in the pull request:
https://github.com/apache/incubator-phoenix/pull/8#discussion_r10113013
--- Diff:
phoenix-core/src/test/java/org/apache/phoenix/end2end/ArrayTest.java ---
@@ -393,6 +393,73 @@ public void
Github user ramkrish86 commented on a diff in the pull request:
https://github.com/apache/incubator-phoenix/pull/8#discussion_r10115037
--- Diff:
phoenix-core/src/test/java/org/apache/phoenix/end2end/ArrayTest.java ---
@@ -393,6 +393,73 @@ public void
Github user ramkrish86 commented on a diff in the pull request:
https://github.com/apache/incubator-phoenix/pull/8#discussion_r10115251
--- Diff:
phoenix-core/src/test/java/org/apache/phoenix/end2end/ArrayTest.java ---
@@ -393,6 +393,73 @@ public void
Github user ramkrish86 commented on a diff in the pull request:
https://github.com/apache/incubator-phoenix/pull/8#discussion_r10116907
--- Diff:
phoenix-core/src/test/java/org/apache/phoenix/end2end/ArrayTest.java ---
@@ -393,6 +393,73 @@ public void
Github user ramkrish86 commented on a diff in the pull request:
https://github.com/apache/incubator-phoenix/pull/8#discussion_r10120847
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/schema/PArrayDataType.java ---
@@ -123,83 +189,69 @@ public Object toObject(byte[] bytes
Github user ramkrish86 commented on the pull request:
https://github.com/apache/incubator-phoenix/pull/8#issuecomment-36277518
Sure i can complete this. Let me check the Char[] part. I think there are
some prob in that
---
If your project is set up for it, you can reply to this
Github user ramkrish86 commented on a diff in the pull request:
https://github.com/apache/incubator-phoenix/pull/8#discussion_r10136695
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/schema/PArrayDataType.java ---
@@ -123,83 +189,69 @@ public Object toObject(byte[] bytes
Github user ramkrish86 commented on a diff in the pull request:
https://github.com/apache/incubator-phoenix/pull/8#discussion_r10139260
--- Diff:
phoenix-core/src/test/java/org/apache/phoenix/end2end/ArrayTest.java ---
@@ -393,6 +393,73 @@ public void
Github user ramkrish86 commented on a diff in the pull request:
https://github.com/apache/incubator-phoenix/pull/8#discussion_r10157196
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/expression/LiteralExpression.java
---
@@ -156,6 +162,9 @@ public static
53 matches
Mail list logo
