Re: Review Request: PIG-2765: Implementing RollupDimensions UDF and adding ROLLUP clause in CUBE operator

2012-07-01 Thread Dmitriy Ryaboy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5521/#review8778 --- overall, looks good. http://svn.apache.org/repos/asf/pig/trunk/src/

Re: Review Request: PIG-2726: Handling legitimate NULL values in CUBE operator

2012-07-01 Thread Dmitriy Ryaboy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5470/#review8777 --- Ship it! minor style/speed suggestion, other than that looks good.

[jira] [Updated] (PIG-2779) Refactoring the code for setting number of reducers

2012-07-01 Thread Jie Li (JIRA)
[ https://issues.apache.org/jira/browse/PIG-2779?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jie Li updated PIG-2779: Attachment: TestNumberOfReducers.java Attached a unit test file. In testEstimate2Parallel1 Pig uses wrong #reducers