Re: Review Request: PIG-2492 AvroStorage should recognize globs and commas

2012-07-17 Thread Cheolsoo Park
> On July 18, 2012, 2:56 a.m., Santhosh Srinivasan wrote: > > Needs more test cases to increase code coverage. There are no negative > > tests. Thank you very much for reviewing my patch! I will add more tests as you suggested. > On July 18, 2012, 2:56 a.m., Santhosh Srinivasan wrote: > > co

Re: Jenkins / Clover

2012-07-17 Thread Jonathan Coveney
+1 A while ago I tried to get apache builds to deal with this, and nothing. Very annoying, but pending a fix, we should remove it from the nightly. 2012/7/17 Alan Gates > I'm fine with removing it from the nightly build. I don't see any reason > to run that every day, especially since it slows

Re: Review Request: PIG-2492 AvroStorage should recognize globs and commas

2012-07-17 Thread Santhosh Srinivasan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5936/#review9233 --- Needs more test cases to increase code coverage. There are no negative

Re: Jenkins / Clover

2012-07-17 Thread Alan Gates
I'm fine with removing it from the nightly build. I don't see any reason to run that every day, especially since it slows down the tests. Let's not remove it from ant, as it's useful to run occasionally. Alan. On Jul 17, 2012, at 3:17 PM, Gianmarco De Francisci Morales wrote: > Hi, > > Clov

[jira] [Commented] (PIG-2824) Pushing checking number of fields into LoadFunc

2012-07-17 Thread Jie Li (JIRA)
[ https://issues.apache.org/jira/browse/PIG-2824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13416727#comment-13416727 ] Jie Li commented on PIG-2824: - The idea would be similar to pushing projection down to the loade

[jira] [Updated] (PIG-2824) Pushing checking number of fields into LoadFunc

2012-07-17 Thread Jie Li (JIRA)
[ https://issues.apache.org/jira/browse/PIG-2824?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jie Li updated PIG-2824: Attachment: 2824.png Attached result from a benchmark loading 10GB data that has 60 million records with 16 fields.

[jira] [Created] (PIG-2824) Pushing checking number of fields into LoadFunc

2012-07-17 Thread Jie Li (JIRA)
Jie Li created PIG-2824: --- Summary: Pushing checking number of fields into LoadFunc Key: PIG-2824 URL: https://issues.apache.org/jira/browse/PIG-2824 Project: Pig Issue Type: Improvement Affects Ver

[jira] [Resolved] (PIG-2823) TestPigContext.testImportList() does not pass if another javac in on the PATH

2012-07-17 Thread Julien Le Dem (JIRA)
[ https://issues.apache.org/jira/browse/PIG-2823?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julien Le Dem resolved PIG-2823. Resolution: Fixed Fix Version/s: 0.11 > TestPigContext.testImportList() does not pass if a

[jira] [Commented] (PIG-2823) TestPigContext.testImportList() does not pass if another javac in on the PATH

2012-07-17 Thread Julien Le Dem (JIRA)
[ https://issues.apache.org/jira/browse/PIG-2823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13416687#comment-13416687 ] Julien Le Dem commented on PIG-2823: done > TestPigContext.testImportLi

[jira] [Commented] (PIG-2823) TestPigContext.testImportList() does not pass if another javac in on the PATH

2012-07-17 Thread Jonathan Coveney (JIRA)
[ https://issues.apache.org/jira/browse/PIG-2823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13416671#comment-13416671 ] Jonathan Coveney commented on PIG-2823: --- +1 :) just make sure TestSchemaTuple still wo

[jira] [Updated] (PIG-2823) TestPigContext.testImportList() does not pass if another javac in on the PATH

2012-07-17 Thread Julien Le Dem (JIRA)
[ https://issues.apache.org/jira/browse/PIG-2823?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julien Le Dem updated PIG-2823: --- Attachment: PIG-2823_a.patch PIG-2823_a.patch addresses comments > TestPigContext.test

Jenkins / Clover

2012-07-17 Thread Gianmarco De Francisci Morales
Hi, Clover constantly makes a number of our Jenkins builds fail (usually because of license issues, I think it is a misconfiguration). Do we actually use it? If we don't I would propose to remove it from our build. What do you think? Cheers, -- Gianmarco

Build failed in Jenkins: Pig-trunk #1278

2012-07-17 Thread Apache Jenkins Server
See Changes: [gdfm] PIG-2797: Tests should not create their own file URIs through string concatenation, should use Util.generateURI instead (jgordon via azaroth) [julien] PIG-2820: relToAbsolutePath is not replayed properly when Grunt repa

[jira] [Resolved] (PIG-2800) pig.additional.jars path separator should align with File.pathSeparator instead of being hard-coded to ":"

2012-07-17 Thread Gianmarco De Francisci Morales (JIRA)
[ https://issues.apache.org/jira/browse/PIG-2800?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gianmarco De Francisci Morales resolved PIG-2800. - Resolution: Fixed Fix Version/s: 0.11 Tests passed. +1 Commi

[jira] [Commented] (PIG-2815) class loader management in PigContext

2012-07-17 Thread Jonathan Coveney (JIRA)
[ https://issues.apache.org/jira/browse/PIG-2815?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13416656#comment-13416656 ] Jonathan Coveney commented on PIG-2815: --- Raghu, Thanks for this. Note: in your patch

[jira] [Resolved] (PIG-2797) Tests should not create their own file URIs through string concatenation, should use Util.generateURI instead

2012-07-17 Thread Gianmarco De Francisci Morales (JIRA)
[ https://issues.apache.org/jira/browse/PIG-2797?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gianmarco De Francisci Morales resolved PIG-2797. - Resolution: Fixed Fix Version/s: 0.11 +1 Passes tests locall

[jira] [Commented] (PIG-2823) TestPigContext.testImportList() does not pass if another javac in on the PATH

2012-07-17 Thread Jonathan Coveney (JIRA)
[ https://issues.apache.org/jira/browse/PIG-2823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13416633#comment-13416633 ] Jonathan Coveney commented on PIG-2823: --- Since we use the same class in 2 places, can

[jira] [Updated] (PIG-2823) TestPigContext.testImportList() does not pass if another javac in on the PATH

2012-07-17 Thread Julien Le Dem (JIRA)
[ https://issues.apache.org/jira/browse/PIG-2823?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julien Le Dem updated PIG-2823: --- Attachment: PIG-2823.patch PIG-2823.patch uses the API access to the compiler instead

[jira] [Created] (PIG-2823) TestPigContext.testImportList() does not pass if another javac in on the PATH

2012-07-17 Thread Julien Le Dem (JIRA)
Julien Le Dem created PIG-2823: -- Summary: TestPigContext.testImportList() does not pass if another javac in on the PATH Key: PIG-2823 URL: https://issues.apache.org/jira/browse/PIG-2823 Project: Pig

[jira] [Updated] (PIG-2815) class loader management in PigContext

2012-07-17 Thread Raghu Angadi (JIRA)
[ https://issues.apache.org/jira/browse/PIG-2815?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Raghu Angadi updated PIG-2815: -- Attachment: PIG-2815-branch-0.9.patch patch for 0.9. > class loader management in PigCon

[jira] [Updated] (PIG-2822) HBaseStorage should load hbase configuration into Job configuration under the covers

2012-07-17 Thread Francis Liu (JIRA)
[ https://issues.apache.org/jira/browse/PIG-2822?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Francis Liu updated PIG-2822: - Fix Version/s: 0.10.1 > HBaseStorage should load hbase configuration into Job configuration under the

[jira] [Created] (PIG-2822) HBaseStorage should load hbase configuration into Job configuration under the covers

2012-07-17 Thread Francis Liu (JIRA)
Francis Liu created PIG-2822: Summary: HBaseStorage should load hbase configuration into Job configuration under the covers Key: PIG-2822 URL: https://issues.apache.org/jira/browse/PIG-2822 Project: Pig

[jira] [Commented] (PIG-2820) relToAbsolutePath is not replayed properly when Grunt reparses the script after PIG-2699

2012-07-17 Thread Jonathan Coveney (JIRA)
[ https://issues.apache.org/jira/browse/PIG-2820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13416424#comment-13416424 ] Jonathan Coveney commented on PIG-2820: --- +1 > relToAbsolutePath is no

[jira] [Updated] (PIG-2821) HBaseStorage does not support delegation tokens

2012-07-17 Thread Francis Liu (JIRA)
[ https://issues.apache.org/jira/browse/PIG-2821?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Francis Liu updated PIG-2821: - Description: HBaseStorage needs to add HBase delegation token to the Job object if hbase security is enable

[jira] [Created] (PIG-2821) HBaseStorage does not support delegation tokens

2012-07-17 Thread Francis Liu (JIRA)
Francis Liu created PIG-2821: Summary: HBaseStorage does not support delegation tokens Key: PIG-2821 URL: https://issues.apache.org/jira/browse/PIG-2821 Project: Pig Issue Type: Bug Affects V

[jira] [Updated] (PIG-2820) relToAbsolutePath is not replayed properly when Grunt reparses the script after PIG-2699

2012-07-17 Thread Julien Le Dem (JIRA)
[ https://issues.apache.org/jira/browse/PIG-2820?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julien Le Dem updated PIG-2820: --- Patch Info: Patch Available Affects Version/s: 0.11 > relToAbsolutePath is not replayed

[jira] [Updated] (PIG-2820) relToAbsolutePath is not replayed properly when Grunt reparses the script after PIG-2699

2012-07-17 Thread Julien Le Dem (JIRA)
[ https://issues.apache.org/jira/browse/PIG-2820?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julien Le Dem updated PIG-2820: --- Attachment: PIG-2820.patch PIG-2820.patch fixes this > relToAbsolutePath is not replay

[jira] [Commented] (PIG-2699) Reduce the number of instances of Load and Store Funcs down to 2+1. It should be 1 in the front-end and 1 in the backend

2012-07-17 Thread Julien Le Dem (JIRA)
[ https://issues.apache.org/jira/browse/PIG-2699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13416401#comment-13416401 ] Julien Le Dem commented on PIG-2699: Hi Koji This is indeed related. TestUDFCOntext was

[jira] [Created] (PIG-2820) relToAbsolutePath is not replayed properly when Grunt reparses the script after PIG-2699

2012-07-17 Thread Julien Le Dem (JIRA)
Julien Le Dem created PIG-2820: -- Summary: relToAbsolutePath is not replayed properly when Grunt reparses the script after PIG-2699 Key: PIG-2820 URL: https://issues.apache.org/jira/browse/PIG-2820 Projec

[jira] [Commented] (PIG-2729) Macro expansion does not use pig.import.search.path - UnitTest borked

2012-07-17 Thread Rohini Palaniswamy (JIRA)
[ https://issues.apache.org/jira/browse/PIG-2729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13416394#comment-13416394 ] Rohini Palaniswamy commented on PIG-2729: - Johannes, You need to do "git diff --no

[jira] [Updated] (PIG-2729) Macro expansion does not use pig.import.search.path - UnitTest borked

2012-07-17 Thread Johannes Schwenk (JIRA)
[ https://issues.apache.org/jira/browse/PIG-2729?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Johannes Schwenk updated PIG-2729: -- Attachment: PIG-2729.patch Hi Rohini, I attached a new patch that fixes the issue with relative

[jira] [Commented] (PIG-2706) Add clear to list of grunt commands

2012-07-17 Thread Gianmarco De Francisci Morales (JIRA)
[ https://issues.apache.org/jira/browse/PIG-2706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13416079#comment-13416079 ] Gianmarco De Francisci Morales commented on PIG-2706: - Patch looks good.