[
https://issues.apache.org/jira/browse/PIG-3373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13988967#comment-13988967
]
Ahmed Eldawy commented on PIG-3373:
---
Yes. This issue is already covered by PIG-3865. We
[
https://issues.apache.org/jira/browse/PIG-3865?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ahmed Eldawy updated PIG-3865:
--
Attachment: test-file-2.xml.bz2
Test file
Place in
src/test/java/org/apache/pig/piggybank/test
[
https://issues.apache.org/jira/browse/PIG-3865?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ahmed Eldawy updated PIG-3865:
--
Attachment: bad-file.xml.bz2
Test file. Place this file in
src/test/java/org/apache/pig/piggybank/test
[
https://issues.apache.org/jira/browse/PIG-3865?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13978311#comment-13978311
]
Ahmed Eldawy commented on PIG-3865:
---
Sorry for the delay. For some reasons, I didn't
[
https://issues.apache.org/jira/browse/PIG-3865?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ahmed Eldawy updated PIG-3865:
--
Attachment: XMLLoader.java
An updated version of XMLLoader with more comments and better structure
[
https://issues.apache.org/jira/browse/PIG-3865?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ahmed Eldawy updated PIG-3865:
--
Attachment: PIG-3865.patch
A patch for TestXMLLoader. It fixes some errors in previous tests. It also
[
https://issues.apache.org/jira/browse/PIG-3865?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ahmed Eldawy updated PIG-3865:
--
Attachment: (was: PIG-3865.patch)
Remodel the XMLLoader to work to be faster and more maintainable
[
https://issues.apache.org/jira/browse/PIG-3865?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ahmed Eldawy updated PIG-3865:
--
Attachment: (was: PIG-3865.patch)
Remodel the XMLLoader to work to be faster and more maintainable
[
https://issues.apache.org/jira/browse/PIG-3865?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ahmed Eldawy updated PIG-3865:
--
Attachment: (was: XMLLoader.java)
Remodel the XMLLoader to work to be faster and more maintainable
[
https://issues.apache.org/jira/browse/PIG-3865?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ahmed Eldawy updated PIG-3865:
--
Attachment: PIG-3865-test.txt
Sorry. The previous patch was for XMLLoader not the test
[
https://issues.apache.org/jira/browse/PIG-3865?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ahmed Eldawy updated PIG-3865:
--
Description:
I recreated the XMLLoader in PiggyBank to work line by line instead of
character
[
https://issues.apache.org/jira/browse/PIG-3865?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ahmed Eldawy updated PIG-3865:
--
Attachment: XMLLoader.java
PIG-3865.patch
A patch for the test to add one more test case
[
https://issues.apache.org/jira/browse/PIG-3865?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ahmed Eldawy updated PIG-3865:
--
Status: Patch Available (was: Open)
A patch is attached for the test which adds a new test for when
[
https://issues.apache.org/jira/browse/PIG-3373?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ahmed Eldawy updated PIG-3373:
--
Attachment: PIG3373_2.patch
This new patch uses a specific file rather than generating its own file
[
https://issues.apache.org/jira/browse/PIG-3373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13887929#comment-13887929
]
Ahmed Eldawy commented on PIG-3373:
---
By the way, the attached file bad-file.xml.bz2
[
https://issues.apache.org/jira/browse/PIG-3373?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ahmed Eldawy updated PIG-3373:
--
Attachment: test-file-2.xml.bz2
Another, slightly smaller, test file that reveals this bug.
XMLLoader
[
https://issues.apache.org/jira/browse/PIG-3373?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ahmed Eldawy updated PIG-3373:
--
Attachment: PIG3373_3.patch
This patch uses test files in a test directory.
XMLLoader returns non
[
https://issues.apache.org/jira/browse/PIG-3373?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ahmed Eldawy updated PIG-3373:
--
Attachment: PIG3373_1.patch
This new patch includes a test case that fails. The fix is still the same
[
https://issues.apache.org/jira/browse/PIG-3373?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ahmed Eldawy updated PIG-3373:
--
Attachment: bad-file.xml.bz2
This is an example of a file that fails. Currently, this file is generated
[
https://issues.apache.org/jira/browse/PIG-3373?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ahmed Eldawy updated PIG-3373:
--
Affects Version/s: site
Release Note:
I added a new patch that fixes this bug. It turned out
Ahmed Eldawy created PIG-3373:
-
Summary: XMLLoader returns non-matching nodes when a tag name
spans through the block boundary
Key: PIG-3373
URL: https://issues.apache.org/jira/browse/PIG-3373
Project
[
https://issues.apache.org/jira/browse/PIG-3373?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ahmed Eldawy updated PIG-3373:
--
Labels: patch (was: )
Status: Patch Available (was: Open)
I fixed this bug by allowing the reader
[
https://issues.apache.org/jira/browse/PIG-3373?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ahmed Eldawy updated PIG-3373:
--
Status: Open (was: Patch Available)
XMLLoader returns non-matching nodes when a tag name spans
[
https://issues.apache.org/jira/browse/PIG-3373?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ahmed Eldawy updated PIG-3373:
--
Attachment: PIG3373.patch
XMLLoader returns non-matching nodes when a tag name spans through
[
https://issues.apache.org/jira/browse/PIG-3373?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ahmed Eldawy updated PIG-3373:
--
Status: Patch Available (was: Open)
diff --git java/src/main/java/org/apache/pig/piggybank/storage
Ahmed Eldawy created PIG-3344:
-
Summary: Add a spatial datatype to Pig
Key: PIG-3344
URL: https://issues.apache.org/jira/browse/PIG-3344
Project: Pig
Issue Type: New Feature
Components
Ahmed
Best regards,
Ahmed Eldawy
On Wed, May 29, 2013 at 12:17 PM, Russell Jurney
russell.jur...@gmail.comwrote:
Awesome. This would be a great addition to Pig. Please create a JIRA.
Russell Jurney http://datasyndrome.com
On May 29, 2013, at 8:51 AM, Ahmed Eldawy aseld...@gmail.com wrote
/OGCGeometry.htmlwhich
can be linked to a new datatype 'Geometry'. Do you think we can rely on the
new package and integrate the work with Apache Pig?
On May 23, 2013 11:40 PM, Ahmed Eldawy aseld...@gmail.com wrote:
Hi all,
Thanks for your help. I've started the project with a minimal
functionality
the project home page
https://github.com/aseldawy/pigeon
If you have any comments or suggestion please contact me.
Best regards,
Ahmed Eldawy
On Mon, May 6, 2013 at 3:09 PM, Jonathan Coveney jcove...@gmail.com wrote:
Nick: the only issue is that the way types are implemented in Pig don't
allow us
Best regards,
Ahmed Eldawy
On Sat, May 4, 2013 at 4:47 PM, Jonathan Coveney jcove...@gmail.com wrote:
I agree that this is cool, and if other projects are using JTS it is worth
talking them to see how. I also agree that licensing is very frustrating.
In the short term, however, while
ported to newer versions of Pig.
Thanks
Ahmed
Best regards,
Ahmed Eldawy
On Thu, May 2, 2013 at 12:33 PM, Alan Gates ga...@hortonworks.com wrote:
I know this is frustrating, but the different licenses do have different
requirements that make it so that Apache can't ship GPL code. A legal
and hope to hear back from you.
Best regards,
Ahmed Eldawy
, Ahmed Eldawy wrote:
Hi all,
First, sorry for the long email. I wanted to put all my thoughts here
and
get your feedback.
I'm proposing a major addition to Pig that will greatly increase its
functionality and user base. It is simply to add spatial support to the
language
there is no issue raised for this bug.
Can you please help me?
Best regards,
Ahmed Eldawy
Ahmed Eldawy created PIG-3304:
-
Summary: XMLLoader in piggybank does not work with inline closed
tags
Key: PIG-3304
URL: https://issues.apache.org/jira/browse/PIG-3304
Project: Pig
Issue Type
[
https://issues.apache.org/jira/browse/PIG-3304?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ahmed Eldawy updated PIG-3304:
--
Status: Patch Available (was: Open)
XMLLoader in piggybank does not work with inline closed tags
[
https://issues.apache.org/jira/browse/PIG-3304?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ahmed Eldawy updated PIG-3304:
--
Status: Open (was: Patch Available)
diff --git java/src/main/java/org/apache/pig/piggybank/storage
[
https://issues.apache.org/jira/browse/PIG-3304?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ahmed Eldawy resolved PIG-3304.
---
Resolution: Fixed
XMLLoader in piggybank does not work with inline closed tags
Thanks for your help.
I've created an issue and attached my fix. Here's the link
https://issues.apache.org/jira/browse/PIG-3304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel
What should I do next to get this code merged with the source repo?
Best regards,
Ahmed Eldawy
[
https://issues.apache.org/jira/browse/PIG-3304?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ahmed Eldawy reopened PIG-3304:
---
Found a bug with nested entities that are closed inline
XMLLoader in piggybank does
[
https://issues.apache.org/jira/browse/PIG-3304?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ahmed Eldawy updated PIG-3304:
--
Attachment: xmlloader_inline_close_tag_1.patch
An updated path that handles nested elements with inline
41 matches
Mail list logo
