[
https://issues.apache.org/jira/browse/PIG-3359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13730376#comment-13730376
]
Cheolsoo Park commented on PIG-3359:
+1. I will commit it.
Register
[
https://issues.apache.org/jira/browse/PIG-3359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13730392#comment-13730392
]
Cheolsoo Park commented on PIG-3359:
Thank you Jonathan for the excellent work! Look
[
https://issues.apache.org/jira/browse/PIG-3359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13727988#comment-13727988
]
Cheolsoo Park commented on PIG-3359:
All the unit tests pass. I also tested with some of
[
https://issues.apache.org/jira/browse/PIG-3359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13728018#comment-13728018
]
Cheolsoo Park commented on PIG-3359:
On a second thought, I think we should change the
[
https://issues.apache.org/jira/browse/PIG-3359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13725462#comment-13725462
]
Cheolsoo Park commented on PIG-3359:
Looks great! Let me run the unit tests today. I am
[
https://issues.apache.org/jira/browse/PIG-3359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13717689#comment-13717689
]
Jonathan Packer commented on PIG-3359:
--
Sure thing. I don't think I'll be able to get
[
https://issues.apache.org/jira/browse/PIG-3359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13714627#comment-13714627
]
Cheolsoo Park commented on PIG-3359:
Great! I just confirmed all unit tests pass now.
[
https://issues.apache.org/jira/browse/PIG-3359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13712643#comment-13712643
]
Cheolsoo Park commented on PIG-3359:
Hi Jonathan, thank you very much for the update and
[
https://issues.apache.org/jira/browse/PIG-3359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13713073#comment-13713073
]
Cheolsoo Park commented on PIG-3359:
I love what you did for parameter substitution
[
https://issues.apache.org/jira/browse/PIG-3359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13711632#comment-13711632
]
Jonathan Packer commented on PIG-3359:
--
Cheolsoo, I updated patch to address your
[
https://issues.apache.org/jira/browse/PIG-3359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13708920#comment-13708920
]
Cheolsoo Park commented on PIG-3359:
I also made some comments in RB:
[
https://issues.apache.org/jira/browse/PIG-3359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13708193#comment-13708193
]
Cheolsoo Park commented on PIG-3359:
[~jpacker], thank you for updating the patch.
[
https://issues.apache.org/jira/browse/PIG-3359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13706134#comment-13706134
]
Johnny Zhang commented on PIG-3359:
---
Hi, Jonathan, few questions:
1. how to use existing
[
https://issues.apache.org/jira/browse/PIG-3359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13703711#comment-13703711
]
Cheolsoo Park commented on PIG-3359:
[~jpacker], I have one question for you.
{quote}
I
[
https://issues.apache.org/jira/browse/PIG-3359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13696848#comment-13696848
]
Jonathan Packer commented on PIG-3359:
--
Hi, I uploaded the diff to RB:
[
https://issues.apache.org/jira/browse/PIG-3359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13691325#comment-13691325
]
Cheolsoo Park commented on PIG-3359:
{quote}
I haven't been able to upload my diff to
16 matches
Mail list logo
