[jira] [Commented] (PIG-3419) Pluggable Execution Engine

[ https://issues.apache.org/jira/browse/PIG-3419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13769734#comment-13769734 ] Cheolsoo Park commented on PIG-3419: I will open a jira to add unstable annotations. I

[jira] [Commented] (PIG-3419) Pluggable Execution Engine

[ https://issues.apache.org/jira/browse/PIG-3419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13768649#comment-13768649 ] Dmitriy V. Ryaboy commented on PIG-3419: +1 to marking the interfaces as evolving.

[jira] [Commented] (PIG-3419) Pluggable Execution Engine

[ https://issues.apache.org/jira/browse/PIG-3419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13767615#comment-13767615 ] Rohini Palaniswamy commented on PIG-3419: - Dmitriy, I am not arguing about adding

[jira] [Commented] (PIG-3419) Pluggable Execution Engine

[ https://issues.apache.org/jira/browse/PIG-3419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13767190#comment-13767190 ] Rohini Palaniswamy commented on PIG-3419: - I having second thoughts on having this

[jira] [Commented] (PIG-3419) Pluggable Execution Engine

[ https://issues.apache.org/jira/browse/PIG-3419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13767220#comment-13767220 ] Dmitriy V. Ryaboy commented on PIG-3419: This is not just for Tez. The point is to

[jira] [Commented] (PIG-3419) Pluggable Execution Engine

[ https://issues.apache.org/jira/browse/PIG-3419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13767227#comment-13767227 ] Bill Graham commented on PIG-3419: -- Would should at least annotate the new interfaces as

[jira] [Commented] (PIG-3419) Pluggable Execution Engine

[ https://issues.apache.org/jira/browse/PIG-3419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13764811#comment-13764811 ] Daniel Dai commented on PIG-3419: - This break the Oozie build, which uses

[jira] [Commented] (PIG-3419) Pluggable Execution Engine

[ https://issues.apache.org/jira/browse/PIG-3419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13764834#comment-13764834 ] Daniel Dai commented on PIG-3419: - Opened PIG-3457 for that. Pluggable

[jira] [Commented] (PIG-3419) Pluggable Execution Engine

[ https://issues.apache.org/jira/browse/PIG-3419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13754975#comment-13754975 ] Julien Le Dem commented on PIG-3419: +1 [~cheolsoo] LGTM! Pluggable

[jira] [Commented] (PIG-3419) Pluggable Execution Engine

[ https://issues.apache.org/jira/browse/PIG-3419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13753843#comment-13753843 ] Bikas Saha commented on PIG-3419: - Folks, FYI, based on recent feedback we have changed the

[jira] [Commented] (PIG-3419) Pluggable Execution Engine

[ https://issues.apache.org/jira/browse/PIG-3419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13753869#comment-13753869 ] Bikas Saha commented on PIG-3419: - Looks like this jira wasnt the appropriate one to comment

[jira] [Commented] (PIG-3419) Pluggable Execution Engine

[ https://issues.apache.org/jira/browse/PIG-3419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13753878#comment-13753878 ] Achal Soni commented on PIG-3419: - [~bikassaha] Thanks for the heads-up Bikas! This JIRA is

[jira] [Commented] (PIG-3419) Pluggable Execution Engine

[ https://issues.apache.org/jira/browse/PIG-3419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13753912#comment-13753912 ] Julien Le Dem commented on PIG-3419: [~cheolsoo]: thanks a lot for looking into this.

[jira] [Commented] (PIG-3419) Pluggable Execution Engine

[ https://issues.apache.org/jira/browse/PIG-3419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13753985#comment-13753985 ] Achal Soni commented on PIG-3419: - I agree with all that is said, but there is no need to

[jira] [Commented] (PIG-3419) Pluggable Execution Engine

[ https://issues.apache.org/jira/browse/PIG-3419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13754235#comment-13754235 ] Dmitriy V. Ryaboy commented on PIG-3419: [~billgraham] looping you in for Ambrose.

[jira] [Commented] (PIG-3419) Pluggable Execution Engine

[ https://issues.apache.org/jira/browse/PIG-3419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13752785#comment-13752785 ] Cheolsoo Park commented on PIG-3419: [~rohini], {quote} It makes lot of changes to the

[jira] [Commented] (PIG-3419) Pluggable Execution Engine

[ https://issues.apache.org/jira/browse/PIG-3419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13753241#comment-13753241 ] Cheolsoo Park commented on PIG-3419: All unit tests pass. Pluggable

[jira] [Commented] (PIG-3419) Pluggable Execution Engine

[ https://issues.apache.org/jira/browse/PIG-3419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13751788#comment-13751788 ] Cheolsoo Park commented on PIG-3419: Kicked off full unit tests now.

[jira] [Commented] (PIG-3419) Pluggable Execution Engine

[ https://issues.apache.org/jira/browse/PIG-3419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13748657#comment-13748657 ] Cheolsoo Park commented on PIG-3419: All, so here is the list of failing tests: {code}

[jira] [Commented] (PIG-3419) Pluggable Execution Engine

[ https://issues.apache.org/jira/browse/PIG-3419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13748873#comment-13748873 ] Achal Soni commented on PIG-3419: - [~cheolsoo] Thanks a lot for running the test suite! It's

[jira] [Commented] (PIG-3419) Pluggable Execution Engine

[ https://issues.apache.org/jira/browse/PIG-3419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13748907#comment-13748907 ] Rohini Palaniswamy commented on PIG-3419: - In the Pig-on-Tez meeting in Linkedin we

[jira] [Commented] (PIG-3419) Pluggable Execution Engine

[ https://issues.apache.org/jira/browse/PIG-3419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13749014#comment-13749014 ] Dmitriy V. Ryaboy commented on PIG-3419: Rohini, I want to reiterate that this patch

[jira] [Commented] (PIG-3419) Pluggable Execution Engine

[ https://issues.apache.org/jira/browse/PIG-3419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13749106#comment-13749106 ] Olga Natkovich commented on PIG-3419: - I think the reason we wanted it on the Tez branch

[jira] [Commented] (PIG-3419) Pluggable Execution Engine

[ https://issues.apache.org/jira/browse/PIG-3419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13749226#comment-13749226 ] Julien Le Dem commented on PIG-3419: The advantage of having the Execution engine

[jira] [Commented] (PIG-3419) Pluggable Execution Engine

[ https://issues.apache.org/jira/browse/PIG-3419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13747564#comment-13747564 ] Cheolsoo Park commented on PIG-3419: Attached test_failures.txt.

[jira] [Commented] (PIG-3419) Pluggable Execution Engine

[ https://issues.apache.org/jira/browse/PIG-3419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13747968#comment-13747968 ] Achal Soni commented on PIG-3419: - Here is the ReviewBoard for the new patch :

[jira] [Commented] (PIG-3419) Pluggable Execution Engine

[ https://issues.apache.org/jira/browse/PIG-3419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13748137#comment-13748137 ] Cheolsoo Park commented on PIG-3419: I will kick off the unit tests with the new patch

[jira] [Commented] (PIG-3419) Pluggable Execution Engine

[ https://issues.apache.org/jira/browse/PIG-3419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13748183#comment-13748183 ] Julien Le Dem commented on PIG-3419: +1 LGTM If test-commit passes I think we can commit

[jira] [Commented] (PIG-3419) Pluggable Execution Engine

[ https://issues.apache.org/jira/browse/PIG-3419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13746842#comment-13746842 ] Achal Soni commented on PIG-3419: - I have taken all the suggestions into account and

[jira] [Commented] (PIG-3419) Pluggable Execution Engine

[ https://issues.apache.org/jira/browse/PIG-3419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13746999#comment-13746999 ] Julien Le Dem commented on PIG-3419: I have submitted my review. This looks great

[jira] [Commented] (PIG-3419) Pluggable Execution Engine

[ https://issues.apache.org/jira/browse/PIG-3419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13747021#comment-13747021 ] Cheolsoo Park commented on PIG-3419: [~julienledem], I haven't looked at it yet, but I

[jira] [Commented] (PIG-3419) Pluggable Execution Engine

[ https://issues.apache.org/jira/browse/PIG-3419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13747065#comment-13747065 ] Dmitriy V. Ryaboy commented on PIG-3419: I'd like this patch in trunk since it's not

[jira] [Commented] (PIG-3419) Pluggable Execution Engine

[ https://issues.apache.org/jira/browse/PIG-3419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13747064#comment-13747064 ] Julien Le Dem commented on PIG-3419: The point is to be able to implement alternate

[jira] [Commented] (PIG-3419) Pluggable Execution Engine

[ https://issues.apache.org/jira/browse/PIG-3419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13747131#comment-13747131 ] Mark Wagner commented on PIG-3419: -- I'd also be in favor putting this in trunk as opposed

[jira] [Commented] (PIG-3419) Pluggable Execution Engine

[ https://issues.apache.org/jira/browse/PIG-3419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13745398#comment-13745398 ] Julien Le Dem commented on PIG-3419: [~cheolsoo] 1. Do we really throw Exception ? If

[jira] [Commented] (PIG-3419) Pluggable Execution Engine

[ https://issues.apache.org/jira/browse/PIG-3419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13745448#comment-13745448 ] Cheolsoo Park commented on PIG-3419: [~julienledem], {quote} Do we really throw

[jira] [Commented] (PIG-3419) Pluggable Execution Engine

[ https://issues.apache.org/jira/browse/PIG-3419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13740079#comment-13740079 ] Achal Soni commented on PIG-3419: - And here are the reviewboards for each one. Main

[jira] [Commented] (PIG-3419) Pluggable Execution Engine

[ https://issues.apache.org/jira/browse/PIG-3419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13738285#comment-13738285 ] Dmitriy V. Ryaboy commented on PIG-3419: Hi Achal, That's a large patch. Can you

[jira] [Commented] (PIG-3419) Pluggable Execution Engine

[ https://issues.apache.org/jira/browse/PIG-3419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13738288#comment-13738288 ] Dmitriy V. Ryaboy commented on PIG-3419: oh 3 more things :) I thought you found

[jira] [Commented] (PIG-3419) Pluggable Execution Engine

[ https://issues.apache.org/jira/browse/PIG-3419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13738478#comment-13738478 ] Julien Le Dem commented on PIG-3419: Hi Achal for large patches, please create a review

[jira] [Commented] (PIG-3419) Pluggable Execution Engine

[ https://issues.apache.org/jira/browse/PIG-3419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13738881#comment-13738881 ] Achal Soni commented on PIG-3419: - Sorry my bad! Was trying to get it out as soon as

[jira] [Commented] (PIG-3419) Pluggable Execution Engine

[ https://issues.apache.org/jira/browse/PIG-3419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13737092#comment-13737092 ] Achal Soni commented on PIG-3419: - Here is the current patch as is, with the changes to /src