[jira] [Commented] (PIG-4267) ToDate has incorrect timezone offsets

2014-11-07 Thread Brian Johnson (JIRA)
[ https://issues.apache.org/jira/browse/PIG-4267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14202213#comment-14202213 ] Brian Johnson commented on PIG-4267: for that matter, why are all these piggybank ISO fu

[jira] [Commented] (PIG-4267) ToDate has incorrect timezone offsets

2014-11-07 Thread Brian Johnson (JIRA)
[ https://issues.apache.org/jira/browse/PIG-4267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14202170#comment-14202170 ] Brian Johnson commented on PIG-4267: ISOHelper has some more serious issues because the

[jira] [Commented] (PIG-4267) ToDate has incorrect timezone offsets

2014-11-06 Thread Brian Johnson (JIRA)
[ https://issues.apache.org/jira/browse/PIG-4267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14201003#comment-14201003 ] Brian Johnson commented on PIG-4267: I'm going to fix the existing ISO functions that do

[jira] [Commented] (PIG-4267) ToDate has incorrect timezone offsets

2014-11-06 Thread Brian Johnson (JIRA)
[ https://issues.apache.org/jira/browse/PIG-4267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14200480#comment-14200480 ] Brian Johnson commented on PIG-4267: Really all of this code needs to be refactored. It

[jira] [Commented] (PIG-4267) ToDate has incorrect timezone offsets

2014-11-06 Thread Brian Johnson (JIRA)
[ https://issues.apache.org/jira/browse/PIG-4267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14200184#comment-14200184 ] Brian Johnson commented on PIG-4267: But those aren't really relevant to the bug and all

[jira] [Commented] (PIG-4267) ToDate has incorrect timezone offsets

2014-11-05 Thread Daniel Dai (JIRA)
[ https://issues.apache.org/jira/browse/PIG-4267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14199877#comment-14199877 ] Daniel Dai commented on PIG-4267: - There are bunch of tests still using old style: TestOrder

[jira] [Commented] (PIG-4267) ToDate has incorrect timezone offsets

2014-11-05 Thread Brian Johnson (JIRA)
[ https://issues.apache.org/jira/browse/PIG-4267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14198419#comment-14198419 ] Brian Johnson commented on PIG-4267: added a test to the patch. On another note, it seem

[jira] [Commented] (PIG-4267) ToDate has incorrect timezone offsets

2014-11-04 Thread Brian Johnson (JIRA)
[ https://issues.apache.org/jira/browse/PIG-4267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14197623#comment-14197623 ] Brian Johnson commented on PIG-4267: Yea, I guess I was focused on DST start/stop dates

[jira] [Commented] (PIG-4267) ToDate has incorrect timezone offsets

2014-11-04 Thread Rohini Palaniswamy (JIRA)
[ https://issues.apache.org/jira/browse/PIG-4267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14197426#comment-14197426 ] Rohini Palaniswamy commented on PIG-4267: - bq. As far as test cases go, I can't. The

[jira] [Commented] (PIG-4267) ToDate has incorrect timezone offsets

2014-11-04 Thread Brian Johnson (JIRA)
[ https://issues.apache.org/jira/browse/PIG-4267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14197391#comment-14197391 ] Brian Johnson commented on PIG-4267: I'm going to try to add a little better explanation

[jira] [Commented] (PIG-4267) ToDate has incorrect timezone offsets

2014-11-04 Thread Brian Johnson (JIRA)
[ https://issues.apache.org/jira/browse/PIG-4267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14197382#comment-14197382 ] Brian Johnson commented on PIG-4267: The issue is that for a given date, whether it is E

[jira] [Commented] (PIG-4267) ToDate has incorrect timezone offsets

2014-11-04 Thread Brian Johnson (JIRA)
[ https://issues.apache.org/jira/browse/PIG-4267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14197381#comment-14197381 ] Brian Johnson commented on PIG-4267: I can tell you the only impact I saw and we have a

[jira] [Commented] (PIG-4267) ToDate has incorrect timezone offsets

2014-11-04 Thread Rohini Palaniswamy (JIRA)
[ https://issues.apache.org/jira/browse/PIG-4267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14197362#comment-14197362 ] Rohini Palaniswamy commented on PIG-4267: - Timezones and dates are always tricky.

[jira] [Commented] (PIG-4267) ToDate has incorrect timezone offsets

2014-11-04 Thread Rohini Palaniswamy (JIRA)
[ https://issues.apache.org/jira/browse/PIG-4267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14197353#comment-14197353 ] Rohini Palaniswamy commented on PIG-4267: - bq. It appears that pig is using the curr

[jira] [Commented] (PIG-4267) ToDate has incorrect timezone offsets

2014-11-04 Thread Brian Johnson (JIRA)
[ https://issues.apache.org/jira/browse/PIG-4267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14196787#comment-14196787 ] Brian Johnson commented on PIG-4267: Yes, I did and I tested the patch and it fixes the

[jira] [Commented] (PIG-4267) ToDate has incorrect timezone offsets

2014-11-04 Thread Daniel Dai (JIRA)
[ https://issues.apache.org/jira/browse/PIG-4267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14196751#comment-14196751 ] Daniel Dai commented on PIG-4267: - Did you set "pig.datetime.default.tz" explicitly? If it i

[jira] [Commented] (PIG-4267) ToDate has incorrect timezone offsets

2014-11-04 Thread Brian Johnson (JIRA)
[ https://issues.apache.org/jira/browse/PIG-4267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14196654#comment-14196654 ] Brian Johnson commented on PIG-4267: I submitted a patch but there is not test because t

[jira] [Commented] (PIG-4267) ToDate has incorrect timezone offsets

2014-11-04 Thread Brian Johnson (JIRA)
[ https://issues.apache.org/jira/browse/PIG-4267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14196573#comment-14196573 ] Brian Johnson commented on PIG-4267: I guess a test for this would have to check to see

[jira] [Commented] (PIG-4267) ToDate has incorrect timezone offsets

2014-11-04 Thread Brian Johnson (JIRA)
[ https://issues.apache.org/jira/browse/PIG-4267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14196550#comment-14196550 ] Brian Johnson commented on PIG-4267: Ok, I believe this is the source of the problem. Th

[jira] [Commented] (PIG-4267) ToDate has incorrect timezone offsets

2014-11-04 Thread Brian Johnson (JIRA)
[ https://issues.apache.org/jira/browse/PIG-4267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14196403#comment-14196403 ] Brian Johnson commented on PIG-4267: It appears that basically all of Pig's timezone sup

[jira] [Commented] (PIG-4267) ToDate has incorrect timezone offsets

2014-11-04 Thread Brian Johnson (JIRA)
[ https://issues.apache.org/jira/browse/PIG-4267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14196387#comment-14196387 ] Brian Johnson commented on PIG-4267: it appears that pig is using the current offset rat

[jira] [Commented] (PIG-4267) ToDate has incorrect timezone offsets

2014-11-04 Thread Brian Johnson (JIRA)
[ https://issues.apache.org/jira/browse/PIG-4267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14196359#comment-14196359 ] Brian Johnson commented on PIG-4267: ran the jre timezone update tool to get the latest