[jira] [Commented] (PIG-5318) Unit test failures on Pig on Spark with Spark 2.2

[ https://issues.apache.org/jira/browse/PIG-5318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16289058#comment-16289058 ] Adam Szita commented on PIG-5318: - [~nkollar], +1 for [^PIG-5318_6.patch], committed to trun

[jira] [Commented] (PIG-5318) Unit test failures on Pig on Spark with Spark 2.2

[ https://issues.apache.org/jira/browse/PIG-5318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16285663#comment-16285663 ] Nandor Kollar commented on PIG-5318: [~rohini] indeed, it is internal, but I think check

[jira] [Commented] (PIG-5318) Unit test failures on Pig on Spark with Spark 2.2

[ https://issues.apache.org/jira/browse/PIG-5318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16284463#comment-16284463 ] Rohini Palaniswamy commented on PIG-5318: - +1 on the patch from my side. bq. found

[jira] [Commented] (PIG-5318) Unit test failures on Pig on Spark with Spark 2.2

[ https://issues.apache.org/jira/browse/PIG-5318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16283321#comment-16283321 ] Nandor Kollar commented on PIG-5318: Attached PIG-5318_6.patch, found an universal way t

[jira] [Commented] (PIG-5318) Unit test failures on Pig on Spark with Spark 2.2

[ https://issues.apache.org/jira/browse/PIG-5318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16283255#comment-16283255 ] Nandor Kollar commented on PIG-5318: [~kellyzly] thanks for the explanation, in this cas

[jira] [Commented] (PIG-5318) Unit test failures on Pig on Spark with Spark 2.2

[ https://issues.apache.org/jira/browse/PIG-5318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16283023#comment-16283023 ] liyunzhang commented on PIG-5318: - [~nkollar]: testKeepGoingFailed is excluded because of S

[jira] [Commented] (PIG-5318) Unit test failures on Pig on Spark with Spark 2.2

[ https://issues.apache.org/jira/browse/PIG-5318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16281815#comment-16281815 ] Nandor Kollar commented on PIG-5318: Attached PIG-5318_5.patch which includes fix for Te

[jira] [Commented] (PIG-5318) Unit test failures on Pig on Spark with Spark 2.2

[ https://issues.apache.org/jira/browse/PIG-5318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16281694#comment-16281694 ] Nandor Kollar commented on PIG-5318: Created PIG-5319 to address TestStoreInstances fail

[jira] [Commented] (PIG-5318) Unit test failures on Pig on Spark with Spark 2.2

[ https://issues.apache.org/jira/browse/PIG-5318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16280635#comment-16280635 ] Rohini Palaniswamy commented on PIG-5318: - bq. Should we open a separate Jira for fi

[jira] [Commented] (PIG-5318) Unit test failures on Pig on Spark with Spark 2.2

[ https://issues.apache.org/jira/browse/PIG-5318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16280419#comment-16280419 ] Nandor Kollar commented on PIG-5318: [~rohini] I agree, this looks like a hacky solution

[jira] [Commented] (PIG-5318) Unit test failures on Pig on Spark with Spark 2.2

[ https://issues.apache.org/jira/browse/PIG-5318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16277122#comment-16277122 ] Rohini Palaniswamy commented on PIG-5318: - bq. it looks like the way I wanted to tel

[jira] [Commented] (PIG-5318) Unit test failures on Pig on Spark with Spark 2.2

[ https://issues.apache.org/jira/browse/PIG-5318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16277120#comment-16277120 ] Rohini Palaniswamy commented on PIG-5318: - bq. but how about modifying PigOutputform

[jira] [Commented] (PIG-5318) Unit test failures on Pig on Spark with Spark 2.2

[ https://issues.apache.org/jira/browse/PIG-5318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16276747#comment-16276747 ] Nandor Kollar commented on PIG-5318: Attached PIG-5318_4.patch, it looks like the way I

[jira] [Commented] (PIG-5318) Unit test failures on Pig on Spark with Spark 2.2

[ https://issues.apache.org/jira/browse/PIG-5318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16276557#comment-16276557 ] Nandor Kollar commented on PIG-5318: bq. You should just do isSpark2_x (sparkVersion.sta

[jira] [Commented] (PIG-5318) Unit test failures on Pig on Spark with Spark 2.2

[ https://issues.apache.org/jira/browse/PIG-5318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16274766#comment-16274766 ] Rohini Palaniswamy commented on PIG-5318: - You should just do isSpark2_x (sparkVersi

[jira] [Commented] (PIG-5318) Unit test failures on Pig on Spark with Spark 2.2

[ https://issues.apache.org/jira/browse/PIG-5318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16274385#comment-16274385 ] Nandor Kollar commented on PIG-5318: Attached PIG-5318_2.patch, I addressed Rohini's com

[jira] [Commented] (PIG-5318) Unit test failures on Pig on Spark with Spark 2.2

[ https://issues.apache.org/jira/browse/PIG-5318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16272501#comment-16272501 ] Nandor Kollar commented on PIG-5318: Thanks [~rohini] and [~kellyzly] for your review! H

[jira] [Commented] (PIG-5318) Unit test failures on Pig on Spark with Spark 2.2

[ https://issues.apache.org/jira/browse/PIG-5318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16271998#comment-16271998 ] liyunzhang commented on PIG-5318: - [~nkollar]: thanks for working on it. thanks [~rohini] 's

[jira] [Commented] (PIG-5318) Unit test failures on Pig on Spark with Spark 2.2

[ https://issues.apache.org/jira/browse/PIG-5318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16271252#comment-16271252 ] Rohini Palaniswamy commented on PIG-5318: - Few Comments: 1) TestStoreBase - P

[jira] [Commented] (PIG-5318) Unit test failures on Pig on Spark with Spark 2.2

[ https://issues.apache.org/jira/browse/PIG-5318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16270990#comment-16270990 ] Nandor Kollar commented on PIG-5318: [~szita], [~kellyzly] could you please have review?