Store size in bytes (not mbytes) in ResourceStatistics
------------------------------------------------------

                 Key: PIG-2582
                 URL: https://issues.apache.org/jira/browse/PIG-2582
             Project: Pig
          Issue Type: Bug
            Reporter: Travis Crawford
            Priority: Minor


In 
[ResourceStatistics.java|http://svn.apache.org/viewvc/pig/trunk/src/org/apache/pig/ResourceStatistics.java?view=markup]
 we see mBytes is public, and has a public getter/setter.

{code}
47          public Long mBytes; // size in megabytes

196         public Long getmBytes() {
197             return mBytes;
198         }
199         public ResourceStatistics setmBytes(Long mBytes) {
200             this.mBytes = mBytes;
201             return this;
202         }
{code}

Typically sizes are stored as bytes, potentially having convenience functions 
to return with different units.

If mBytes can be marked private without causing woes it might be worth storing 
size as bytes instead.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to