Re: Adding new test cases to TestBuiltin.java

2012-10-30 Thread Alan Gates
On Oct 30, 2012, at 2:43 PM, Cheolsoo Park wrote: > Hi all, > > While reviewing PIG-2881 (Add SUBTRACT eval func), I had 2 questions: > > 1) How do we decide whether an eval func be a built-in func? For example, > should SUBTRACT be added to the o.a.pig.builtin or piggybank? The question here

Re: Adding new test cases to TestBuiltin.java

2012-10-30 Thread Julien Le Dem
When adding a udf (say package.MyUDF) or any other class the test should be named after the class in the same package (package.TestMyUDF) in the test folder. All new tests should follow this pattern. It's not always 1-1 Class - TestClass but that should be the general idea Julien On Tue, Oct 30, 2

Adding new test cases to TestBuiltin.java

2012-10-30 Thread Cheolsoo Park
Hi all, While reviewing PIG-2881 (Add SUBTRACT eval func), I had 2 questions: 1) How do we decide whether an eval func be a built-in func? For example, should SUBTRACT be added to the o.a.pig.builtin or piggybank? 2) Do we want to continue to add test cases to TestBuiltin.java for new built-in ev