Re: Review Request: PIG-3015 Rewrite of AvroStorage

2013-05-20 Thread Joseph Adler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8104/ --- (Updated May 20, 2013, 4:39 p.m.) Review request for pig and Cheolsoo Park. Ch

Re: Review Request: PIG-3015 Rewrite of AvroStorage

2013-05-20 Thread Joseph Adler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8104/ --- (Updated May 20, 2013, 4:38 p.m.) Review request for pig and Cheolsoo Park. De

Re: Review Request: PIG-3015 Rewrite of AvroStorage

2013-05-20 Thread Joseph Adler
> On March 19, 2013, 4:40 p.m., Jonathan Coveney wrote: > > src/org/apache/pig/builtin/AvroStorage.java, line 352 > > > > > > I realize using Long's compareTo is convenient, but this seems like > > unnecessary boxing.

Re: Review Request: PIG-3015 Rewrite of AvroStorage

2013-03-19 Thread Jonathan Coveney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8104/#review18077 --- src/org/apache/pig/builtin/AvroStorage.java

Re: Review Request: PIG-3015 Rewrite of AvroStorage

2013-01-04 Thread Joseph Adler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8104/ --- (Updated Jan. 4, 2013, 7:22 p.m.) Review request for pig and Cheolsoo Park. De

Re: Review Request: PIG-3015 Rewrite of AvroStorage

2013-01-04 Thread Joseph Adler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8104/ --- (Updated Jan. 4, 2013, 7:22 p.m.) Review request for pig and Cheolsoo Park. Ch

Re: Review Request: PIG-3015 Rewrite of AvroStorage

2012-12-20 Thread Joseph Adler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8104/ --- (Updated Dec. 20, 2012, 5:24 p.m.) Review request for pig and Cheolsoo Park. C

Re: Review Request: PIG-3015 Rewrite of AvroStorage

2012-12-17 Thread Joseph Adler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8104/ --- (Updated Dec. 17, 2012, 7:36 p.m.) Review request for pig and Cheolsoo Park. C

Re: Review Request: PIG-3015 Rewrite of AvroStorage

2012-12-05 Thread Joseph Adler
> On Dec. 3, 2012, 7:22 p.m., Cheolsoo Park wrote: > > Overall looks great! I haven't gone through the test cases yet, but here > > are my comments so far. > > > > > > 1) I noticed that I cannot load .avro files that are not record types. For > > example, I tried to load a .avro file whose sc

Re: Review Request: PIG-3015 Rewrite of AvroStorage

2012-12-03 Thread Joseph Adler
> On Dec. 3, 2012, 7:22 p.m., Cheolsoo Park wrote: > > src/org/apache/pig/builtin/AvroStorage.java, lines 171-172 > > > > > > Same problem as above. Fixing this one within getAvroSchema > On Dec. 3, 2012, 7:22 p.m.,

Re: Review Request: PIG-3015 Rewrite of AvroStorage

2012-12-03 Thread Cheolsoo Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8104/#review13962 --- Overall looks great! I haven't gone through the test cases yet, but h

Review Request: PIG-3015 Rewrite of AvroStorage

2012-11-16 Thread Joseph Adler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8104/ --- Review request for pig and Cheolsoo Park. Description --- The current AvroS