Re: Review Request: disable optimizations via pig properties

2013-05-15 Thread Travis Crawford
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11032/ --- (Updated May 16, 2013, 12:07 a.m.) Review request for pig, Julien Le Dem, Bill

Re: Review Request: disable optimizations via pig properties

2013-05-14 Thread Julien Le Dem
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11032/#review20548 --- Ship it! Looks good. I don't feel strongly about the prevalidator

Re: Review Request: disable optimizations via pig properties

2013-05-14 Thread Bill Graham
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11032/#review20545 --- Ship it! My concerns have been addresses. Thanks! - Bill Graham

Re: Review Request: disable optimizations via pig properties

2013-05-14 Thread Travis Crawford
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11032/ --- (Updated May 14, 2013, 5:23 p.m.) Review request for pig, Julien Le Dem, Bill G

Re: Review Request: disable optimizations via pig properties

2013-05-14 Thread Julien Le Dem
> On May 13, 2013, 11:23 p.m., Julien Le Dem wrote: > > src/org/apache/pig/PigConstants.java, lines 47-51 > > > > > > I would like to clearly separate keys for pig.properties from others in > > there. > > > >

Re: Review Request: disable optimizations via pig properties

2013-05-14 Thread Bill Graham
> On May 13, 2013, 11:35 p.m., Bill Graham wrote: > > src/docs/src/documentation/content/xdocs/perf.xml, line 493 > > > > > > Would you please specify that setting this value in both the pig > > properties file and th

Re: Review Request: disable optimizations via pig properties

2013-05-13 Thread Travis Crawford
> On May 13, 2013, 11:35 p.m., Bill Graham wrote: > > src/docs/src/documentation/content/xdocs/perf.xml, line 493 > > > > > > Would you please specify that setting this value in both the pig > > properties file and th

Re: Review Request: disable optimizations via pig properties

2013-05-13 Thread Bill Graham
> On May 13, 2013, 11:35 p.m., Bill Graham wrote: > > src/docs/src/documentation/content/xdocs/perf.xml, line 493 > > > > > > Would you please specify that setting this value in both the pig > > properties file and th

Re: Review Request: disable optimizations via pig properties

2013-05-13 Thread Travis Crawford
> On May 13, 2013, 11:35 p.m., Bill Graham wrote: > > src/docs/src/documentation/content/xdocs/perf.xml, line 493 > > > > > > Would you please specify that setting this value in both the pig > > properties file and th

Re: Review Request: disable optimizations via pig properties

2013-05-13 Thread Bill Graham
> On May 13, 2013, 11:35 p.m., Bill Graham wrote: > > src/docs/src/documentation/content/xdocs/perf.xml, line 493 > > > > > > Would you please specify that setting this value in both the pig > > properties file and th

Re: Review Request: disable optimizations via pig properties

2013-05-13 Thread Travis Crawford
> On May 13, 2013, 11:35 p.m., Bill Graham wrote: > > src/docs/src/documentation/content/xdocs/perf.xml, line 493 > > > > > > Would you please specify that setting this value in both the pig > > properties file and th

Re: Review Request: disable optimizations via pig properties

2013-05-13 Thread Travis Crawford
> On May 13, 2013, 11:23 p.m., Julien Le Dem wrote: > > src/org/apache/pig/newplan/logical/optimizer/LogicalPlanOptimizer.java, > > line 215 > > > > > > would checkNotNull(ruleSet, "ruleSet") give a better error messa

Re: Review Request: disable optimizations via pig properties

2013-05-13 Thread Travis Crawford
> On May 13, 2013, 11:23 p.m., Julien Le Dem wrote: > > src/org/apache/pig/PigConstants.java, lines 47-51 > > > > > > I would like to clearly separate keys for pig.properties from others in > > there. > > > >

Re: Review Request: disable optimizations via pig properties

2013-05-13 Thread Bill Graham
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11032/#review20516 --- src/docs/src/documentation/content/xdocs/perf.xml

Re: Review Request: disable optimizations via pig properties

2013-05-13 Thread Julien Le Dem
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11032/#review20514 --- Overall, this looks good. Some comments bellow src/org/apache/pig/

Re: Review Request: disable optimizations via pig properties

2013-05-13 Thread Travis Crawford
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11032/#review20501 --- Tested disabling this rule in three ways: PIG_CONF_DIR=/etc/pig/con

Re: Review Request: disable optimizations via pig properties

2013-05-13 Thread Travis Crawford
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11032/ --- (Updated May 13, 2013, 8:35 p.m.) Review request for pig, Julien Le Dem, Bill G

Re: Review Request: disable optimizations via pig properties

2013-05-10 Thread Travis Crawford
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11032/#review20427 --- Julien raised a good question asking if "set" in the script works be

Re: Review Request: disable optimizations via pig properties

2013-05-09 Thread Bill Graham
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11032/#review20406 --- Ship it! Looks good to me. Way to be #prostyle with including the d

Review Request: disable optimizations via pig properties

2013-05-09 Thread Travis Crawford
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11032/ --- Review request for pig, Julien Le Dem, Bill Graham, and Feng Peng. Description