Re: Review Request 14274: PIG-2672 Optimize the use of DistributedCache

2014-02-03 Thread Rohini Palaniswamy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14274/#review33508 --- Ship it! Ship It! - Rohini Palaniswamy On Feb. 3, 2014, 9:43 p.m

Re: Review Request 14274: PIG-2672 Optimize the use of DistributedCache

2014-02-03 Thread Aniket Mokashi
> On Feb. 3, 2014, 9:24 p.m., Rohini Palaniswamy wrote: > > trunk/src/org/apache/pig/PigConfiguration.java, line 167 > > > > > > This is never used in getCacheStagingDir Sorry, I accidentally reverted wrong changes be

Re: Review Request 14274: PIG-2672 Optimize the use of DistributedCache

2014-02-03 Thread Aniket Mokashi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14274/ --- (Updated Feb. 3, 2014, 9:43 p.m.) Review request for pig, Cheolsoo Park, Daniel

Re: Review Request 14274: PIG-2672 Optimize the use of DistributedCache

2014-02-03 Thread Rohini Palaniswamy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14274/#review33503 --- trunk/src/org/apache/pig/PigConfiguration.java

Re: Review Request 14274: PIG-2672 Optimize the use of DistributedCache

2014-02-02 Thread Aniket Mokashi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14274/ --- (Updated Feb. 3, 2014, 7:16 a.m.) Review request for pig, Cheolsoo Park, Daniel

Re: Review Request 14274: PIG-2672 Optimize the use of DistributedCache

2014-02-02 Thread Aniket Mokashi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14274/ --- (Updated Feb. 3, 2014, 7:02 a.m.) Review request for pig, Cheolsoo Park, Daniel

Re: Review Request 14274: PIG-2672 Optimize the use of DistributedCache

2014-02-02 Thread Rohini Palaniswamy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14274/#review33391 --- trunk/src/org/apache/pig/backend/hadoop/executionengine/mapReduceLa

Re: Review Request 14274: PIG-2672 Optimize the use of DistributedCache

2014-01-30 Thread Aniket Mokashi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14274/ --- (Updated Jan. 31, 2014, 1:23 a.m.) Review request for pig, Cheolsoo Park, Danie

Re: Review Request 14274: PIG-2672 Optimize the use of DistributedCache

2013-09-25 Thread Aniket Mokashi
> On Sept. 25, 2013, 12:13 a.m., Rohini Palaniswamy wrote: > > trunk/src/org/apache/pig/backend/hadoop/executionengine/mapReduceLayer/JobControlCompiler.java, > > line 1492 > > > > > > If hdfs path use as is and do n

Re: Review Request 14274: PIG-2672 Optimize the use of DistributedCache

2013-09-25 Thread Aniket Mokashi
> On Sept. 24, 2013, 6:30 a.m., Cheolsoo Park wrote: > > trunk/test/org/apache/pig/test/TestJobControlCompiler.java, line 161 > > > > > > The following line is missing in the RB diff but it's in the attached > > the p

Re: Review Request 14274: PIG-2672 Optimize the use of DistributedCache

2013-09-24 Thread Daniel Dai
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14274/#review26370 --- trunk/src/org/apache/pig/backend/hadoop/executionengine/mapReduceLa

Re: Review Request 14274: PIG-2672 Optimize the use of DistributedCache

2013-09-24 Thread Rohini Palaniswamy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14274/#review26369 --- trunk/src/org/apache/pig/backend/hadoop/executionengine/mapReduceLa

Re: Review Request 14274: PIG-2672 Optimize the use of DistributedCache

2013-09-24 Thread Rohini Palaniswamy
> On Sept. 25, 2013, 12:13 a.m., Rohini Palaniswamy wrote: > > trunk/src/org/apache/pig/backend/hadoop/executionengine/mapReduceLayer/JobControlCompiler.java, > > line 1495 > > > > > > Since the name of the file on h

Re: Review Request 14274: PIG-2672 Optimize the use of DistributedCache

2013-09-24 Thread Rohini Palaniswamy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14274/#review26364 --- There are some white spaces in the patch and code is not formatted.

Re: Review Request 14274: PIG-2672 Optimize the use of DistributedCache

2013-09-23 Thread Cheolsoo Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14274/#review26342 --- trunk/src/org/apache/pig/PigConstants.java

Review Request 14274: PIG-2672 Optimize the use of DistributedCache

2013-09-20 Thread Aniket Mokashi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14274/ --- Review request for pig, Cheolsoo Park, DanielWX DanielWX, Dmitriy Ryaboy, Julien