Re: Review Request 20973: PIG-3914: Change TaskContext to abstract class

2014-05-01 Thread Rohini Palaniswamy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20973/#review41978 --- Ship it! Ship It! - Rohini Palaniswamy On May 1, 2014, 9:01 p.m.

Re: Review Request 20973: PIG-3914: Change TaskContext to abstract class

2014-05-01 Thread Cheolsoo Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20973/ --- (Updated May 1, 2014, 9:01 p.m.) Review request for pig, Daniel Dai and Rohini

Re: Review Request 20973: PIG-3914: Change TaskContext to abstract class

2014-05-01 Thread Cheolsoo Park
> On May 1, 2014, 8:09 p.m., Rohini Palaniswamy wrote: > > src/org/apache/pig/backend/hadoop/executionengine/mapReduceLayer/MRTaskContext.java, > > line 57 > > > > > > In what case would counter be null after a getCoun

Re: Review Request 20973: PIG-3914: Change TaskContext to abstract class

2014-05-01 Thread Rohini Palaniswamy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20973/#review41939 --- Few comments already in jira. src/org/apache/pig/backend/hadoop/ex

Review Request 20973: PIG-3914: Change TaskContext to abstract class

2014-05-01 Thread Cheolsoo Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20973/ --- Review request for pig, Daniel Dai and Rohini Palaniswamy. Bugs: PIG-3914 h