Re: Review Request 32036: PIG-4422: Implement visitMergeJoin in SparkCompiler

2015-03-27 Thread Mohit Sabharwal
On March 27, 2015, 8:02 p.m., Mohit Sabharwal wrote: Thanks, Praveen! Looks good to me. I have some comments about error handling. Any idea why some merge join tests are still failing after this patch ? - Mohit --- This is an

Re: Review Request 32036: PIG-4422: Implement visitMergeJoin in SparkCompiler

2015-03-27 Thread Mohit Sabharwal
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32036/#review78099 --- Thanks, Praveen! Looks good to me. I have some comments about error

Review Request 32036: PIG-4422: Implement visitMergeJoin in SparkCompiler

2015-03-13 Thread Praveen Rachabattuni
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32036/ --- Review request for pig, liyun zhang and Mohit Sabharwal. Bugs: PIG-4422