Re: Review Request 57317: Support Pig On Spark

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57317/#review176246 --- Ship it! Ship It! - Rohini Palaniswamy On May 26, 2017,

Re: Review Request 57317: Support Pig On Spark

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57317/#review176211 --- Fix it, then Ship it! Just a minor comment. Fix that in the

Re: Review Request 57317: Support Pig On Spark

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57317/ --- (Updated May 26, 2017, 7:37 a.m.) Review request for pig, Daniel Dai and

Re: Review Request 57317: Support Pig On Spark

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57317/ --- (Updated May 25, 2017, 2:03 p.m.) Review request for pig, Daniel Dai and

Re: Review Request 57317: Support Pig On Spark

> On May 24, 2017, 8:55 p.m., Rohini Palaniswamy wrote: > > test/e2e/pig/tests/nightly.conf > > Lines 2307 (patched) > > > > > > Testing distinct + orderby + limit serves the same purpose as orderby + > > limit

Re: Review Request 57317: Support Pig On Spark

> On May 24, 2017, 8:55 p.m., Rohini Palaniswamy wrote: > > src/org/apache/pig/backend/hadoop/executionengine/spark/SparkPigContext.java > > Lines 51 (patched) > > > > > > Shouldn't default parallelism returned if

Re: Review Request 57317: Support Pig On Spark

> On March 21, 2017, 8:36 p.m., Rohini Palaniswamy wrote: > > src/org/apache/pig/backend/hadoop/executionengine/spark/SparkLauncher.java > > Lines 179 (patched) > > > > > > You can reuse ScriptState id

Re: Review Request 57317: Support Pig On Spark

> On March 21, 2017, 8:36 p.m., Rohini Palaniswamy wrote: > > src/org/apache/pig/backend/hadoop/executionengine/spark/SparkLauncher.java > > Lines 387-388 (patched) > > > > > > Why copy to local directory if already

Re: Review Request 57317: Support Pig On Spark

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57317/#review175872 ---

Re: Review Request 57317: Support Pig On Spark

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57317/ --- (Updated May 18, 2017, 8:06 a.m.) Review request for pig, Daniel Dai and

Re: Review Request 57317: Support Pig On Spark

> On March 21, 2017, 8:36 p.m., Rohini Palaniswamy wrote: > > src/org/apache/pig/backend/hadoop/executionengine/spark/SparkLauncher.java > > Lines 302 (patched) > > > > > > Why do we have to delete ship files and

Re: Review Request 57317: Support Pig On Spark

> On March 24, 2017, 4:14 a.m., Rohini Palaniswamy wrote: > > src/org/apache/pig/backend/hadoop/executionengine/spark/SparkEngineConf.java > > Lines 49-51 (patched) > > > > > > Why do we need these settings with

Re: Review Request 57317: Support Pig On Spark

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57317/ --- (Updated April 21, 2017, 5:31 a.m.) Review request for pig, Daniel Dai and

Re: Review Request 57317: Support Pig On Spark

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57317/ --- (Updated April 2, 2017, 7:05 p.m.) Review request for pig, Daniel Dai and

Re: Review Request 57317: Support Pig On Spark

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57317/#review170811 ---

Re: Review Request 57317: Support Pig On Spark

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57317/#review170268 ---

Re: Review Request 57317: Support Pig On Spark

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57317/ --- (Updated March 25, 2017, 7:38 p.m.) Review request for pig, Daniel Dai and

Re: Review Request 57317: Support Pig On Spark

> On March 21, 2017, 8:36 p.m., Rohini Palaniswamy wrote: > > src/org/apache/pig/backend/hadoop/executionengine/spark/JobMetricsListener.java > > Lines 97 (patched) > > > > > > Why capture metrics at task level? Pig

Re: Review Request 57317: Support Pig On Spark

> On March 21, 2017, 8:36 p.m., Rohini Palaniswamy wrote: > > src/org/apache/pig/backend/hadoop/executionengine/spark/KryoSerializer.java > > Lines 58 (patched) > > > > > > serializeJobConf and deserialize do not use

Re: Review Request 57317: Support Pig On Spark

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57317/#review169547 --- Review for page 2

Re: Review Request 57317: Support Pig On Spark

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57317/ --- (Updated March 17, 2017, 6:35 a.m.) Review request for pig, Daniel Dai and

Re: Review Request 57317: Support Pig On Spark

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57317/ --- (Updated March 17, 2017, 6:22 a.m.) Review request for pig, Daniel Dai and

Re: Review Request 57317: Support Pig On Spark

> On March 14, 2017, 9:24 p.m., Rohini Palaniswamy wrote: > > bin/pig > > Lines 414 (patched) > > > > > > TODO for later - New jira to add support for spark.yarn.archive Have filed "PIG-5189: suport

Re: Review Request 57317: Support Pig On Spark

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57317/#review168935 --- Review comments for Page 1 bin/pig Lines 61-62 (patched)

Review Request 57317: Support Pig On Spark

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57317/ --- Review request for pig, Daniel Dai and Rohini Palaniswamy. Bugs: PIG-4059 and