I agree that we should use the RB more often.
On Wed, Jun 5, 2013 at 6:50 PM, Jarek Jarcec Cecho jar...@apache.orgwrote:
I can definitely recommend using the review board. We are using it already
in all other projects that I'm participating and it's really helping us out.
Jarcec
On Wed,
+1
On Wed, Jun 5, 2013 at 11:53 PM, Cheolsoo Park piaozhe...@gmail.com wrote:
I agree that we should use the RB more often.
On Wed, Jun 5, 2013 at 6:50 PM, Jarek Jarcec Cecho jar...@apache.orgwrote:
I can definitely recommend using the review board. We are using it already
in all other
I think it's fine for a reviewer to ask for a particular patch to be put in
review board. I think it would also be fine to put in our HowToContribute doc
that for larger patches putting it in review board may help get it reviewed
more quickly. I'm not in favor of requiring it, as some
Hi,
Reviewing uploaded patches for few lines of change is easy. But when
the change is more it is hard to read, review is more time consuming and at
times you have to switch between the patch and eclipse to get more context.
Without the surrounding code it is also easy to miss things on
I can definitely recommend using the review board. We are using it already in
all other projects that I'm participating and it's really helping us out.
Jarcec
On Wed, Jun 05, 2013 at 06:21:32PM -0700, Rohini Palaniswamy wrote:
Hi,
Reviewing uploaded patches for few lines of change is