[GitHub] codecov-io edited a comment on issue #3740: Fix controller/server/broker admin console

2019-01-23 Thread GitBox
codecov-io edited a comment on issue #3740: Fix controller/server/broker admin console URL: https://github.com/apache/incubator-pinot/pull/3740#issuecomment-457096542 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/3740?src=pr=h1) Report > :exclamation: No coverage

[GitHub] codecov-io commented on issue #3740: Fix controller/server/broker admin console

2019-01-23 Thread GitBox
codecov-io commented on issue #3740: Fix controller/server/broker admin console URL: https://github.com/apache/incubator-pinot/pull/3740#issuecomment-457096542 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/3740?src=pr=h1) Report > :exclamation: No coverage uploaded for

Re: Requesting a review for updating license & notice information

2019-01-23 Thread Seunghyun Lee
Thank you for the update. So, I think that we have 2 options. 1. Copy all licenses directly to "LICENSE" file. 2. Copy all licenses to "/licenses" and add a pointer to LICENSE file. In that case, I think the current pr should be good enough (I also separated out LICENSE-binary and

[GitHub] sunithabeeram opened a new pull request #3740: Fix controller/server/broker admin console

2019-01-23 Thread GitBox
sunithabeeram opened a new pull request #3740: Fix controller/server/broker admin console URL: https://github.com/apache/incubator-pinot/pull/3740 Recent upgrade to jersey-2.28-RC4 left the pinot admin consoles broken, with errors similar to: "Resource identified by path '/query', does

Re: Requesting a review for updating license & notice information

2019-01-23 Thread Felix Cheung
Actually I’m going to retract the whole thing I said. Seems like it should carry it under license for: https://github.com/apache/spark/commit/bf4199e261c3c8dd2970e2a154c97b46fb339f02 From: Felix Cheung Sent: Wednesday, January 23, 2019 9:20 PM To:

Re: Requesting a review for updating license & notice information

2019-01-23 Thread Felix Cheung
Hi - I believe it’s ok not to include standard passive license too. I think I could some pointer on that in the PR where we discussed. From: kishore g Sent: Wednesday, January 23, 2019 9:18 PM To: dev@pinot.apache.org Subject: Re: Requesting a review for

Re: Requesting a review for updating license & notice information

2019-01-23 Thread kishore g
I think that should work. Olivier, do you see any issues with that? On Wed, Jan 23, 2019 at 5:51 PM Seunghyun Lee wrote: > Hi Felix and Kishore, > > Can you guys confirm that if I can remove copied license files for MIT, BSD > based on

[GitHub] codecov-io commented on issue #3738: Update Pinot admin webpages with right references

2019-01-23 Thread GitBox
codecov-io commented on issue #3738: Update Pinot admin webpages with right references URL: https://github.com/apache/incubator-pinot/pull/3738#issuecomment-457036820 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/3738?src=pr=h1) Report > :exclamation: No coverage

Re: Requesting a review for updating license & notice information

2019-01-23 Thread Seunghyun Lee
Hi Felix and Kishore, Can you guys confirm that if I can remove copied license files for MIT, BSD based on http://www.apache.org/dev/licensing-howto.html#permissive-deps ? My understanding from the above document is that for MIT, BSD dependencies, it is sufficient to add pointers in LICENSE

[GitHub] Jackie-Jiang opened a new pull request #3739: Auto-reformat all java source files

2019-01-23 Thread GitBox
Jackie-Jiang opened a new pull request #3739: Auto-reformat all java source files URL: https://github.com/apache/incubator-pinot/pull/3739 Use Intellij to reformat all java source files (no code change involved) The auto-generated files are not touched After this, we can manually

[GitHub] sunithabeeram opened a new pull request #3738: Update Pinot admin webpages with right references

2019-01-23 Thread GitBox
sunithabeeram opened a new pull request #3738: Update Pinot admin webpages with right references URL: https://github.com/apache/incubator-pinot/pull/3738 This is an automated message from the Apache Git Service. To respond

[GitHub] aaronucsd merged pull request #3737: [TE] aaronucsd/new edit basic yaml editor

2019-01-23 Thread GitBox
aaronucsd merged pull request #3737: [TE] aaronucsd/new edit basic yaml editor URL: https://github.com/apache/incubator-pinot/pull/3737 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] akshayrai merged pull request #3735: [TE] Add Path to the Migration endpoints

2019-01-23 Thread GitBox
akshayrai merged pull request #3735: [TE] Add Path to the Migration endpoints URL: https://github.com/apache/incubator-pinot/pull/3735 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] aaronucsd opened a new pull request #3737: [TE] aaronucsd/new edit basic yaml editor

2019-01-23 Thread GitBox
aaronucsd opened a new pull request #3737: [TE] aaronucsd/new edit basic yaml editor URL: https://github.com/apache/incubator-pinot/pull/3737 This is an automated message from the Apache Git Service. To respond to the

[GitHub] codecov-io commented on issue #3734: Make delete table API async

2019-01-23 Thread GitBox
codecov-io commented on issue #3734: Make delete table API async URL: https://github.com/apache/incubator-pinot/pull/3734#issuecomment-456989526 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/3734?src=pr=h1) Report > Merging

[GitHub] Jackie-Jiang merged pull request #3725: Replace partition ranges with partitions

2019-01-23 Thread GitBox
Jackie-Jiang merged pull request #3725: Replace partition ranges with partitions URL: https://github.com/apache/incubator-pinot/pull/3725 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] Jackie-Jiang commented on a change in pull request #3725: Replace partition ranges with partitions

2019-01-23 Thread GitBox
Jackie-Jiang commented on a change in pull request #3725: Replace partition ranges with partitions URL: https://github.com/apache/incubator-pinot/pull/3725#discussion_r250334872 ## File path: pinot-core/src/main/java/org/apache/pinot/core/query/pruner/PartitionSegmentPruner.java

[GitHub] Jackie-Jiang commented on a change in pull request #3725: Replace partition ranges with partitions

2019-01-23 Thread GitBox
Jackie-Jiang commented on a change in pull request #3725: Replace partition ranges with partitions URL: https://github.com/apache/incubator-pinot/pull/3725#discussion_r250333978 ## File path:

[GitHub] akshayrai opened a new pull request #3735: [TE] Add Path to the Migration endpoints

2019-01-23 Thread GitBox
akshayrai opened a new pull request #3735: [TE] Add Path to the Migration endpoints URL: https://github.com/apache/incubator-pinot/pull/3735 This is an automated message from the Apache Git Service. To respond to the

[GitHub] jackjlli opened a new pull request #3734: Make delete table API async

2019-01-23 Thread GitBox
jackjlli opened a new pull request #3734: Make delete table API async URL: https://github.com/apache/incubator-pinot/pull/3734 Currently the method deleteTable is a synchronized API. And there's no log to measure how long it takes to complete. This PR makes delete table API async so that

[GitHub] Jackie-Jiang merged pull request #3733: Minor fix for star-tree v2 metadata

2019-01-23 Thread GitBox
Jackie-Jiang merged pull request #3733: Minor fix for star-tree v2 metadata URL: https://github.com/apache/incubator-pinot/pull/3733 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] codecov-io edited a comment on issue #3730: Update versions of packages to move to jersey 2.28

2019-01-23 Thread GitBox
codecov-io edited a comment on issue #3730: Update versions of packages to move to jersey 2.28 URL: https://github.com/apache/incubator-pinot/pull/3730#issuecomment-456605862 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/3730?src=pr=h1) Report > Merging