[GitHub] Jackie-Jiang commented on issue #3725: Replace partition ranges with partitions

2019-01-18 Thread GitBox
Jackie-Jiang commented on issue #3725: Replace partition ranges with partitions URL: https://github.com/apache/incubator-pinot/pull/3725#issuecomment-455750311 > What’s the benefit of changing this? What happens if minion merges two segments with different ranges? We treat range as s

[GitHub] Jackie-Jiang commented on issue #3725: Replace partition ranges with partitions

2019-01-19 Thread GitBox
Jackie-Jiang commented on issue #3725: Replace partition ranges with partitions URL: https://github.com/apache/incubator-pinot/pull/3725#issuecomment-455759857 @kishoreg Currently we are storing a list of ranges, which is quite redundant (and not supported when range covers more than 1 valu

[GitHub] Jackie-Jiang commented on issue #3725: Replace partition ranges with partitions

2019-01-19 Thread GitBox
Jackie-Jiang commented on issue #3725: Replace partition ranges with partitions URL: https://github.com/apache/incubator-pinot/pull/3725#issuecomment-455760055 Also, if we use range 1-5 to replace [1,3,5], then when trying to purge segment with partition 2, we will get false negative (segme