[GitHub] Jackie-Jiang commented on issue #3819: Refactor periodic task

2019-02-12 Thread GitBox
Jackie-Jiang commented on issue #3819: Refactor periodic task URL: https://github.com/apache/incubator-pinot/pull/3819#issuecomment-462991869 @npawar Addressed the comments. Periodic task logic is covered by unit test: ControllerPeriodicTask and PeriodicTaskSchedulerTest. For each

[GitHub] Jackie-Jiang commented on issue #3819: Refactor periodic task

2019-02-12 Thread GitBox
Jackie-Jiang commented on issue #3819: Refactor periodic task URL: https://github.com/apache/incubator-pinot/pull/3819#issuecomment-462970857 @sunithabeeram The race condition between start() and stop(), and is addressed by adding synchronization. As for the leader and non-leader