[GitHub] npawar commented on a change in pull request #3819: Refactor periodic task

2019-02-12 Thread GitBox
npawar commented on a change in pull request #3819: Refactor periodic task URL: https://github.com/apache/incubator-pinot/pull/3819#discussion_r256208642 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/periodictask/ControllerPeriodicTask.java

[GitHub] npawar commented on a change in pull request #3819: Refactor periodic task

2019-02-12 Thread GitBox
npawar commented on a change in pull request #3819: Refactor periodic task URL: https://github.com/apache/incubator-pinot/pull/3819#discussion_r256209491 ## File path: pinot-core/src/main/java/org/apache/pinot/core/periodictask/BasePeriodicTask.java ## @@ -42,9 +61,126 @@

[GitHub] npawar commented on a change in pull request #3819: Refactor periodic task

2019-02-12 Thread GitBox
npawar commented on a change in pull request #3819: Refactor periodic task URL: https://github.com/apache/incubator-pinot/pull/3819#discussion_r256209491 ## File path: pinot-core/src/main/java/org/apache/pinot/core/periodictask/BasePeriodicTask.java ## @@ -42,9 +61,126 @@

[GitHub] npawar commented on a change in pull request #3819: Refactor periodic task

2019-02-12 Thread GitBox
npawar commented on a change in pull request #3819: Refactor periodic task URL: https://github.com/apache/incubator-pinot/pull/3819#discussion_r256208642 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/periodictask/ControllerPeriodicTask.java

[GitHub] npawar commented on a change in pull request #3819: Refactor periodic task

2019-02-12 Thread GitBox
npawar commented on a change in pull request #3819: Refactor periodic task URL: https://github.com/apache/incubator-pinot/pull/3819#discussion_r256174360 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/periodictask/ControllerPeriodicTask.java

[GitHub] npawar commented on a change in pull request #3819: Refactor periodic task

2019-02-12 Thread GitBox
npawar commented on a change in pull request #3819: Refactor periodic task URL: https://github.com/apache/incubator-pinot/pull/3819#discussion_r256176671 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/helix/SegmentStatusChecker.java ## @@ -69,58

[GitHub] npawar commented on a change in pull request #3819: Refactor periodic task

2019-02-12 Thread GitBox
npawar commented on a change in pull request #3819: Refactor periodic task URL: https://github.com/apache/incubator-pinot/pull/3819#discussion_r256167332 ## File path: pinot-core/src/main/java/org/apache/pinot/core/periodictask/BasePeriodicTask.java ## @@ -18,20 +18,39 @@

[GitHub] npawar commented on a change in pull request #3819: Refactor periodic task

2019-02-12 Thread GitBox
npawar commented on a change in pull request #3819: Refactor periodic task URL: https://github.com/apache/incubator-pinot/pull/3819#discussion_r256178149 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/minion/PinotTaskManager.java ## @@

[GitHub] npawar commented on a change in pull request #3819: Refactor periodic task

2019-02-12 Thread GitBox
npawar commented on a change in pull request #3819: Refactor periodic task URL: https://github.com/apache/incubator-pinot/pull/3819#discussion_r256172676 ## File path: pinot-core/src/main/java/org/apache/pinot/core/periodictask/BasePeriodicTask.java ## @@ -42,9 +61,126 @@

[GitHub] npawar commented on a change in pull request #3819: Refactor periodic task

2019-02-12 Thread GitBox
npawar commented on a change in pull request #3819: Refactor periodic task URL: https://github.com/apache/incubator-pinot/pull/3819#discussion_r256170073 ## File path: pinot-core/src/main/java/org/apache/pinot/core/periodictask/BasePeriodicTask.java ## @@ -42,9 +61,126 @@

[GitHub] npawar commented on a change in pull request #3819: Refactor periodic task

2019-02-12 Thread GitBox
npawar commented on a change in pull request #3819: Refactor periodic task URL: https://github.com/apache/incubator-pinot/pull/3819#discussion_r256178624 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/periodictask/ControllerPeriodicTask.java