[GitHub] snleee edited a comment on issue #3722: Update LICENSE and NOTICE files

2019-01-28 Thread GitBox
snleee edited a comment on issue #3722: Update LICENSE and NOTICE files URL: https://github.com/apache/incubator-pinot/pull/3722#issuecomment-458420180 @felixcheung The current pr includes the license with MIT and BSD under `/licenses`. I also dealt with `license` vs `license-binary`. If

[GitHub] snleee edited a comment on issue #3722: Update LICENSE and NOTICE files

2019-01-21 Thread GitBox
snleee edited a comment on issue #3722: Update LICENSE and NOTICE files URL: https://github.com/apache/incubator-pinot/pull/3722#issuecomment-456220187 @kishoreg In my understanding, we have 2 approaches. 1. copy license in `/licenses` and point that in `LICENSE` 2. copy license

[GitHub] snleee edited a comment on issue #3722: Update LICENSE and NOTICE files

2019-01-18 Thread GitBox
snleee edited a comment on issue #3722: Update LICENSE and NOTICE files URL: https://github.com/apache/incubator-pinot/pull/3722#issuecomment-455721410 @felixcheung @olamy Can you check this when you find the time? This is

[GitHub] snleee edited a comment on issue #3722: Update LICENSE and NOTICE files

2019-01-18 Thread GitBox
snleee edited a comment on issue #3722: Update LICENSE and NOTICE files URL: https://github.com/apache/incubator-pinot/pull/3722#issuecomment-455720913 After removing category X dependency and removing "pinot-perf" from distribution package, we are bundling `109` external jar files and `9`