[GitHub] incubator-pirk pull request #60: [PIRK-50] -- Update POM for Release

GitHub user ellisonanne opened a pull request: https://github.com/apache/incubator-pirk/pull/60 [PIRK-50] -- Update POM for Release Added the profile information for apache-release so that mvn release would function. It appears that we need to include an additional repo

Re: Release Preparations

Agreed. On Fri, Aug 12, 2016 at 5:59 PM, Suneel Marthi wrote: > I may not be able to get to it today and I think we should go ahead with > the release. > This is not core Pirk functionality per se, its safe to close the PR and > create a Jira to track this for the next

Re: Release Preparations

Keep working it. We could delay the release, but IMO releases should be frequent enough that missing one is not a big deal, and there is no point in delivering function that is not ready yet. Regards, Tim On 12 August 2016 at 22:31, Suneel Marthi wrote: > I have a PR for

Re: Release Preparations

I have a PR for the Coveralls code coverage stuff that's open. The PR doesn't fix the problem and doesn't break anything if it were merged. Please go ahead and merge the PR and prepare for the release. On Fri, Aug 12, 2016 at 12:08 PM, Ellison Anne Williams < eawilliamsp...@gmail.com> wrote: >

[GitHub] incubator-pirk issue #59: [WIP] Add maven plugin for displaying code coverag...

Github user smarthi commented on the issue: https://github.com/apache/incubator-pirk/pull/59 This PR still doesn't fix the report generation, I can either go ahead and merge this PR to the codebase or simply close this PR and fix the code coverage report generation following this

[GitHub] incubator-pirk pull request #59: Add maven plugin for displaying code covera...

GitHub user smarthi opened a pull request: https://github.com/apache/incubator-pirk/pull/59 Add maven plugin for displaying code coverage stats Updated the plugin versions, set the execution phase to 'verify' You can merge this pull request into a Git repository by running: $

[GitHub] incubator-pirk pull request #58: Add maven plugin for displaying code covera...

Github user asfgit closed the pull request at: https://github.com/apache/incubator-pirk/pull/58 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] incubator-pirk issue #57: [PIRK-49] PrimitivePartioner does not account for ...

Github user ellisonanne commented on the issue: https://github.com/apache/incubator-pirk/pull/57 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] incubator-pirk pull request #57: [PIRK-49] PrimitivePartioner does not accou...

Github user smarthi commented on a diff in the pull request: https://github.com/apache/incubator-pirk/pull/57#discussion_r74619625 --- Diff: src/main/java/org/apache/pirk/schema/data/partitioner/PrimitiveTypePartitioner.java --- @@ -346,53 +309,14 @@ public Object

[GitHub] incubator-pirk pull request #58: Add maven plugin for displaying code covera...

GitHub user smarthi opened a pull request: https://github.com/apache/incubator-pirk/pull/58 Add maven plugin for displaying code coverage stats You can merge this pull request into a Git repository by running: $ git pull https://github.com/smarthi/incubator-pirk sundry

Re: Release Preparations

I am pushing in one last change in next 20 mins, this is to enable the code coverage badge on github. On Fri, Aug 12, 2016 at 12:05 PM, Ellison Anne Williams < eawilliamsp...@gmail.com> wrote: > I'm about to tag all of our completed/closed JIRA issues to-date with Fix > Version = 0.1.0 in

Release Preparations

I'm about to tag all of our completed/closed JIRA issues to-date with Fix Version = 0.1.0 in preparation for cutting our release branch later today. If you don't agree - please holler quickly! Otherwise, I will tag the issues, cut the branch (following a lot of guidelines that I will send out in

[GitHub] incubator-pirk issue #57: [PIRK-49] PrimitivePartioner does not account for ...

Github user smarthi commented on the issue: https://github.com/apache/incubator-pirk/pull/57 lgtm +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

Re: FindBugs in Eclipse

On Fri, Aug 12, 2016 at 11:23 AM, Tim Ellison wrote: > On 12/08/16 16:15, Suneel Marthi wrote: > > Most Apache committers I have known (most of Databricks, Hadoop vendors, > > Data Artisans and others) are all IntelliJ users and IntelliJ has > excellent > > code inspection

Re: KeyedHash#hash(String, int, String)

Thought that I responded to this -- oops - sorry! As hashes can be (naturally) negative, taking the absolute value avoid twos complement issues when we are only taking certain bits of the hash (instead of the whole thing). I would have to go back through to see if we could alleviate these issues

Re: FindBugs in Eclipse

Most Apache committers I have known (most of Databricks, Hadoop vendors, Data Artisans and others) are all IntelliJ users and IntelliJ has excellent code inspection (much much better than Eclipse). I personally never had a need for findbugs. On Fri, Aug 12, 2016 at 11:06 AM, Tim Ellison

[GitHub] incubator-pirk pull request #57: [PIRK-49] PrimitivePartioner does not accou...

GitHub user tellison opened a pull request: https://github.com/apache/incubator-pirk/pull/57 [PIRK-49] PrimitivePartioner does not account for locale settings - Ensure bytes are always encoded in network byte ordering. - Remove primitive type partitioner's unhealthy obsession

Re: KeyedHash#hash(String, int, String)

Anyone got thoughts on this? On 10/08/16 17:23, Tim Ellison wrote: > Why does > org.apache.pirk.utils.KeyedHash#hash(String key, int bitSize, String > input) > > have > int fullHash = Math.abs(concat.hashCode()); > > What is the value of performing the "Math.abs" in computing this hash? >

Re: FindBugs in Eclipse

On 12/08/16 14:16, Ellison Anne Williams wrote: > For Eclipse users, there is a Findbugs Eclipse plugin that is super easy to > use. You can find it here: > > https://marketplace.eclipse.org/content/findbugs-eclipse-plugin Yep, I agree. Though I hear rumours that not everybody is an Eclipse