[GitHub] incubator-pirk pull request #112: [PIRK-78] Create a QuerySchema builder for...

2016-10-24 Thread tellison
Github user tellison commented on a diff in the pull request: https://github.com/apache/incubator-pirk/pull/112#discussion_r84773126 --- Diff: src/test/java/org/apache/pirk/schema/query/LoadQuerySchemaTest.java --- @@ -389,49 +320,42 @@ private void createDataSchema(String schemaFi

[GitHub] incubator-pirk pull request #112: [PIRK-78] Create a QuerySchema builder for...

2016-10-24 Thread tellison
Github user tellison commented on a diff in the pull request: https://github.com/apache/incubator-pirk/pull/112#discussion_r84772832 --- Diff: src/main/java/org/apache/pirk/schema/query/QuerySchemaLoader.java --- @@ -226,50 +215,28 @@ public QuerySchema loadSchema(InputStream strea

[GitHub] incubator-pirk pull request #112: [PIRK-78] Create a QuerySchema builder for...

2016-10-24 Thread smarthi
Github user smarthi commented on a diff in the pull request: https://github.com/apache/incubator-pirk/pull/112#discussion_r84764924 --- Diff: src/test/java/org/apache/pirk/schema/query/LoadQuerySchemaTest.java --- @@ -389,49 +320,42 @@ private void createDataSchema(String schemaFil

[GitHub] incubator-pirk pull request #112: [PIRK-78] Create a QuerySchema builder for...

2016-10-24 Thread tellison
GitHub user tellison opened a pull request: https://github.com/apache/incubator-pirk/pull/112 [PIRK-78] Create a QuerySchema builder for assembling new schemas. - Define the new QuerySchemaBuilder type. - Remove QuerySchema building responsibilities from the loader. - Tidy