[GitHub] incubator-pirk pull request #105: [PIRK 71] Move Querier creation logic into...

Github user jryancarr commented on a diff in the pull request: https://github.com/apache/incubator-pirk/pull/105#discussion_r81340968 --- Diff: src/main/java/org/apache/pirk/querier/wideskies/QuerierFactory.java --- @@ -0,0 +1,115 @@ +/* + * Licensed to the Apache Software

Re: [GitHub] incubator-pirk pull request #105: [PIRK 71] Move Querier creation logic into...

I will take off the author info and push - I meant to do this yesterday when I reformatted... On Fri, Sep 30, 2016 at 5:31 AM, tellison wrote: > Github user tellison commented on a diff in the pull request: > >

[GitHub] incubator-pirk pull request #105: [PIRK 71] Move Querier creation logic into...

Github user tellison commented on a diff in the pull request: https://github.com/apache/incubator-pirk/pull/105#discussion_r81306398 --- Diff: src/main/java/org/apache/pirk/test/utils/StandaloneQuery.java --- @@ -77,25 +76,16 @@ logger.info("fileQuerier = " +

[GitHub] incubator-pirk pull request #105: [PIRK 71] Move Querier creation logic into...

Github user tellison commented on a diff in the pull request: https://github.com/apache/incubator-pirk/pull/105#discussion_r81304556 --- Diff: src/main/java/org/apache/pirk/querier/wideskies/EncryptionPropertiesBuilder.java --- @@ -0,0 +1,110 @@ +/* + * Licensed to the

[GitHub] incubator-pirk pull request #105: [PIRK 71] Move Querier creation logic into...

Github user tellison commented on a diff in the pull request: https://github.com/apache/incubator-pirk/pull/105#discussion_r81305132 --- Diff: src/main/java/org/apache/pirk/querier/wideskies/QuerierCLI.java --- @@ -131,12 +125,28 @@ private boolean parseOptions() //

[GitHub] incubator-pirk pull request #105: [PIRK 71] Move Querier creation logic into...

Github user tellison commented on a diff in the pull request: https://github.com/apache/incubator-pirk/pull/105#discussion_r81305924 --- Diff: src/main/java/org/apache/pirk/querier/wideskies/QuerierProps.java --- @@ -60,154 +59,179 @@ // Decryption properties static

[GitHub] incubator-pirk pull request #105: [PIRK 71] Move Querier creation logic into...

Github user asfgit closed the pull request at: https://github.com/apache/incubator-pirk/pull/105 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the