[GitHub] incubator-pirk pull request #106: [PIRK-73] - Change All Properties in Respo...

2016-10-06 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/incubator-pirk/pull/106 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

Re: [GitHub] incubator-pirk pull request #106: [PIRK-73] - Change All Properties in Respo...

2016-10-06 Thread Darin Johnson
Sorry wrong thread disregard. On Oct 6, 2016 6:37 PM, "Darin Johnson" wrote: > Being pretty familiar with that section of the code base right now. I > think a few things could be done. Regardless I'm refactoring it for > submodules do it'll be easier to iterate these. The main place I'd start

Re: [GitHub] incubator-pirk pull request #106: [PIRK-73] - Change All Properties in Respo...

2016-10-06 Thread Darin Johnson
Being pretty familiar with that section of the code base right now. I think a few things could be done. Regardless I'm refactoring it for submodules do it'll be easier to iterate these. The main place I'd start is currently each platform test creates a new input, which means the querier logic is

[GitHub] incubator-pirk pull request #106: [PIRK-73] - Change All Properties in Respo...

2016-10-06 Thread ellisonanne
GitHub user ellisonanne opened a pull request: https://github.com/apache/incubator-pirk/pull/106 [PIRK-73] - Change All Properties in ResponderProps to be public You can merge this pull request into a Git repository by running: $ git pull https://github.com/ellisonanne/incubat