Github user asfgit closed the pull request at:
https://github.com/apache/incubator-pirk/pull/81
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user tellison commented on a diff in the pull request:
https://github.com/apache/incubator-pirk/pull/81#discussion_r76517695
--- Diff:
src/main/java/org/apache/pirk/querier/wideskies/encrypt/EncryptQuery.java ---
@@ -163,8 +144,8 @@ public void encrypt(int numThreads)
Github user tellison commented on a diff in the pull request:
https://github.com/apache/incubator-pirk/pull/81#discussion_r76517506
--- Diff:
src/main/java/org/apache/pirk/querier/wideskies/encrypt/EncryptQuery.java ---
@@ -56,103 +56,84 @@
{
private static final
Github user ellisonanne commented on a diff in the pull request:
https://github.com/apache/incubator-pirk/pull/81#discussion_r76517354
--- Diff:
src/main/java/org/apache/pirk/querier/wideskies/encrypt/EncryptQuery.java ---
@@ -200,31 +181,29 @@ public void encrypt(int numThreads)
Github user ellisonanne commented on a diff in the pull request:
https://github.com/apache/incubator-pirk/pull/81#discussion_r76517343
--- Diff:
src/main/java/org/apache/pirk/querier/wideskies/encrypt/EncryptQuery.java ---
@@ -163,8 +144,8 @@ public void encrypt(int numThreads)
Github user ellisonanne commented on a diff in the pull request:
https://github.com/apache/incubator-pirk/pull/81#discussion_r76517300
--- Diff:
src/main/java/org/apache/pirk/querier/wideskies/encrypt/EncryptQuery.java ---
@@ -56,103 +56,84 @@
{
private static final
Github user tellison commented on a diff in the pull request:
https://github.com/apache/incubator-pirk/pull/81#discussion_r76516765
--- Diff:
src/main/java/org/apache/pirk/schema/data/partitioner/PrimitiveTypePartitioner.java
---
@@ -32,7 +32,7 @@
* Class for partitioning
Github user smarthi commented on a diff in the pull request:
https://github.com/apache/incubator-pirk/pull/81#discussion_r76514978
--- Diff:
src/main/java/org/apache/pirk/schema/data/partitioner/PrimitiveTypePartitioner.java
---
@@ -32,7 +32,7 @@
* Class for partitioning
GitHub user tellison opened a pull request:
https://github.com/apache/incubator-pirk/pull/81
Enhancements to Wideskies encrypt/decrypt.
- encrypt/decrypt now return their results, rather than have
side-effect on their instances.
- decryptor no longer responsible for
