[jira] [Assigned] (PIVOT-737) TerraTableViewSkin opens a TableViewRowEditor listening to both mouse buttons

2011-04-28 Thread Sandro Martini (JIRA)
[ https://issues.apache.org/jira/browse/PIVOT-737?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sandro Martini reassigned PIVOT-737: Assignee: Sandro Martini TerraTableViewSkin opens a TableViewRowEditor listening to both

[jira] [Resolved] (PIVOT-735) Strange problem with textarea

2011-04-28 Thread Noel Grandin (JIRA)
[ https://issues.apache.org/jira/browse/PIVOT-735?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Noel Grandin resolved PIVOT-735. Resolution: Fixed Assignee: Noel Grandin Fixed in rev 1097451 Strange problem with textarea

Re: [jira] [Resolved] (PIVOT-735) Strange problem with textarea

2011-04-28 Thread Greg Brown
Hi Noel, Thanks for fixing this. I looked at the fix but it wasn't immediately clear what the problem was. Would you mind summarizing? Thanks, Greg On Apr 28, 2011, at 9:30 AM, Noel Grandin (JIRA) wrote: [

Re: [jira] [Resolved] (PIVOT-735) Strange problem with textarea

2011-04-28 Thread Noel Grandin
As far as I can tell, layout() is only called on a component when something about the layout structure of that component changes. So it doesn't seem necessarily true that paint() is always preceded by layout(). -- Noel. Greg Brown wrote: OK. It is a small patch that seems to fix the issue, so

Re: [jira] [Resolved] (PIVOT-735) Strange problem with textarea

2011-04-28 Thread Greg Brown
layout() is called whenever the component is validated. A component starts out in an invalid state, so at least one call to layout() is guaranteed. After that, a call to layout() will follow any call to invalidate(). As you said, this should happen any time something that affects the

Re: [jira] [Resolved] (PIVOT-735) Strange problem with textarea

2011-04-28 Thread Greg Brown
To put it another way, the design expects that a call to paint() will be preceded by a call to layout(). So if this isn't happening, then there is probably a bug somewhere. G On Apr 28, 2011, at 10:56 AM, Greg Brown wrote: layout() is called whenever the component is validated. A component

Re: [jira] [Resolved] (PIVOT-735) Strange problem with textarea

2011-04-28 Thread Greg Brown
No, that's not the case. Well, it's supposed to be, since that's the way I designed it to work. :-) I think there is a design pattern mismatch here. We have the general situation that our getPreferredSize() methods never update internal layout information fields. But TextAreaSkin is